2021-02-26 06:22:29

by Dongli Zhang

Subject: [PATCH v2 1/1] KVM: x86: remove misplaced comment on active_mmu_pages

The 'mmu_page_hash' is used as hash table while 'active_mmu_pages' is a
list. Remove the misplaced comment as it's mostly stating the obvious
anyways.

Signed-off-by: Dongli Zhang <[email protected]>
Reviewed-by: Sean Christopherson <[email protected]>
---
Changed since v1:
- change 'incorrect' to 'misplaced'

arch/x86/include/asm/kvm_host.h | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index 84499aad01a4..318242512407 100644
--- a/arch/x86/include/asm/kvm_host.h
+++ b/arch/x86/include/asm/kvm_host.h
@@ -937,9 +937,6 @@ struct kvm_arch {
unsigned int indirect_shadow_pages;
u8 mmu_valid_gen;
struct hlist_head mmu_page_hash[KVM_NUM_MMU_PAGES];
- /*
- * Hash table of struct kvm_mmu_page.
- */
struct list_head active_mmu_pages;
struct list_head zapped_obsolete_pages;
struct list_head lpage_disallowed_mmu_pages;
--
2.17.1

2021-02-26 08:07:37

by Paolo Bonzini

Subject: Re: [PATCH v2 1/1] KVM: x86: remove misplaced comment on active_mmu_pages

On 26/02/21 07:19, Dongli Zhang wrote:
> The 'mmu_page_hash' is used as hash table while 'active_mmu_pages' is a
> list. Remove the misplaced comment as it's mostly stating the obvious
> anyways.
>
> Signed-off-by: Dongli Zhang <[email protected]>
> Reviewed-by: Sean Christopherson <[email protected]>
> ---
> Changed since v1:
> - change 'incorrect' to 'misplaced'
>
> arch/x86/include/asm/kvm_host.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 84499aad01a4..318242512407 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -937,9 +937,6 @@ struct kvm_arch {
> unsigned int indirect_shadow_pages;
> u8 mmu_valid_gen;
> struct hlist_head mmu_page_hash[KVM_NUM_MMU_PAGES];
> - /*
> - * Hash table of struct kvm_mmu_page.
> - */
> struct list_head active_mmu_pages;
> struct list_head zapped_obsolete_pages;
> struct list_head lpage_disallowed_mmu_pages;
>

Queued, thanks.

Paolo