2021-06-08 05:16:23

by Aswath Govindraju

[permalink] [raw]
Subject: [PATCH v2 1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema

ti,pindir-d0-out-d1-in property is expected to be of type boolean.
Therefore, fix the property accordingly.

Fixes: e180f76d0641 ("arm64: dts: ti: Add support for Siemens IOT2050 boards")
Fixes: 5da94b50475a ("arm64: dts: ti: k3-am654: Enable main domain McSPI0")
Signed-off-by: Aswath Govindraju <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
index f4ec9ed52939..23d51b6a9cf2 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
@@ -575,7 +575,7 @@

#address-cells = <1>;
#size-cells= <0>;
- ti,pindir-d0-out-d1-in = <1>;
+ ti,pindir-d0-out-d1-in;
};

&tscadc0 {
diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
index eddb2ffb93ca..1b947e2c2e74 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
@@ -299,7 +299,7 @@
pinctrl-0 = <&main_spi0_pins_default>;
#address-cells = <1>;
#size-cells= <0>;
- ti,pindir-d0-out-d1-in = <1>;
+ ti,pindir-d0-out-d1-in;

flash@0{
compatible = "jedec,spi-nor";
--
2.17.1


2021-06-08 05:25:06

by Jan Kiszka

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema

On 08.06.21 07:14, Aswath Govindraju wrote:
> ti,pindir-d0-out-d1-in property is expected to be of type boolean.
> Therefore, fix the property accordingly.
>

Is there a patch for Documentation/devicetree/bindings/spi/omap-spi.txt
on the way as well that makes this even clearer?

> Fixes: e180f76d0641 ("arm64: dts: ti: Add support for Siemens IOT2050 boards")
> Fixes: 5da94b50475a ("arm64: dts: ti: k3-am654: Enable main domain McSPI0")
> Signed-off-by: Aswath Govindraju <[email protected]>
> ---
> arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index f4ec9ed52939..23d51b6a9cf2 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -575,7 +575,7 @@
>
> #address-cells = <1>;
> #size-cells= <0>;
> - ti,pindir-d0-out-d1-in = <1>;
> + ti,pindir-d0-out-d1-in;
> };
>

Acked-by: Jan Kiszka <[email protected]>

Jan

> &tscadc0 {
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index eddb2ffb93ca..1b947e2c2e74 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -299,7 +299,7 @@
> pinctrl-0 = <&main_spi0_pins_default>;
> #address-cells = <1>;
> #size-cells= <0>;
> - ti,pindir-d0-out-d1-in = <1>;
> + ti,pindir-d0-out-d1-in;
>
> flash@0{
> compatible = "jedec,spi-nor";
>


--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

2021-06-08 05:28:15

by Aswath Govindraju

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema

Hi Jan,

On 08/06/21 10:50 am, Jan Kiszka wrote:
> On 08.06.21 07:14, Aswath Govindraju wrote:
>> ti,pindir-d0-out-d1-in property is expected to be of type boolean.
>> Therefore, fix the property accordingly.
>>
>
> Is there a patch for Documentation/devicetree/bindings/spi/omap-spi.txt
> on the way as well that makes this even clearer?
>

Yes, these fixes are a part of conversion of omap-spi.txt to yaml
format. In the yaml file the type for the property is mentioned.

Link to yaml conversion patch,
https://lore.kernel.org/patchwork/project/lkml/list/?series=503240

>> Fixes: e180f76d0641 ("arm64: dts: ti: Add support for Siemens IOT2050 boards")
>> Fixes: 5da94b50475a ("arm64: dts: ti: k3-am654: Enable main domain McSPI0")
>> Signed-off-by: Aswath Govindraju <[email protected]>
>> ---
>> arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
>> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> index f4ec9ed52939..23d51b6a9cf2 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> @@ -575,7 +575,7 @@
>>
>> #address-cells = <1>;
>> #size-cells= <0>;
>> - ti,pindir-d0-out-d1-in = <1>;
>> + ti,pindir-d0-out-d1-in;
>> };
>>
>
> Acked-by: Jan Kiszka <[email protected]>
>

Thanks,
Aswath

> Jan
>
>> &tscadc0 {
>> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> index eddb2ffb93ca..1b947e2c2e74 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> @@ -299,7 +299,7 @@
>> pinctrl-0 = <&main_spi0_pins_default>;
>> #address-cells = <1>;
>> #size-cells= <0>;
>> - ti,pindir-d0-out-d1-in = <1>;
>> + ti,pindir-d0-out-d1-in;
>>
>> flash@0{
>> compatible = "jedec,spi-nor";
>>
>
>

2021-06-09 18:45:14

by Vignesh Raghavendra

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] arm64: dts: ti: am65: align ti,pindir-d0-out-d1-in property with dt-shema



On 6/8/21 10:44 AM, Aswath Govindraju wrote:
> ti,pindir-d0-out-d1-in property is expected to be of type boolean.
> Therefore, fix the property accordingly.
>
> Fixes: e180f76d0641 ("arm64: dts: ti: Add support for Siemens IOT2050 boards")
> Fixes: 5da94b50475a ("arm64: dts: ti: k3-am654: Enable main domain McSPI0")
> Signed-off-by: Aswath Govindraju <[email protected]>
> ---
> arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index f4ec9ed52939..23d51b6a9cf2 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -575,7 +575,7 @@
>
> #address-cells = <1>;
> #size-cells= <0>;
> - ti,pindir-d0-out-d1-in = <1>;
> + ti,pindir-d0-out-d1-in;
> };
>
> &tscadc0 {
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index eddb2ffb93ca..1b947e2c2e74 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -299,7 +299,7 @@
> pinctrl-0 = <&main_spi0_pins_default>;
> #address-cells = <1>;
> #size-cells= <0>;
> - ti,pindir-d0-out-d1-in = <1>;
> + ti,pindir-d0-out-d1-in;
>
> flash@0{
> compatible = "jedec,spi-nor";


Reviewed-by: Vignesh Raghavendra <[email protected]>


Regards
Vignesh