2019-11-10 05:33:47

by Chuanhong Guo

Subject: [PATCH] mtd: spi-nor: add dual and quad read support for w25q128

The only w25q128 variant I could find with 0xef4018 as ID is
w25q128fv, which supports both dual and quad read mode.
Add these two flags in chip info.

Signed-off-by: Chuanhong Guo <[email protected]>
---
drivers/mtd/spi-nor/spi-nor.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index f89620005198..6adf16259841 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -2479,7 +2479,10 @@ static const struct flash_info spi_nor_ids[] = {
},
{ "w25q80", INFO(0xef5014, 0, 64 * 1024, 16, SECT_4K) },
{ "w25q80bl", INFO(0xef4014, 0, 64 * 1024, 16, SECT_4K) },
- { "w25q128", INFO(0xef4018, 0, 64 * 1024, 256, SECT_4K) },
+ {
+ "w25q128", INFO(0xef4018, 0, 64 * 1024, 256,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
+ },
{ "w25q256", INFO(0xef4019, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "w25q256jvm", INFO(0xef7019, 0, 64 * 1024, 512,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
--
2.21.0

2019-11-11 06:49:31

by Tudor Ambarus

Subject: Re: [PATCH] mtd: spi-nor: add dual and quad read support for w25q128

On 11/10/2019 07:32 AM, Chuanhong Guo wrote:
> The only w25q128 variant I could find with 0xef4018 as ID is
> w25q128fv, which supports both dual and quad read mode.
> Add these two flags in chip info.
>
> Signed-off-by: Chuanhong Guo <[email protected]>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)

Hi,

This duplicates the first patch in
https://patchwork.ozlabs.org/project/linux-mtd/list/?series=139324. Can I have
your Reviewed-by tag on those instead?

Thanks,
ta