2022-04-01 14:52:22

by Jakob Koschel

[permalink] [raw]
Subject: Re: [PATCH] staging: android: ashmem: remove usage of list iterator after the loop body



> On 1. Apr 2022, at 07:38, Greg Kroah-Hartman <[email protected]> wrote:
>
> On Thu, Mar 31, 2022 at 11:39:34PM +0200, Jakob Koschel wrote:
>> In preparation to limit the scope of a list iterator to the list
>> traversal loop, use a dedicated pointer to point to the found element
>> [1].
>>
>> Before, the code implicitly used the head when no element was found
>> when using &pos->list. Since the new variable is only set if an
>> element was found, the head needs to be used explicitly if the
>> variable is NULL.
>>
>> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
>> Signed-off-by: Jakob Koschel <[email protected]>
>> ---
>> drivers/staging/android/ashmem.c | 21 ++++++++++++---------
>> 1 file changed, 12 insertions(+), 9 deletions(-)
>
> What tree did you make this against? This file is no longer in Linus's
> tree.

Looks like the driver was removed just a few hours after I rebased.
Feel free to just ignore this patch.

>
> thanks,
>
> greg k-h

Thanks,
Jakob