2008-12-15 21:49:31

by Pallipadi, Venkatesh

[permalink] [raw]
Subject: RE: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn


Ingo,

Haven't seen any comments on the patches here. Can you push these patches along to tip.

Thanks,
Venki

>-----Original Message-----
>From: Pallipadi, Venkatesh
>Sent: Tuesday, November 25, 2008 4:22 PM
>To: [email protected]; [email protected];
>[email protected]; [email protected]; [email protected]; [email protected]
>Cc: [email protected]; [email protected];
>[email protected]; [email protected]; linux-kernel@;
>Siddha, Suresh B
>Subject: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with
>remap_pfn_range and vm_insert_pfn
>
>Followup for the patches posted earlier here:
>http://marc.info/?l=linux-kernel&m=122653213110404&w=2
>
>Drivers use mmap followed by pgprot_* and remap_pfn_range or
>vm_insert_pfn,
>in order to export reserved memory to userspace. Currently,
>such mappings are
>not tracked and hence not kept consistent with other mappings
>(/dev/mem,
>pci resource, ioremap) for the sme memory, that may exist in
>the system.
>
>The following patchset adds x86 PAT attribute tracking and
>untracking for
>pfnmap related APIs.
>
>First three patches in the patchset are changing the generic
>mm code to fit
>in this tracking. Last four patches are x86 specific to make
>things work
>with x86 PAT code. The patchset aso introduces
>pgprot_writecombine interface,
>which gives writecombine mapping when enabled, falling back to
>pgprot_noncached otherwise.
>
>
>--
>
>


2008-12-16 19:52:23

by Ingo Molnar

[permalink] [raw]
Subject: Re: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn


* Pallipadi, Venkatesh <[email protected]> wrote:

> Ingo,
>
> Haven't seen any comments on the patches here. Can you push these
> patches along to tip.

while the main focus of the changes are x86, they touch the MM
non-trivially too:

include/linux/mm.h | 9 +++++++++
mm/memory.c | 7 +++----
2 files changed, 12 insertions(+), 4 deletions(-)

mm/memory.c | 2 ++
1 file changed, 2 insertions(+)

include/linux/mm.h | 3 +++
mm/memory.c | 43 +++++++++++++++++++++++++++++++++++++++++++
2 files changed, 46 insertions(+)

include/linux/mm.h | 6 +++++
mm/memory.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
2 files changed, 59 insertions(+), 1 deletion(-)

So when you sent this a month ago i asked the MM folks whether they have
any problems with these patches. Acks (or objections) from Andrew, Nick or
Hugh would be nice to have.

Ingo

2008-12-16 22:05:28

by Nick Piggin

[permalink] [raw]
Subject: Re: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn

On Tue, Dec 16, 2008 at 08:51:54PM +0100, Ingo Molnar wrote:
>
> * Pallipadi, Venkatesh <[email protected]> wrote:
>
> > Ingo,
> >
> > Haven't seen any comments on the patches here. Can you push these
> > patches along to tip.
>
> while the main focus of the changes are x86, they touch the MM
> non-trivially too:
>
> include/linux/mm.h | 9 +++++++++
> mm/memory.c | 7 +++----
> 2 files changed, 12 insertions(+), 4 deletions(-)
>
> mm/memory.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> include/linux/mm.h | 3 +++
> mm/memory.c | 43 +++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 46 insertions(+)
>
> include/linux/mm.h | 6 +++++
> mm/memory.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 59 insertions(+), 1 deletion(-)
>
> So when you sent this a month ago i asked the MM folks whether they have
> any problems with these patches. Acks (or objections) from Andrew, Nick or
> Hugh would be nice to have.

Last I looked at them, I think all my questions were cleared up.

2008-12-16 22:08:21

by Ingo Molnar

[permalink] [raw]
Subject: Re: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn


* Nick Piggin <[email protected]> wrote:

> On Tue, Dec 16, 2008 at 08:51:54PM +0100, Ingo Molnar wrote:
> >
> > * Pallipadi, Venkatesh <[email protected]> wrote:
> >
> > > Ingo,
> > >
> > > Haven't seen any comments on the patches here. Can you push these
> > > patches along to tip.
> >
> > while the main focus of the changes are x86, they touch the MM
> > non-trivially too:
> >
> > include/linux/mm.h | 9 +++++++++
> > mm/memory.c | 7 +++----
> > 2 files changed, 12 insertions(+), 4 deletions(-)
> >
> > mm/memory.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > include/linux/mm.h | 3 +++
> > mm/memory.c | 43 +++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 46 insertions(+)
> >
> > include/linux/mm.h | 6 +++++
> > mm/memory.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
> > 2 files changed, 59 insertions(+), 1 deletion(-)
> >
> > So when you sent this a month ago i asked the MM folks whether they have
> > any problems with these patches. Acks (or objections) from Andrew, Nick or
> > Hugh would be nice to have.
>
> Last I looked at them, I think all my questions were cleared up.

does that transform into a:

Acked-by: Nick Piggin <[email protected]>

? :-)

Ingo

2008-12-17 08:19:49

by Nick Piggin

[permalink] [raw]
Subject: Re: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn

On Tue, Dec 16, 2008 at 11:07:46PM +0100, Ingo Molnar wrote:
>
> * Nick Piggin <[email protected]> wrote:
> > > So when you sent this a month ago i asked the MM folks whether they have
> > > any problems with these patches. Acks (or objections) from Andrew, Nick or
> > > Hugh would be nice to have.
> >
> > Last I looked at them, I think all my questions were cleared up.
>
> does that transform into a:
>
> Acked-by: Nick Piggin <[email protected]>

I should think so ;), but I'll take another glance at the next round
after Andrew's comments were incorporated. Are those available?

2008-12-18 14:32:13

by Ingo Molnar

[permalink] [raw]
Subject: Re: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn


* Nick Piggin <[email protected]> wrote:

> On Tue, Dec 16, 2008 at 11:07:46PM +0100, Ingo Molnar wrote:
> >
> > * Nick Piggin <[email protected]> wrote:
> > > > So when you sent this a month ago i asked the MM folks whether they have
> > > > any problems with these patches. Acks (or objections) from Andrew, Nick or
> > > > Hugh would be nice to have.
> > >
> > > Last I looked at them, I think all my questions were cleared up.
> >
> > does that transform into a:
> >
> > Acked-by: Nick Piggin <[email protected]>
>
> I should think so ;), but I'll take another glance at the next round
> after Andrew's comments were incorporated. Are those available?

not yet available - Venki, would you mind to resend the series with those
bits fixed, so that Nick can have a look at the end result? Thanks,

Ingo

2008-12-18 17:16:20

by Pallipadi, Venkatesh

[permalink] [raw]
Subject: RE: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn



>-----Original Message-----
>From: Ingo Molnar [mailto:[email protected]]
>Sent: Thursday, December 18, 2008 6:32 AM
>To: Nick Piggin
>Cc: Pallipadi, Venkatesh; Andrew Morton; Hugh Dickins;
>[email protected]; [email protected]; [email protected]
>Subject: Re: [patch 0/7] x86 PAT: v2 - track pfnmap mappings
>with remap_pfn_range and vm_insert_pfn
>
>
>* Nick Piggin <[email protected]> wrote:
>
>> On Tue, Dec 16, 2008 at 11:07:46PM +0100, Ingo Molnar wrote:
>> >
>> > * Nick Piggin <[email protected]> wrote:
>> > > > So when you sent this a month ago i asked the MM folks
>whether they have
>> > > > any problems with these patches. Acks (or objections)
>from Andrew, Nick or
>> > > > Hugh would be nice to have.
>> > >
>> > > Last I looked at them, I think all my questions were cleared up.
>> >
>> > does that transform into a:
>> >
>> > Acked-by: Nick Piggin <[email protected]>
>>
>> I should think so ;), but I'll take another glance at the next round
>> after Andrew's comments were incorporated. Are those available?
>
>not yet available - Venki, would you mind to resend the series
>with those
>bits fixed, so that Nick can have a look at the end result? Thanks,
>

Yes. Working on it right now and should have it later today..

Thanks,
Venki-