2008-03-21 23:05:48

by Chris Wright

Subject: [patch 51/76] ioat: fix ack handling, driver must ensure that ack is zero

-stable review patch. If anyone has any objections, please let us know.
---------------------

From: Dan Williams <[email protected]>

Initialize 'ack' to zero in case the descriptor has been recycled.

Prevents "kernel BUG at crypto/async_tx/async_xor.c:185!"

Signed-off-by: Dan Williams <[email protected]>
Acked-by: Shannon Nelson <[email protected]>
[[email protected]: backport to 2.6.24.3]
Signed-off-by: Chris Wright <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---

drivers/dma/ioat_dma.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/dma/ioat_dma.c
+++ b/drivers/dma/ioat_dma.c
@@ -726,6 +726,7 @@ static struct dma_async_tx_descriptor *i

if (new) {
new->len = len;
+ new->async_tx.ack = 0;
return &new->async_tx;
} else
return NULL;
@@ -749,6 +750,7 @@ static struct dma_async_tx_descriptor *i

if (new) {
new->len = len;
+ new->async_tx.ack = 0;
return &new->async_tx;
} else
return NULL;

--

2008-03-25 16:02:29

by Sosnowski, Maciej

Subject: RE: [patch 51/76] ioat: fix ack handling, driver must ensure that ack is zero

> ---------- Original message ----------
> From: Chris Wright <[email protected]>
> Date: Mar 21, 2008 11:43 PM
> Subject: [patch 51/76] ioat: fix ack handling, driver must ensure that
> ack is zero
> To: [email protected], [email protected], [email protected]
> Cc: Justin Forbes <[email protected]>, Zwane Mwaikambo
> <[email protected]>, Theodore Ts'o <[email protected]>, Randy Dunlap
> <[email protected]>, Dave Jones <[email protected]>, Chuck Wolber
> <[email protected]>, Chris Wedgwood <[email protected]>,
> Michael Krufky <[email protected]>, Chuck Ebbert
> <[email protected]>, Domenico Andreoli <[email protected]>,
> [email protected], [email protected],
> [email protected], Dan Williams <[email protected]>,
> Shannon Nelson <[email protected]>, Greg Kroah-Hartman
> <[email protected]>
>
>
> -stable review patch. If anyone has any objections, please let us
know.
> ---------------------
>
> From: Dan Williams <[email protected]>
>
> Initialize 'ack' to zero in case the descriptor has been recycled.
>
> Prevents "kernel BUG at crypto/async_tx/async_xor.c:185!"
>
> Signed-off-by: Dan Williams <[email protected]>
> Acked-by: Shannon Nelson <[email protected]>
> [[email protected]: backport to 2.6.24.3]
> Signed-off-by: Chris Wright <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
>
> drivers/dma/ioat_dma.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- a/drivers/dma/ioat_dma.c
> +++ b/drivers/dma/ioat_dma.c
> @@ -726,6 +726,7 @@ static struct dma_async_tx_descriptor *i
>
> if (new) {
> new->len = len;
> + new->async_tx.ack = 0;
> return &new->async_tx;
> } else
> return NULL;
> @@ -749,6 +750,7 @@ static struct dma_async_tx_descriptor *i
>
> if (new) {
> new->len = len;
> + new->async_tx.ack = 0;
> return &new->async_tx;
> } else
> return NULL;
>
> --

Acked-by: Maciej Sosnowski <[email protected]>
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
z siedziba w Gdansku
ul. Slowackiego 173
80-298 Gdansk

Sad Rejonowy Gdansk Polnoc w Gdansku,
VII Wydzial Gospodarczy Krajowego Rejestru Sadowego,
numer KRS 101882

NIP 957-07-52-316
Kapital zakladowy 200.000 zl

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.