2019-08-14 07:45:10

by Rocky Liao

Subject: [PATCH v1] Bluetooth: hci_qca: Skip 1 error print in device_want_to_sleep()

Don't fall through to print error message when receive sleep indication
in HCI_IBS_RX_ASLEEP state, this is allowed behavior.

Signed-off-by: Rocky Liao <[email protected]>
---
drivers/bluetooth/hci_qca.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index a054210..2affb4e 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -686,7 +686,7 @@ static void device_want_to_sleep(struct hci_uart *hu)
unsigned long flags;
struct qca_data *qca = hu->priv;

- BT_DBG("hu %p want to sleep", hu);
+ BT_DBG("hu %p want to sleep in %d state", hu, qca->rx_ibs_state);

spin_lock_irqsave(&qca->hci_ibs_lock, flags);

@@ -701,7 +701,7 @@ static void device_want_to_sleep(struct hci_uart *hu)
break;

case HCI_IBS_RX_ASLEEP:
- /* Fall through */
+ break;

default:
/* Any other state is illegal */
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

2019-08-14 13:53:12

by Marcel Holtmann

Subject: Re: [PATCH v1] Bluetooth: hci_qca: Skip 1 error print in device_want_to_sleep()

Hi Rocky,

> Don't fall through to print error message when receive sleep indication
> in HCI_IBS_RX_ASLEEP state, this is allowed behavior.
>
> Signed-off-by: Rocky Liao <[email protected]>
> ---
> drivers/bluetooth/hci_qca.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

patch has been applied to bluetooth-stable tree.

Regards

Marcel