2021-06-09 17:08:21

by Hsin-Yi Wang

Subject: [PATCH v2] arm64: dts: mt8183: add jpeg enc node for mt8183

From: Maoguang Meng <[email protected]>

Add jpeg encoder device tree node.

Signed-off-by: Maoguang Meng <[email protected]>
Signed-off-by: Hsin-Yi Wang <[email protected]>
---
v2: rebase to latest
v1: https://patchwork.kernel.org/project/linux-media/patch/[email protected]/
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index c5e822b6b77a3..fffe0c52909ce 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -1329,6 +1329,17 @@ larb4: larb@17010000 {
power-domains = <&spm MT8183_POWER_DOMAIN_VENC>;
};

+ venc_jpg: venc_jpg@17030000 {
+ compatible = "mediatek,mt8183-jpgenc", "mediatek,mtk-jpgenc";
+ reg = <0 0x17030000 0 0x1000>;
+ interrupts = <GIC_SPI 249 IRQ_TYPE_LEVEL_LOW>;
+ iommus = <&iommu M4U_PORT_JPGENC_RDMA>,
+ <&iommu M4U_PORT_JPGENC_BSDMA>;
+ power-domains = <&spm MT8183_POWER_DOMAIN_VENC>;
+ clocks = <&vencsys CLK_VENC_JPGENC>;
+ clock-names = "jpgenc";
+ };
+
ipu_conn: syscon@19000000 {
compatible = "mediatek,mt8183-ipu_conn", "syscon";
reg = <0 0x19000000 0 0x1000>;
--
2.32.0.rc1.229.g3e70b5a671-goog

2021-06-09 17:11:17

by Matthias Brugger

Subject: Re: [PATCH v2] arm64: dts: mt8183: add jpeg enc node for mt8183

On 09/06/2021 06:48, Hsin-Yi Wang wrote:
> From: Maoguang Meng <[email protected]>
>
> Add jpeg encoder device tree node.
>
> Signed-off-by: Maoguang Meng <[email protected]>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> ---
> v2: rebase to latest
> v1: https://patchwork.kernel.org/project/linux-media/patch/[email protected]/
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index c5e822b6b77a3..fffe0c52909ce 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1329,6 +1329,17 @@ larb4: larb@17010000 {
> power-domains = <&spm MT8183_POWER_DOMAIN_VENC>;
> };
>
> + venc_jpg: venc_jpg@17030000 {
> + compatible = "mediatek,mt8183-jpgenc", "mediatek,mtk-jpgenc";

We are missing "mediatek,mt8183-jpgenc" in mediatek-jpeg-encoder.txt. Would be
great if you could help to convert it to yaml before adding the new compatible.

Thanks!
Matthias
> + reg = <0 0x17030000 0 0x1000>;
> + interrupts = <GIC_SPI 249 IRQ_TYPE_LEVEL_LOW>;
> + iommus = <&iommu M4U_PORT_JPGENC_RDMA>,
> + <&iommu M4U_PORT_JPGENC_BSDMA>;
> + power-domains = <&spm MT8183_POWER_DOMAIN_VENC>;
> + clocks = <&vencsys CLK_VENC_JPGENC>;
> + clock-names = "jpgenc";
> + };
> +
> ipu_conn: syscon@19000000 {
> compatible = "mediatek,mt8183-ipu_conn", "syscon";
> reg = <0 0x19000000 0 0x1000>;
>