2024-03-25 15:04:16

by Andy Shevchenko

[permalink] [raw]
Subject: [PATCH v1 2/3] hwmon: (pmbus/mp2975) Constify local pointers to pmbus_driver_info

Constify the local variables pointing to "struct pmbus_driver_info" and
other encoding params to annotate the function is not modifying pointed
data.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/hwmon/pmbus/mp2975.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/pmbus/mp2975.c b/drivers/hwmon/pmbus/mp2975.c
index af118087c4ee..bc7558dc87ee 100644
--- a/drivers/hwmon/pmbus/mp2975.c
+++ b/drivers/hwmon/pmbus/mp2975.c
@@ -942,7 +942,7 @@ mp2975_vout_per_rail_config_get(struct i2c_client *client,
return 0;
}

-static struct pmbus_driver_info mp2975_info = {
+static const struct pmbus_driver_info mp2975_info = {
.pages = 1,
.format[PSC_VOLTAGE_IN] = linear,
.format[PSC_VOLTAGE_OUT] = direct,
@@ -967,7 +967,7 @@ static struct pmbus_driver_info mp2975_info = {
#endif
};

-static struct pmbus_driver_info mp2973_info = {
+static const struct pmbus_driver_info mp2973_info = {
.pages = 1,
.format[PSC_VOLTAGE_IN] = linear,
.format[PSC_VOLTAGE_OUT] = direct,
--
2.43.0.rc1.1.gbec44491f096



2024-03-25 18:46:02

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v1 2/3] hwmon: (pmbus/mp2975) Constify local pointers to pmbus_driver_info

On Mon, Mar 25, 2024 at 02:07:43PM +0200, Andy Shevchenko wrote:
> Constify the local variables pointing to "struct pmbus_driver_info" and
> other encoding params to annotate the function is not modifying pointed
> data.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Applied.

Thanks,
Guenter