2020-10-07 18:59:59

by Matthew Rosato

[permalink] [raw]
Subject: [PATCH v3 0/5] Pass zPCI hardware information via VFIO

This patchset provides a means by which hardware information about the
underlying PCI device can be passed up to userspace (ie, QEMU) so that
this hardware information can be used rather than previously hard-coded
assumptions. The VFIO_DEVICE_GET_INFO ioctl is extended to allow capability
chains and zPCI devices provide the hardware information via capabilities.

A form of these patches saw some rounds last year but has been back-
tabled for a while. The original work for this feature was done by Pierre
Morel. I'd like to refresh the discussion on this and get this finished up
so that we can move forward with better-supporting additional types of
PCI-attached devices.

This feature is toggled via the CONFIG_VFIO_PCI_ZDEV configuration entry.

Changes since v2:
- Added ACKs (thanks!)
- Patch 3+4: Re-write to use VFIO_DEVICE_GET_INFO capabilities rather than
a vfio device region.

Matthew Rosato (5):
s390/pci: stash version in the zpci_dev
s390/pci: track whether util_str is valid in the zpci_dev
vfio: Introduce capability definitions for VFIO_DEVICE_GET_INFO
vfio-pci/zdev: Add zPCI capabilities to VFIO_DEVICE_GET_INFO
MAINTAINERS: Add entry for s390 vfio-pci

MAINTAINERS | 8 ++
arch/s390/include/asm/pci.h | 4 +-
arch/s390/pci/pci_clp.c | 2 +
drivers/vfio/pci/Kconfig | 13 ++++
drivers/vfio/pci/Makefile | 1 +
drivers/vfio/pci/vfio_pci.c | 37 ++++++++++
drivers/vfio/pci/vfio_pci_private.h | 12 +++
drivers/vfio/pci/vfio_pci_zdev.c | 143 ++++++++++++++++++++++++++++++++++++
include/uapi/linux/vfio.h | 11 +++
include/uapi/linux/vfio_zdev.h | 78 ++++++++++++++++++++
10 files changed, 308 insertions(+), 1 deletion(-)
create mode 100644 drivers/vfio/pci/vfio_pci_zdev.c
create mode 100644 include/uapi/linux/vfio_zdev.h

--
1.8.3.1


2020-10-07 19:59:19

by Matthew Rosato

[permalink] [raw]
Subject: Re: [PATCH v3 0/5] Pass zPCI hardware information via VFIO

On 10/7/20 2:56 PM, Matthew Rosato wrote:
> This patchset provides a means by which hardware information about the
> underlying PCI device can be passed up to userspace (ie, QEMU) so that
> this hardware information can be used rather than previously hard-coded
> assumptions. The VFIO_DEVICE_GET_INFO ioctl is extended to allow capability
> chains and zPCI devices provide the hardware information via capabilities.
>
> A form of these patches saw some rounds last year but has been back-
> tabled for a while. The original work for this feature was done by Pierre
> Morel. I'd like to refresh the discussion on this and get this finished up
> so that we can move forward with better-supporting additional types of
> PCI-attached devices.
>
> This feature is toggled via the CONFIG_VFIO_PCI_ZDEV configuration entry.
>
> Changes since v2:
> - Added ACKs (thanks!)
> - Patch 3+4: Re-write to use VFIO_DEVICE_GET_INFO capabilities rather than
> a vfio device region.

Link to latest QEMU patch set:
https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg01948.html

>
> Matthew Rosato (5):
> s390/pci: stash version in the zpci_dev
> s390/pci: track whether util_str is valid in the zpci_dev
> vfio: Introduce capability definitions for VFIO_DEVICE_GET_INFO
> vfio-pci/zdev: Add zPCI capabilities to VFIO_DEVICE_GET_INFO
> MAINTAINERS: Add entry for s390 vfio-pci
>
> MAINTAINERS | 8 ++
> arch/s390/include/asm/pci.h | 4 +-
> arch/s390/pci/pci_clp.c | 2 +
> drivers/vfio/pci/Kconfig | 13 ++++
> drivers/vfio/pci/Makefile | 1 +
> drivers/vfio/pci/vfio_pci.c | 37 ++++++++++
> drivers/vfio/pci/vfio_pci_private.h | 12 +++
> drivers/vfio/pci/vfio_pci_zdev.c | 143 ++++++++++++++++++++++++++++++++++++
> include/uapi/linux/vfio.h | 11 +++
> include/uapi/linux/vfio_zdev.h | 78 ++++++++++++++++++++
> 10 files changed, 308 insertions(+), 1 deletion(-)
> create mode 100644 drivers/vfio/pci/vfio_pci_zdev.c
> create mode 100644 include/uapi/linux/vfio_zdev.h
>

2020-10-07 20:08:21

by Alex Williamson

[permalink] [raw]
Subject: Re: [PATCH v3 0/5] Pass zPCI hardware information via VFIO

On Wed, 7 Oct 2020 14:56:19 -0400
Matthew Rosato <[email protected]> wrote:

> This patchset provides a means by which hardware information about the
> underlying PCI device can be passed up to userspace (ie, QEMU) so that
> this hardware information can be used rather than previously hard-coded
> assumptions. The VFIO_DEVICE_GET_INFO ioctl is extended to allow capability
> chains and zPCI devices provide the hardware information via capabilities.
>
> A form of these patches saw some rounds last year but has been back-
> tabled for a while. The original work for this feature was done by Pierre
> Morel. I'd like to refresh the discussion on this and get this finished up
> so that we can move forward with better-supporting additional types of
> PCI-attached devices.
>
> This feature is toggled via the CONFIG_VFIO_PCI_ZDEV configuration entry.
>
> Changes since v2:
> - Added ACKs (thanks!)
> - Patch 3+4: Re-write to use VFIO_DEVICE_GET_INFO capabilities rather than
> a vfio device region.

Looks good to me, I'll let Connie and others double check and throw in
their reviews, but I'll plan to include this for v5.10. Thanks,

Alex

> Matthew Rosato (5):
> s390/pci: stash version in the zpci_dev
> s390/pci: track whether util_str is valid in the zpci_dev
> vfio: Introduce capability definitions for VFIO_DEVICE_GET_INFO
> vfio-pci/zdev: Add zPCI capabilities to VFIO_DEVICE_GET_INFO
> MAINTAINERS: Add entry for s390 vfio-pci
>
> MAINTAINERS | 8 ++
> arch/s390/include/asm/pci.h | 4 +-
> arch/s390/pci/pci_clp.c | 2 +
> drivers/vfio/pci/Kconfig | 13 ++++
> drivers/vfio/pci/Makefile | 1 +
> drivers/vfio/pci/vfio_pci.c | 37 ++++++++++
> drivers/vfio/pci/vfio_pci_private.h | 12 +++
> drivers/vfio/pci/vfio_pci_zdev.c | 143 ++++++++++++++++++++++++++++++++++++
> include/uapi/linux/vfio.h | 11 +++
> include/uapi/linux/vfio_zdev.h | 78 ++++++++++++++++++++
> 10 files changed, 308 insertions(+), 1 deletion(-)
> create mode 100644 drivers/vfio/pci/vfio_pci_zdev.c
> create mode 100644 include/uapi/linux/vfio_zdev.h
>