2022-04-22 19:39:01

by Alexandre TORGUE

[permalink] [raw]
Subject: [PATCH 1/8] dt-bindings: rcc: Add optional external ethernet RX clock properties

From: Marek Vasut <[email protected]>

Describe optional external ethernet RX clock in the DT binding
to fix dtbs_check warnings like:

arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: rcc@50000000: 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Marek Vasut <[email protected]>
Cc: Alexandre Torgue <[email protected]>
Cc: Gabriel Fernandez <[email protected]>
Cc: Rob Herring <[email protected]>
To: [email protected]
Acked-by: Gabriel Fernandez <[email protected]>

diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
index a0ae4867ed27..7a251264582d 100644
--- a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
+++ b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
@@ -59,6 +59,14 @@ properties:
- st,stm32mp1-rcc
- const: syscon

+ clocks:
+ description:
+ Specifies the external RX clock for ethernet MAC.
+ maxItems: 1
+
+ clock-names:
+ const: ETH_RX_CLK/ETH_REF_CLK
+
reg:
maxItems: 1

--
2.17.1


2022-04-22 21:55:23

by Marek Vasut

[permalink] [raw]
Subject: Re: [PATCH 1/8] dt-bindings: rcc: Add optional external ethernet RX clock properties

On 4/22/22 17:09, Alexandre Torgue wrote:
> From: Marek Vasut <[email protected]>
>
> Describe optional external ethernet RX clock in the DT binding
> to fix dtbs_check warnings like:
>
> arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: rcc@50000000: 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Marek Vasut <[email protected]>
> Cc: Alexandre Torgue <[email protected]>
> Cc: Gabriel Fernandez <[email protected]>
> Cc: Rob Herring <[email protected]>
> To: [email protected]
> Acked-by: Gabriel Fernandez <[email protected]>
>
> diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
> index a0ae4867ed27..7a251264582d 100644
> --- a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
> @@ -59,6 +59,14 @@ properties:
> - st,stm32mp1-rcc
> - const: syscon
>
> + clocks:
> + description:
> + Specifies the external RX clock for ethernet MAC.
> + maxItems: 1
> +
> + clock-names:
> + const: ETH_RX_CLK/ETH_REF_CLK
> +
> reg:
> maxItems: 1
>

Should this patch be part of this series, maybe this was re-sent by
accident ?

2022-04-26 03:39:50

by Alexandre TORGUE

[permalink] [raw]
Subject: Re: [PATCH 1/8] dt-bindings: rcc: Add optional external ethernet RX clock properties

Hi Marek

On 4/22/22 18:28, Marek Vasut wrote:
> On 4/22/22 17:09, Alexandre Torgue wrote:
>> From: Marek Vasut <[email protected]>
>>
>> Describe optional external ethernet RX clock in the DT binding
>> to fix dtbs_check warnings like:
>>
>> arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: rcc@50000000:
>> 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks',
>> 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Marek Vasut <[email protected]>
>> Cc: Alexandre Torgue <[email protected]>
>> Cc: Gabriel Fernandez <[email protected]>
>> Cc: Rob Herring <[email protected]>
>> To: [email protected]
>> Acked-by: Gabriel Fernandez <[email protected]>
>>
>> diff --git
>> a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
>> b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
>> index a0ae4867ed27..7a251264582d 100644
>> --- a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
>> @@ -59,6 +59,14 @@ properties:
>>             - st,stm32mp1-rcc
>>         - const: syscon
>> +  clocks:
>> +    description:
>> +      Specifies the external RX clock for ethernet MAC.
>> +    maxItems: 1
>> +
>> +  clock-names:
>> +    const: ETH_RX_CLK/ETH_REF_CLK
>> +
>>     reg:
>>       maxItems: 1
>
> Should this patch be part of this series, maybe this was re-sent by
> accident ?

Not by accident. As your patch is already merged in Rob tree (I guess),
I added it in this series to avoid merge conflict later. I added a late
note in the cover-letter.

regards
alex