2021-02-17 16:31:55

by Jeffrey Hugo

Subject: [PATCH v3] bus: mhi: core: Return EAGAIN if MHI ring is full

From: Fan Wu <[email protected]>

Currently ENOMEM is returned when MHI ring is full. This error code is
very misleading. Change to EAGAIN instead.

Signed-off-by: Fan Wu <[email protected]>
Signed-off-by: Jeffrey Hugo <[email protected]>
---

v3: Fix subject
v2: Change from EBUSY to EAGAIN

drivers/bus/mhi/core/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
index b63f9e6..1eb2fd3 100644
--- a/drivers/bus/mhi/core/main.c
+++ b/drivers/bus/mhi/core/main.c
@@ -1054,7 +1054,7 @@ static int mhi_queue(struct mhi_device *mhi_dev, struct mhi_buf_info *buf_info,

ret = mhi_is_ring_full(mhi_cntrl, tre_ring);
if (unlikely(ret)) {
- ret = -ENOMEM;
+ ret = -EAGAIN;
goto exit_unlock;
}

--
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

2021-02-17 16:46:25

by Hemant Kumar

Subject: Re: [PATCH v3] bus: mhi: core: Return EAGAIN if MHI ring is full

On 2/17/21 8:26 AM, Jeffrey Hugo wrote:
> From: Fan Wu <[email protected]>
>
> Currently ENOMEM is returned when MHI ring is full. This error code is
> very misleading. Change to EAGAIN instead.
>
> Signed-off-by: Fan Wu <[email protected]>
> Signed-off-by: Jeffrey Hugo <[email protected]>
> ---
Reviewed-by: Hemant Kumar <[email protected]>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2021-02-24 09:59:52

by Manivannan Sadhasivam

Subject: Re: [PATCH v3] bus: mhi: core: Return EAGAIN if MHI ring is full

On Wed, Feb 17, 2021 at 09:26:49AM -0700, Jeffrey Hugo wrote:
> From: Fan Wu <[email protected]>
>
> Currently ENOMEM is returned when MHI ring is full. This error code is
> very misleading. Change to EAGAIN instead.
>
> Signed-off-by: Fan Wu <[email protected]>
> Signed-off-by: Jeffrey Hugo <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
>
> v3: Fix subject
> v2: Change from EBUSY to EAGAIN
>
> drivers/bus/mhi/core/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
> index b63f9e6..1eb2fd3 100644
> --- a/drivers/bus/mhi/core/main.c
> +++ b/drivers/bus/mhi/core/main.c
> @@ -1054,7 +1054,7 @@ static int mhi_queue(struct mhi_device *mhi_dev, struct mhi_buf_info *buf_info,
>
> ret = mhi_is_ring_full(mhi_cntrl, tre_ring);
> if (unlikely(ret)) {
> - ret = -ENOMEM;
> + ret = -EAGAIN;
> goto exit_unlock;
> }
>
> --
> Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.
>