2015-08-11 12:50:54

by Geert Uytterhoeven

Subject: [PATCH] PM / domains: Align column headers and data in pm_genpd_summary output

"domain": header is indented by 4, data by 0 spaces => 0 spaces
"/device": header is indented by 11, data by 4 spaces => 4 spaces
"slaves": header is indented by 47, data by 49 spaces => 48 spaces

Ruler:
1234567890123456789012345678901234567890123456789012345678901234567890

Before:

domain status slaves
/device runtime status
----------------------------------------------------------------------
a3sp on a2us
/devices/platform/e60b0000.i2c suspended

After:

domain status slaves
/device runtime status
----------------------------------------------------------------------
a3sp on a2us
/devices/platform/e60b0000.i2c suspended

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/base/power/domain.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index c9bc913a938c31e0..a0a99d55022f5387 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -2082,7 +2082,7 @@ static int pm_genpd_summary_one(struct seq_file *s,

if (WARN_ON(genpd->status >= ARRAY_SIZE(status_lookup)))
goto exit;
- seq_printf(s, "%-30s %-15s ", genpd->name, status_lookup[genpd->status]);
+ seq_printf(s, "%-30s %-15s ", genpd->name, status_lookup[genpd->status]);

/*
* Modifications on the list require holding locks on both
@@ -2117,8 +2117,8 @@ static int pm_genpd_summary_show(struct seq_file *s, void *data)
struct generic_pm_domain *genpd;
int ret = 0;

- seq_puts(s, " domain status slaves\n");
- seq_puts(s, " /device runtime status\n");
+ seq_puts(s, "domain status slaves\n");
+ seq_puts(s, " /device runtime status\n");
seq_puts(s, "----------------------------------------------------------------------\n");

ret = mutex_lock_interruptible(&gpd_list_lock);
--
1.9.1

2015-08-11 15:29:52

by Kevin Hilman

Subject: Re: [PATCH] PM / domains: Align column headers and data in pm_genpd_summary output

Geert Uytterhoeven <[email protected]> writes:

> "domain": header is indented by 4, data by 0 spaces => 0 spaces
> "/device": header is indented by 11, data by 4 spaces => 4 spaces
> "slaves": header is indented by 47, data by 49 spaces => 48 spaces
>
> Ruler:
> 1234567890123456789012345678901234567890123456789012345678901234567890
>
> Before:
>
> domain status slaves
> /device runtime status
> ----------------------------------------------------------------------
> a3sp on a2us
> /devices/platform/e60b0000.i2c suspended
>
> After:
>
> domain status slaves
> /device runtime status
> ----------------------------------------------------------------------
> a3sp on a2us
> /devices/platform/e60b0000.i2c suspended
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Acked-by: Kevin Hilman <[email protected]>

> ---
> drivers/base/power/domain.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index c9bc913a938c31e0..a0a99d55022f5387 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -2082,7 +2082,7 @@ static int pm_genpd_summary_one(struct seq_file *s,
>
> if (WARN_ON(genpd->status >= ARRAY_SIZE(status_lookup)))
> goto exit;
> - seq_printf(s, "%-30s %-15s ", genpd->name, status_lookup[genpd->status]);
> + seq_printf(s, "%-30s %-15s ", genpd->name, status_lookup[genpd->status]);
>
> /*
> * Modifications on the list require holding locks on both
> @@ -2117,8 +2117,8 @@ static int pm_genpd_summary_show(struct seq_file *s, void *data)
> struct generic_pm_domain *genpd;
> int ret = 0;
>
> - seq_puts(s, " domain status slaves\n");
> - seq_puts(s, " /device runtime status\n");
> + seq_puts(s, "domain status slaves\n");
> + seq_puts(s, " /device runtime status\n");
> seq_puts(s, "----------------------------------------------------------------------\n");
>
> ret = mutex_lock_interruptible(&gpd_list_lock);