2020-03-30 02:57:31

by Zhiqiang Liu

Subject: [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info

signal.c provides kill_proc_info, we can use it instead of kill_pid_info
in kill_something_info func gracefully.

Signed-off-by: Zhiqiang Liu <[email protected]>
---
kernel/signal.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index 9ad8dea93dbb..33c70f9f1728 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1552,12 +1552,8 @@ static int kill_something_info(int sig, struct kernel_siginfo *info, pid_t pid)
{
int ret;

- if (pid > 0) {
- rcu_read_lock();
- ret = kill_pid_info(sig, info, find_vpid(pid));
- rcu_read_unlock();
- return ret;
- }
+ if (pid > 0)
+ return kill_proc_info(sig, info, pid);

/* -INT_MIN is undefined. Exclude this case to avoid a UBSAN warning */
if (pid == INT_MIN)
--
2.19.1

2020-03-30 08:47:21

by Oleg Nesterov

Subject: Re: [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info

On 03/30, Zhiqiang Liu wrote:
>
> @@ -1552,12 +1552,8 @@ static int kill_something_info(int sig, struct kernel_siginfo *info, pid_t pid)
> {
> int ret;
>
> - if (pid > 0) {
> - rcu_read_lock();
> - ret = kill_pid_info(sig, info, find_vpid(pid));
> - rcu_read_unlock();
> - return ret;
> - }
> + if (pid > 0)
> + return kill_proc_info(sig, info, pid);
>

Acked-by: Oleg Nesterov <[email protected]>

2020-03-30 08:49:47

by Christian Brauner

Subject: Re: [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info

On Mon, Mar 30, 2020 at 10:44:43AM +0800, Zhiqiang Liu wrote:
>
> signal.c provides kill_proc_info, we can use it instead of kill_pid_info
> in kill_something_info func gracefully.
>
> Signed-off-by: Zhiqiang Liu <[email protected]>

Thanks! I'll shorten the commit message header a little when picking
this up otherwise:

Acked-by: Christian Brauner <[email protected]>

2020-04-09 03:28:11

by Zhiqiang Liu

Subject: Re: [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info

Friendly ping...

On 2020/3/30 16:48, Christian Brauner wrote:
> On Mon, Mar 30, 2020 at 10:44:43AM +0800, Zhiqiang Liu wrote:
>>
>> signal.c provides kill_proc_info, we can use it instead of kill_pid_info
>> in kill_something_info func gracefully.
>>
>> Signed-off-by: Zhiqiang Liu <[email protected]>
>
> Thanks! I'll shorten the commit message header a little when picking
> this up otherwise:
>
> Acked-by: Christian Brauner <[email protected]>
>
> .
>

2020-04-09 06:55:10

by Christian Brauner

Subject: Re: [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info

On April 9, 2020 5:26:30 AM GMT+02:00, Zhiqiang Liu <[email protected]> wrote:
>Friendly ping...
>
>On 2020/3/30 16:48, Christian Brauner wrote:
>> On Mon, Mar 30, 2020 at 10:44:43AM +0800, Zhiqiang Liu wrote:
>>>
>>> signal.c provides kill_proc_info, we can use it instead of
>kill_pid_info
>>> in kill_something_info func gracefully.
>>>
>>> Signed-off-by: Zhiqiang Liu <[email protected]>
>>
>> Thanks! I'll shorten the commit message header a little when picking
>> this up otherwise:
>>
>> Acked-by: Christian Brauner <[email protected]>
>>
>> .
>>

The patches are queued for after rc1. So around next week.
They came too late to make it into the merge window.

Christian

2020-04-13 05:42:27

by Christian Brauner

Subject: Re: [PATCH] signal: use kill_proc_info instead of kill_pid_info in kill_something_info

On Mon, Mar 30, 2020 at 10:44:43AM +0800, Zhiqiang Liu wrote:
>
> signal.c provides kill_proc_info, we can use it instead of kill_pid_info
> in kill_something_info func gracefully.
>
> Signed-off-by: Zhiqiang Liu <[email protected]>
> Acked-by: Oleg Nesterov <[email protected]>
> Acked-by: Christian Brauner <[email protected]>

Applied, thanks!
Christian