2023-09-15 20:18:26

by Ilpo Järvinen

Subject: [PATCH v2 2/6] selftests/resctrl: Remove duplicate feature check from CMT test

The test runner run_cmt_test() in resctrl_tests.c checks for CMT
feature and does not run cmt_resctrl_val() if CMT is not supported.
Then cmt_resctrl_val() also check is CMT is supported.

Remove the duplicated feature check for CMT from cmt_resctrl_val().

Signed-off-by: Ilpo Järvinen <[email protected]>
Cc: <[email protected]>
---
tools/testing/selftests/resctrl/cmt_test.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/tools/testing/selftests/resctrl/cmt_test.c b/tools/testing/selftests/resctrl/cmt_test.c
index cf2f5e92dea6..50bdbce9fba9 100644
--- a/tools/testing/selftests/resctrl/cmt_test.c
+++ b/tools/testing/selftests/resctrl/cmt_test.c
@@ -80,9 +80,6 @@ int cmt_resctrl_val(int cpu_no, int n, const char * const *benchmark_cmd)
size_t span;
int ret, i;

- if (!validate_resctrl_feature_request(CMT_STR))
- return -1;
-
ret = get_cbm_mask("L3", cbm_mask);
if (ret)
return ret;
--
2.30.2

2023-09-27 00:57:45

by Reinette Chatre

Subject: Re: [PATCH v2 2/6] selftests/resctrl: Remove duplicate feature check from CMT test

Hi Ilpo,

On 9/15/2023 8:44 AM, Ilpo Järvinen wrote:
> The test runner run_cmt_test() in resctrl_tests.c checks for CMT
> feature and does not run cmt_resctrl_val() if CMT is not supported.
> Then cmt_resctrl_val() also check is CMT is supported.
>
> Remove the duplicated feature check for CMT from cmt_resctrl_val().
>
> Signed-off-by: Ilpo Järvinen <[email protected]>
> Cc: <[email protected]>

Thank you.

Reviewed-by: Reinette Chatre <[email protected]>

Reinette