2022-11-12 17:24:56

by Noralf Trønnes

[permalink] [raw]
Subject: Re: [PATCH v8 15/24] drm/client: Remove match on mode name



Den 10.11.2022 12.07, skrev Maxime Ripard:
> Commit 3aeeb13d8996 ("drm/modes: Support modes names on the command
> line") initially introduced the named modes support by essentially
> matching the name passed on the command-line to the mode names defined
> by the drivers.
>
> This proved to be difficult to work with, since all drivers had to
> provide properly named modes. This was also needed because we weren't
> passing a full blown-mode to the drivers, but were only filling its
> name.
>
> Thanks to the previous patches, we now generate a proper mode, and we
> thus can use the usual matching algo on timings, and can simply drop the
> name match.
>
> Suggested-by: Noralf Trønnes <[email protected]>
> Signed-off-by: Maxime Ripard <[email protected]>
>
> ---

Reviewed-by: Noralf Trønnes <[email protected]>