2021-03-05 08:54:20

by Gustavo A. R. Silva

Subject: [PATCH RESEND][next] ice: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
index 02b12736ea80..207f6ee3a7f6 100644
--- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
@@ -143,6 +143,7 @@ ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb,
case ICE_RX_PTYPE_INNER_PROT_UDP:
case ICE_RX_PTYPE_INNER_PROT_SCTP:
skb->ip_summed = CHECKSUM_UNNECESSARY;
+ break;
default:
break;
}
--
2.27.0

2021-03-05 09:08:39

by Paul Menzel

Subject: Re: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through warnings for Clang

Dear Gustavo,


Thank you for working on that.

Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of just letting the code
> fall through to the next case.

It would be nice to have a short summary of the discrepancy between GCC
and clang, and it was decided to go with the “clang decision”, and not
have clang adapt to GCC.

> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> index 02b12736ea80..207f6ee3a7f6 100644
> --- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> @@ -143,6 +143,7 @@ ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb,
> case ICE_RX_PTYPE_INNER_PROT_UDP:
> case ICE_RX_PTYPE_INNER_PROT_SCTP:
> skb->ip_summed = CHECKSUM_UNNECESSARY;
> + break;
> default:
> break;
> }


Kind regards,

Paul

2021-03-10 00:03:03

by Brelinski, TonyX

Subject: RE: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through warnings for Clang

> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Paul Menzel
> Sent: Friday, March 5, 2021 1:04 AM
> To: Gustavo A. R. Silva <[email protected]>; Brandeburg, Jesse
> <[email protected]>; Nguyen, Anthony L
> <[email protected]>; David S. Miller <[email protected]>;
> Jakub Kicinski <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected]
> Subject: Re: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through
> warnings for Clang
>
> Dear Gustavo,
>
>
> Thank you for working on that.
>
> Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> > warning by explicitly adding a break statement instead of just letting
> > the code fall through to the next case.
>
> It would be nice to have a short summary of the discrepancy between GCC
> and clang, and it was decided to go with the “clang decision”, and not have
> clang adapt to GCC.
>
> > Link: https://github.com/KSPP/linux/issues/115
> > Signed-off-by: Gustavo A. R. Silva <[email protected]>
> > ---
> > drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
> > 1 file changed, 1 insertion(+)

Tested-by: Tony Brelinski <[email protected]> A Contingent Worker at Intel