2017-06-15 17:54:27

by Eric Anholt

Subject: [PATCH] bridge: Fix panel-bridge error return on !panel.

ERR_PTR() needs a negative errno argument.

Signed-off-by: Eric Anholt <[email protected]>
---
drivers/gpu/drm/bridge/panel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 99f9a4beb859..67fe19e5a9c6 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -161,7 +161,7 @@ struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel,
int ret;

if (!panel)
- return ERR_PTR(EINVAL);
+ return ERR_PTR(-EINVAL);

panel_bridge = devm_kzalloc(panel->dev, sizeof(*panel_bridge),
GFP_KERNEL);
--
2.11.0

2017-06-16 06:02:52

by Archit Taneja

Subject: Re: [PATCH] bridge: Fix panel-bridge error return on !panel.

On 06/15/2017 11:24 PM, Eric Anholt wrote:
> ERR_PTR() needs a negative errno argument.

Thanks, I'll queue it to drm-misc-next-fixes once it's opened.

Archit

>
> Signed-off-by: Eric Anholt <[email protected]>
> ---
> drivers/gpu/drm/bridge/panel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 99f9a4beb859..67fe19e5a9c6 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -161,7 +161,7 @@ struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel,
> int ret;
>
> if (!panel)
> - return ERR_PTR(EINVAL);
> + return ERR_PTR(-EINVAL);
>
> panel_bridge = devm_kzalloc(panel->dev, sizeof(*panel_bridge),
> GFP_KERNEL);
>

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project