2021-09-27 09:39:21

by Arnd Bergmann

[permalink] [raw]

Subject: [PATCH] gpu: host1x: select CONFIG_DMA_SHARED_BUFFER

---

From: Arnd Bergmann <[email protected]>

Linking fails when dma-buf is disabled:

ld.lld: error: undefined symbol: dma_fence_release
>>> referenced by fence.c
>>> gpu/host1x/fence.o:(host1x_syncpt_fence_enable_signaling) in archive drivers/built-in.a
>>> referenced by fence.c
>>> gpu/host1x/fence.o:(host1x_fence_signal) in archive drivers/built-in.a
>>> referenced by fence.c
>>> gpu/host1x/fence.o:(do_fence_timeout) in archive drivers/built-in.a

Fixes: 687db2207b1b ("gpu: host1x: Add DMA fence implementation")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/gpu/host1x/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
index 6dab94adf25e..6815b4db17c1 100644
--- a/drivers/gpu/host1x/Kconfig
+++ b/drivers/gpu/host1x/Kconfig
@@ -2,6 +2,7 @@
config TEGRA_HOST1X
tristate "NVIDIA Tegra host1x driver"
depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
+ select DMA_SHARED_BUFFER
select IOMMU_IOVA
help
Driver for the NVIDIA Tegra host1x hardware.
--
2.29.2

2021-09-27 11:06:30

by Mikko Perttunen

[permalink] [raw]

Subject: Re: [PATCH] gpu: host1x: select CONFIG_DMA_SHARED_BUFFER

---

On 9/27/21 12:36 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> Linking fails when dma-buf is disabled:
>
> ld.lld: error: undefined symbol: dma_fence_release
>>>> referenced by fence.c
>>>> gpu/host1x/fence.o:(host1x_syncpt_fence_enable_signaling) in archive drivers/built-in.a
>>>> referenced by fence.c
>>>> gpu/host1x/fence.o:(host1x_fence_signal) in archive drivers/built-in.a
>>>> referenced by fence.c
>>>> gpu/host1x/fence.o:(do_fence_timeout) in archive drivers/built-in.a
>
> Fixes: 687db2207b1b ("gpu: host1x: Add DMA fence implementation")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/gpu/host1x/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
> index 6dab94adf25e..6815b4db17c1 100644
> --- a/drivers/gpu/host1x/Kconfig
> +++ b/drivers/gpu/host1x/Kconfig
> @@ -2,6 +2,7 @@
> config TEGRA_HOST1X
> tristate "NVIDIA Tegra host1x driver"
> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> + select DMA_SHARED_BUFFER
> select IOMMU_IOVA
> help
> Driver for the NVIDIA Tegra host1x hardware.
>

Thanks!

Reviewed-by: Mikko Perttunen <[email protected]>

2021-10-07 18:05:36

by Thierry Reding

[permalink] [raw]

Subject: Re: [PATCH] gpu: host1x: select CONFIG_DMA_SHARED_BUFFER

---

On Mon, Sep 27, 2021 at 11:36:59AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> Linking fails when dma-buf is disabled:
>
> ld.lld: error: undefined symbol: dma_fence_release
> >>> referenced by fence.c
> >>> gpu/host1x/fence.o:(host1x_syncpt_fence_enable_signaling) in archive drivers/built-in.a
> >>> referenced by fence.c
> >>> gpu/host1x/fence.o:(host1x_fence_signal) in archive drivers/built-in.a
> >>> referenced by fence.c
> >>> gpu/host1x/fence.o:(do_fence_timeout) in archive drivers/built-in.a
>
> Fixes: 687db2207b1b ("gpu: host1x: Add DMA fence implementation")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/gpu/host1x/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.

Thierry

---

Attachments:

(No filename) (816.00 B)
signature.asc (849.00 B)
Download all attachments