2021-04-19 13:10:01

by Colin King

Subject: [PATCH][next] bcache: Set error return err to -ENOMEM on allocation failure

From: Colin Ian King <[email protected]>

Currently when ns fails to be allocated the error return path returns
an uninitialized return code in variable 'err'. Fix this by setting
err to -ENOMEM.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 688330711e9a ("bcache: initialize the nvm pages allocator")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/md/bcache/nvm-pages.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/md/bcache/nvm-pages.c b/drivers/md/bcache/nvm-pages.c
index 08cd45e90481..2e124d546099 100644
--- a/drivers/md/bcache/nvm-pages.c
+++ b/drivers/md/bcache/nvm-pages.c
@@ -584,6 +584,7 @@ struct bch_nvm_namespace *bch_register_namespace(const char *dev_path)
return ERR_PTR(PTR_ERR(bdev));
}

+ err = -ENOMEM;
ns = kzalloc(sizeof(struct bch_nvm_namespace), GFP_KERNEL);
if (!ns)
goto bdput;
--
2.30.2

2021-04-19 19:54:46

by Coly Li

Subject: Re: [PATCH][next] bcache: Set error return err to -ENOMEM on allocation failure

On 4/19/21 8:56 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Currently when ns fails to be allocated the error return path returns
> an uninitialized return code in variable 'err'. Fix this by setting
> err to -ENOMEM.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: 688330711e9a ("bcache: initialize the nvm pages allocator")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/md/bcache/nvm-pages.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/md/bcache/nvm-pages.c b/drivers/md/bcache/nvm-pages.c
> index 08cd45e90481..2e124d546099 100644
> --- a/drivers/md/bcache/nvm-pages.c
> +++ b/drivers/md/bcache/nvm-pages.c
> @@ -584,6 +584,7 @@ struct bch_nvm_namespace *bch_register_namespace(const char *dev_path)
> return ERR_PTR(PTR_ERR(bdev));
> }
>
> + err = -ENOMEM;
> ns = kzalloc(sizeof(struct bch_nvm_namespace), GFP_KERNEL);
> if (!ns)
> goto bdput;
>

Copied, added into my queue for rc1.

Thanks.

Coly Li