2006-10-14 07:19:37

by Lu, Yinghai

[permalink] [raw]
Subject: [PATCH] remove duplicated cpu_mask_to_apicid in x86_64 smp.h

inline function cpu_mask_to_apicid in smp.h is duplicated with macro
in mach_apic.h.

Signed-off-by: Yinghai Lu <[email protected]>


diff --git a/include/asm-x86_64/smp.h b/include/asm-x86_64/smp.h
index d6b7c05..7ae7e7d 100644
--- a/include/asm-x86_64/smp.h
+++ b/include/asm-x86_64/smp.h
@@ -82,11 +82,6 @@ extern u8 x86_cpu_to_apicid[NR_CPUS]; /*
extern u8 x86_cpu_to_log_apicid[NR_CPUS];
extern u8 bios_cpu_apicid[];

-static inline unsigned int cpu_mask_to_apicid(cpumask_t cpumask)
-{
- return cpus_addr(cpumask)[0];
-}
-
static inline int cpu_present_to_apicid(int mps_cpu)
{
if (mps_cpu < NR_CPUS)

Attachments:
(No filename) (633.00 B)
 x86_64_smp_h.diff (480.00 B)
 Download all attachments

2006-10-16 10:36:29

by Andi Kleen

[permalink] [raw]
Subject: Re: [PATCH] remove duplicated cpu_mask_to_apicid in x86_64 smp.h

On Saturday 14 October 2006 09:19, Yinghai Lu wrote:
> inline function cpu_mask_to_apicid in smp.h is duplicated with macro
> in mach_apic.h.
Added thanks

-Andi