Add <linux/irqchips/xtensa-mx.h> to provide the function prototype to
prevent a build warning:
drivers/irqchip/irq-xtensa-mx.c:166:12: warning: no previous prototype for 'xtensa_mx_init_legacy' [-Wmissing-prototypes]
166 | int __init xtensa_mx_init_legacy(struct device_node *interrupt_parent)
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Chris Zankel <[email protected]>
Cc: Max Filippov <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Marc Zyngier <[email protected]>
---
drivers/irqchip/irq-xtensa-mx.c | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/irqchip/irq-xtensa-mx.c b/drivers/irqchip/irq-xtensa-mx.c
--- a/drivers/irqchip/irq-xtensa-mx.c
+++ b/drivers/irqchip/irq-xtensa-mx.c
@@ -12,6 +12,7 @@
#include <linux/irqdomain.h>
#include <linux/irq.h>
#include <linux/irqchip.h>
+#include <linux/irqchip/xtensa-mx.h>
#include <linux/of.h>
#include <asm/mxregs.h>
On Wed, 20 Sep 2023 06:21:32 +0100,
Randy Dunlap <[email protected]> wrote:
>
> Add <linux/irqchips/xtensa-mx.h> to provide the function prototype to
> prevent a build warning:
>
> drivers/irqchip/irq-xtensa-mx.c:166:12: warning: no previous prototype for 'xtensa_mx_init_legacy' [-Wmissing-prototypes]
> 166 | int __init xtensa_mx_init_legacy(struct device_node *interrupt_parent)
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Chris Zankel <[email protected]>
> Cc: Max Filippov <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Marc Zyngier <[email protected]>
> ---
> drivers/irqchip/irq-xtensa-mx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/irqchip/irq-xtensa-mx.c b/drivers/irqchip/irq-xtensa-mx.c
> --- a/drivers/irqchip/irq-xtensa-mx.c
> +++ b/drivers/irqchip/irq-xtensa-mx.c
> @@ -12,6 +12,7 @@
> #include <linux/irqdomain.h>
> #include <linux/irq.h>
> #include <linux/irqchip.h>
> +#include <linux/irqchip/xtensa-mx.h>
> #include <linux/of.h>
>
> #include <asm/mxregs.h>
>
Acked-by: Marc Zyngier <[email protected]>
It also begs the question of the continuing support for non-DT driven
systems.
Max, Chris: are we any closer to being DT-only on the xtensa front?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
On Wed, Sep 20, 2023 at 2:51 AM Marc Zyngier <[email protected]> wrote:
> It also begs the question of the continuing support for non-DT driven
> systems.
>
> Max, Chris: are we any closer to being DT-only on the xtensa front?
I have never seen it as a goal. Let's see: iss doesn't have devices at all,
virt based on it is DT-only, xtfpga with DT loses USB host support, but
it hasn't really been all that useful. xt2000 is the only xtensa platform that
does not support device trees now. I can convert the code, but I don't have
the hardware to test it. I also know that it hasn't been in use in Cadence.
Maybe Chris has it? If not then I guess we can drop it.
--
Thanks.
-- Max