2021-07-26 14:38:04

by Christoph Hellwig

Subject: [PATCH 1/2] vfio/mdev: turn mdev_init into a subsys_initcall

Without this setups with buіlt-in mdev and mdev-drivers fail to
register like this:

[1.903149] Driver 'intel_vgpu_mdev' was unable to register with bus_type 'mdev' because the bus was not initialized.

Signed-off-by: Christoph Hellwig <[email protected]>
---
drivers/vfio/mdev/mdev_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c
index e4581ec093a6..b16606ebafa1 100644
--- a/drivers/vfio/mdev/mdev_core.c
+++ b/drivers/vfio/mdev/mdev_core.c
@@ -398,7 +398,7 @@ static void __exit mdev_exit(void)
mdev_bus_unregister();
}

-module_init(mdev_init)
+subsys_initcall(mdev_init)
module_exit(mdev_exit)

MODULE_VERSION(DRIVER_VERSION);
--
2.30.2

2021-07-26 17:13:51

by Cornelia Huck

Subject: Re: [PATCH 1/2] vfio/mdev: turn mdev_init into a subsys_initcall

On Mon, Jul 26 2021, Christoph Hellwig <[email protected]> wrote:

> Without this setups with buіlt-in mdev and mdev-drivers fail to
> register like this:
>
> [1.903149] Driver 'intel_vgpu_mdev' was unable to register with bus_type 'mdev' because the bus was not initialized.
>
> Signed-off-by: Christoph Hellwig <[email protected]>
> ---
> drivers/vfio/mdev/mdev_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Cornelia Huck <[email protected]>

2021-07-26 23:08:29

by Jason Gunthorpe

Subject: Re: [PATCH 1/2] vfio/mdev: turn mdev_init into a subsys_initcall

On Mon, Jul 26, 2021 at 04:35:23PM +0200, Christoph Hellwig wrote:
> Without this setups with buіlt-in mdev and mdev-drivers fail to
> register like this:
>
> [1.903149] Driver 'intel_vgpu_mdev' was unable to register with bus_type 'mdev' because the bus was not initialized.
>
> Signed-off-by: Christoph Hellwig <[email protected]>
> ---
> drivers/vfio/mdev/mdev_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Jason Gunthorpe <[email protected]>

Jason