2018-04-25 07:13:04

by Vaishali Thakkar

[permalink] [raw]
Subject: [PATCH] drm/vc4: make function vc4_allocate_bin_bo static

Sparse complains with following warning:
drivers/gpu/drm/vc4/vc4_v3d.c:222:1: warning: symbol
'vc4_allocate_bin_bo' was not declared. Should it be static?

Make vc4_allocate_bin static as it is not used outside of
vc4_v3d.c.

Signed-off-by: Vaishali Thakkar <[email protected]>
---
drivers/gpu/drm/vc4/vc4_v3d.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c
index bfc2fa73d2ae..e47e29426078 100644
--- a/drivers/gpu/drm/vc4/vc4_v3d.c
+++ b/drivers/gpu/drm/vc4/vc4_v3d.c
@@ -218,8 +218,7 @@ int vc4_v3d_get_bin_slot(struct vc4_dev *vc4)
* overall CMA pool before they make scenes complicated enough to run
* out of bin space.
*/
-int
-vc4_allocate_bin_bo(struct drm_device *drm)
+static int vc4_allocate_bin_bo(struct drm_device *drm)
{
struct vc4_dev *vc4 = to_vc4_dev(drm);
struct vc4_v3d *v3d = vc4->v3d;
--
2.14.1



2018-04-30 21:05:01

by Eric Anholt

[permalink] [raw]
Subject: Re: [PATCH] drm/vc4: make function vc4_allocate_bin_bo static

Vaishali Thakkar <[email protected]> writes:

> Sparse complains with following warning:
> drivers/gpu/drm/vc4/vc4_v3d.c:222:1: warning: symbol
> 'vc4_allocate_bin_bo' was not declared. Should it be static?
>
> Make vc4_allocate_bin static as it is not used outside of
> vc4_v3d.c.
>
> Signed-off-by: Vaishali Thakkar <[email protected]>

Applied to drm-misc-next. Thanks!


Attachments:
signature.asc (847.00 B)