2021-04-25 20:17:00

by Ferry Toth

[permalink] [raw]
Subject: [PATCH v2 1/1] usb: dwc3: pci: Enable usb2-gadget-lpm-disable for Intel Merrifield

On Intel Merrifield LPM is causing the host to reset port after a timeout.
By disabling LPM entirely this is prevented.

Fixes: 066c09593454 ("usb: dwc3: pci: Enable extcon driver for Intel Merrifield")
Signed-off-by: Ferry Toth <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
---
drivers/usb/dwc3/dwc3-pci.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 4c5c6972124a..e5d7eed2e60c 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -122,6 +122,7 @@ static const struct property_entry dwc3_pci_mrfld_properties[] = {
PROPERTY_ENTRY_STRING("linux,extcon-name", "mrfld_bcove_pwrsrc"),
PROPERTY_ENTRY_BOOL("snps,dis_u3_susphy_quirk"),
PROPERTY_ENTRY_BOOL("snps,dis_u2_susphy_quirk"),
+ PROPERTY_ENTRY_BOOL("snps,usb2-gadget-lpm-disable"),
PROPERTY_ENTRY_BOOL("linux,sysdev_is_parent"),
{}
};
--
2.27.0


2021-04-26 10:41:41

by Felipe Balbi

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] usb: dwc3: pci: Enable usb2-gadget-lpm-disable for Intel Merrifield

Ferry Toth <[email protected]> writes:

> On Intel Merrifield LPM is causing the host to reset port after a timeout.
> By disabling LPM entirely this is prevented.
>
> Fixes: 066c09593454 ("usb: dwc3: pci: Enable extcon driver for Intel Merrifield")
> Signed-off-by: Ferry Toth <[email protected]>
> Reviewed-by: Andy Shevchenko <[email protected]>

Acked-by: Felipe Balbi <[email protected]>

--
balbi


Attachments:
signature.asc (873.00 B)

2021-05-10 13:03:33

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] usb: dwc3: pci: Enable usb2-gadget-lpm-disable for Intel Merrifield

On Sun, Apr 25, 2021 at 09:54:52PM +0200, Ferry Toth wrote:
> On Intel Merrifield LPM is causing the host to reset port after a timeout.
> By disabling LPM entirely this is prevented.
>
> Fixes: 066c09593454 ("usb: dwc3: pci: Enable extcon driver for Intel Merrifield")
> Signed-off-by: Ferry Toth <[email protected]>
> Reviewed-by: Andy Shevchenko <[email protected]>
> ---
> drivers/usb/dwc3/dwc3-pci.c | 1 +
> 1 file changed, 1 insertion(+)

What changed from v1? Always put that below the --- line.

2021-05-10 16:18:47

by Ferry Toth

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] usb: dwc3: pci: Enable usb2-gadget-lpm-disable for Intel Merrifield

Hi,


Op 10-05-2021 om 14:40 schreef Greg Kroah-Hartman:
> On Sun, Apr 25, 2021 at 09:54:52PM +0200, Ferry Toth wrote:
>> On Intel Merrifield LPM is causing the host to reset port after a timeout.
>> By disabling LPM entirely this is prevented.
>>
>> Fixes: 066c09593454 ("usb: dwc3: pci: Enable extcon driver for Intel Merrifield")
>> Signed-off-by: Ferry Toth <[email protected]>
>> Reviewed-by: Andy Shevchenko <[email protected]>
>> ---
>> drivers/usb/dwc3/dwc3-pci.c | 1 +
>> 1 file changed, 1 insertion(+)
> What changed from v1? Always put that below the --- line.
>
Yes, my bad, sorry.

In the above text "is causing host" was change to "is causing the host".

Thanks for adding into your usb-linus branch anyway.