2023-09-14 16:27:19

by Robert Marko

Subject: [PATCH 1/2] arm64: dts: marvell: uDPU: rename the SFP GPIO properties

Rename the GPIO related SFP properties to include the preffered -gpios
suffix as defined in the SFP schema.

This fixes the following warning:
arch/arm64/boot/dts/marvell/armada-3720-eDPU.dtb: sfp-eth1: 'los-gpio', 'mod-def0-gpio', 'tx-disable-gpio', 'tx-fault-gpio' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/net/sff,sfp.yaml#

Signed-off-by: Robert Marko <[email protected]>
---
arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi
index 3f79923376fb..3a9b6907185d 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi
@@ -61,10 +61,10 @@ led-alarm2 {
sfp_eth1: sfp-eth1 {
compatible = "sff,sfp";
i2c-bus = <&i2c1>;
- los-gpio = <&gpiosb 7 GPIO_ACTIVE_HIGH>;
- mod-def0-gpio = <&gpiosb 8 GPIO_ACTIVE_LOW>;
- tx-disable-gpio = <&gpiosb 9 GPIO_ACTIVE_HIGH>;
- tx-fault-gpio = <&gpiosb 10 GPIO_ACTIVE_HIGH>;
+ los-gpios = <&gpiosb 7 GPIO_ACTIVE_HIGH>;
+ mod-def0-gpios = <&gpiosb 8 GPIO_ACTIVE_LOW>;
+ tx-disable-gpios = <&gpiosb 9 GPIO_ACTIVE_HIGH>;
+ tx-fault-gpios = <&gpiosb 10 GPIO_ACTIVE_HIGH>;
maximum-power-milliwatt = <3000>;
};
};
--
2.41.0

2023-09-14 19:50:56

by Andrew Lunn

Subject: Re: [PATCH 1/2] arm64: dts: marvell: uDPU: rename the SFP GPIO properties

On Thu, Sep 14, 2023 at 11:45:00AM +0200, Robert Marko wrote:
> Rename the GPIO related SFP properties to include the preffered -gpios
> suffix as defined in the SFP schema.
>
> This fixes the following warning:
> arch/arm64/boot/dts/marvell/armada-3720-eDPU.dtb: sfp-eth1: 'los-gpio', 'mod-def0-gpio', 'tx-disable-gpio', 'tx-fault-gpio' do not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/net/sff,sfp.yaml#
>
> Signed-off-by: Robert Marko <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2023-09-20 13:57:48

by Gregory CLEMENT

Subject: Re: [PATCH 1/2] arm64: dts: marvell: uDPU: rename the SFP GPIO properties

Robert Marko <[email protected]> writes:

> Rename the GPIO related SFP properties to include the preffered -gpios
> suffix as defined in the SFP schema.
>
> This fixes the following warning:
> arch/arm64/boot/dts/marvell/armada-3720-eDPU.dtb: sfp-eth1: 'los-gpio', 'mod-def0-gpio', 'tx-disable-gpio', 'tx-fault-gpio' do not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/net/sff,sfp.yaml#
>

Applied on mvebu/dt64

Thanks,

Gregory
> Signed-off-by: Robert Marko <[email protected]>
> ---
> arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi
> index 3f79923376fb..3a9b6907185d 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi
> @@ -61,10 +61,10 @@ led-alarm2 {
> sfp_eth1: sfp-eth1 {
> compatible = "sff,sfp";
> i2c-bus = <&i2c1>;
> - los-gpio = <&gpiosb 7 GPIO_ACTIVE_HIGH>;
> - mod-def0-gpio = <&gpiosb 8 GPIO_ACTIVE_LOW>;
> - tx-disable-gpio = <&gpiosb 9 GPIO_ACTIVE_HIGH>;
> - tx-fault-gpio = <&gpiosb 10 GPIO_ACTIVE_HIGH>;
> + los-gpios = <&gpiosb 7 GPIO_ACTIVE_HIGH>;
> + mod-def0-gpios = <&gpiosb 8 GPIO_ACTIVE_LOW>;
> + tx-disable-gpios = <&gpiosb 9 GPIO_ACTIVE_HIGH>;
> + tx-fault-gpios = <&gpiosb 10 GPIO_ACTIVE_HIGH>;
> maximum-power-milliwatt = <3000>;
> };
> };
> --
> 2.41.0
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com