LinuxLists.cc - [PATCH] Fix USB vendor and product IDs endianness for USB HID devices

2007-02-10 21:08:48

Subject: [PATCH] Fix USB vendor and product IDs endianness for USB HID devices

Attachments:

(No filename) (562.00 B)
usbhid_vid_pid_endianness_fix.patch (498.00 B)
[PATCH] Fix USB vendor and product IDs endianness for USB HID devices (No filename) (255.00 B)
Download all attachments

2007-02-11 17:24:32

by Jiri Kosina

[permalink] [raw]

Subject: Re: [PATCH] Fix USB vendor and product IDs endianness for USB HID devices

On Sat, 10 Feb 2007, Julien BLACHE wrote:

> The generic HID layer changes introduced an endianness bug for USB HID
> devices.

Hi Julien,

this is obviously a bug, thanks for a fix, I queued it for upstream.

Two nitpicks:

- could you please submitpatches in standard conventions, so that they
could be applied directly using patch -p1 against toplevel of the kernel
tree (your patch was just against hid-core.c, but without any path)
- please inline patches in message and do not attach them, if possible

I will submit the patch to stable team.

Thanks,

--
Jiri Kosina
SUSE Labs

2007-02-11 18:04:19

by Julien BLACHE

[permalink] [raw]

Subject: Re: [PATCH] Fix USB vendor and product IDs endianness for USB HID devices

Jiri Kosina <[email protected]> wrote:

Hi,

> this is obviously a bug, thanks for a fix, I queued it for upstream.

Thanks.

> Two nitpicks:
>
> - could you please submitpatches in standard conventions, so that they
> could be applied directly using patch -p1 against toplevel of the kernel
> tree (your patch was just against hid-core.c, but without any path)

Gah, I did that again. Sorry.

> - please inline patches in message and do not attach them, if possible

Same here, got fooled again into doing an inline MIME part instead of
inlining the patch for real.

JB.

--
Julien BLACHE <http://www.jblache.org>
<[email protected]> GPG KeyID 0xF5D65169