2017-09-19 12:27:00

by Jean Delvare

Subject: [PATCH] params: Align add_sysfs_param documentation with code

This parameter is named kp, so the documentation should use that.

Signed-off-by: Jean Delvare <[email protected]>
Fixes: 9b473de87209 ("param: Fix duplicate module prefixes")
Cc: Rusty Russell <[email protected]>
---
kernel/params.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-4.14-rc1.orig/kernel/params.c 2017-09-17 00:47:51.000000000 +0200
+++ linux-4.14-rc1/kernel/params.c 2017-09-19 14:19:51.399247222 +0200
@@ -600,7 +600,7 @@ EXPORT_SYMBOL(kernel_param_unlock);
/*
* add_sysfs_param - add a parameter to sysfs
* @mk: struct module_kobject
- * @kparam: the actual parameter definition to add to sysfs
+ * @kp: the actual parameter definition to add to sysfs
* @name: name of parameter
*
* Create a kobject if for a (per-module) parameter if mp NULL, and

--
Jean Delvare
SUSE L3 Support

2017-09-23 04:33:52

by Rusty Russell

Subject: Re: [PATCH] params: Align add_sysfs_param documentation with code

Jean Delvare <[email protected]> writes:

> This parameter is named kp, so the documentation should use that.
>
> Signed-off-by: Jean Delvare <[email protected]>
> Fixes: 9b473de87209 ("param: Fix duplicate module prefixes")
> Cc: Rusty Russell <[email protected]>

Acked-by: Rusty Russell <[email protected]>

Thanks,
Rusty.

> ---
> kernel/params.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-4.14-rc1.orig/kernel/params.c 2017-09-17 00:47:51.000000000 +0200
> +++ linux-4.14-rc1/kernel/params.c 2017-09-19 14:19:51.399247222 +0200
> @@ -600,7 +600,7 @@ EXPORT_SYMBOL(kernel_param_unlock);
> /*
> * add_sysfs_param - add a parameter to sysfs
> * @mk: struct module_kobject
> - * @kparam: the actual parameter definition to add to sysfs
> + * @kp: the actual parameter definition to add to sysfs
> * @name: name of parameter
> *
> * Create a kobject if for a (per-module) parameter if mp NULL, and
>
> --
> Jean Delvare
> SUSE L3 Support