Greg KH <[email protected]> writes:
> On Fri, Jul 20, 2012 at 04:02:44PM +0000, KY Srinivasan wrote:
>> > On Fri, Jul 20, 2012 at 10:03:08AM +0200, Bjørn Mork wrote:
>> >
>> > > +/* Linux vendor ID allocated by Microsoft */
>> > > +#define HV_LINUX_GUEST_ID_VENDOR 0xB16B
>> > > +
>> > > +/* Creating a guest ID conforming to the encoding recommended by
>> > > + * Microsoft, with variant and build fixed to 0
>> >
>> > We could use the kernel build number here as well, if we really wanted
>> > it, right?
Yes, we could. I just didn't see any value it that. Why would you want
your hypervisor to care about some arbitrary build number?
But it can of course be added if anyone needs it.
>> > Otherwise, I like this patch, KY, any objection to me taking it?
>>
>> Greg,
>>
>> If it is ok with you can we wait a couple of days. I am pushing to get information
>> back from folks within MSFT. I am hoping we can fix this issue soon.
>
> Ok, I'll hold on to it for a week or so.
Not to nag or anything like that, but ... It's been a week or so now,
hasn't it? :-)
Bjørn
> -----Original Message-----
> From: Bjørn Mork [mailto:[email protected]]
> Sent: Monday, August 13, 2012 9:00 AM
> To: Greg KH
> Cc: KY Srinivasan; Paolo Bonzini; [email protected]; linux-
> [email protected]
> Subject: Re: [PATCH] drivers: hv: use Linux version in guest ID
>
> Greg KH <[email protected]> writes:
> > On Fri, Jul 20, 2012 at 04:02:44PM +0000, KY Srinivasan wrote:
> >> > On Fri, Jul 20, 2012 at 10:03:08AM +0200, Bjørn Mork wrote:
> >> >
> >> > > +/* Linux vendor ID allocated by Microsoft */
> >> > > +#define HV_LINUX_GUEST_ID_VENDOR 0xB16B
> >> > > +
> >> > > +/* Creating a guest ID conforming to the encoding recommended by
> >> > > + * Microsoft, with variant and build fixed to 0
> >> >
> >> > We could use the kernel build number here as well, if we really wanted
> >> > it, right?
>
> Yes, we could. I just didn't see any value it that. Why would you want
> your hypervisor to care about some arbitrary build number?
>
> But it can of course be added if anyone needs it.
>
> >> > Otherwise, I like this patch, KY, any objection to me taking it?
> >>
> >> Greg,
> >>
> >> If it is ok with you can we wait a couple of days. I am pushing to get
> information
> >> back from folks within MSFT. I am hoping we can fix this issue soon.
> >
> > Ok, I'll hold on to it for a week or so.
>
> Not to nag or anything like that, but ... It's been a week or so now,
> hasn't it? :-)
In the interim, I have submitted a patch that conforms to the MSFT guidelines
for generating guest IDs for non-MSFT operating systems on Hyper-V.
Regards,
K. Y
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?
KY Srinivasan <[email protected]> writes:
> In the interim, I have submitted a patch that conforms to the MSFT guidelines
> for generating guest IDs for non-MSFT operating systems on Hyper-V.
Oh, sorry. I missed that. Found it now. Thanks
Including distro info in a driver interface looks a bit weird to me, but
I don't really care as long as the previous static value goes away.
Bjørn
> -----Original Message-----
> From: Bjørn Mork [mailto:[email protected]]
> Sent: Monday, August 13, 2012 9:33 AM
> To: KY Srinivasan
> Cc: Greg KH; Paolo Bonzini; [email protected]; linux-
> [email protected]
> Subject: Re: [PATCH] drivers: hv: use Linux version in guest ID
>
> KY Srinivasan <[email protected]> writes:
>
> > In the interim, I have submitted a patch that conforms to the MSFT guidelines
> > for generating guest IDs for non-MSFT operating systems on Hyper-V.
>
> Oh, sorry. I missed that. Found it now. Thanks
>
> Including distro info in a driver interface looks a bit weird to me, but
> I don't really care as long as the previous static value goes away.
This is optional and does not need to be populated.
K. Y
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?