2021-05-13 05:05:07

by Yang Yingliang

[permalink] [raw]

Subject: [PATCH -next] USB: gadget: udc: s3c2410_udc: s3c2410_udc_set_ep0_ss() can be static

---

s3c2410_udc_set_ep0_ss() only used within this file. It should be static.

Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/usb/gadget/udc/s3c2410_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c
index b154b62abefa..902e9c3e940a 100644
--- a/drivers/usb/gadget/udc/s3c2410_udc.c
+++ b/drivers/usb/gadget/udc/s3c2410_udc.c
@@ -198,7 +198,7 @@ static inline void s3c2410_udc_set_ep0_de(void __iomem *base)
udc_writeb(base, S3C2410_UDC_EP0_CSR_DE, S3C2410_UDC_EP0_CSR_REG);
}

-inline void s3c2410_udc_set_ep0_ss(void __iomem *b)
+static inline void s3c2410_udc_set_ep0_ss(void __iomem *b)
{
udc_writeb(b, S3C2410_UDC_INDEX_EP0, S3C2410_UDC_INDEX_REG);
udc_writeb(b, S3C2410_UDC_EP0_CSR_SENDSTL, S3C2410_UDC_EP0_CSR_REG);
--
2.25.1

2021-05-14 14:14:00

by Felipe Balbi

[permalink] [raw]

Subject: Re: [PATCH -next] USB: gadget: udc: s3c2410_udc: s3c2410_udc_set_ep0_ss() can be static

---

Yang Yingliang <[email protected]> writes:

> s3c2410_udc_set_ep0_ss() only used within this file. It should be static.
>
> Signed-off-by: Yang Yingliang <[email protected]>

Acked-by: Felipe Balbi <[email protected]>

--
balbi

---

Attachments:

signature.asc (521.00 B)