2020-11-25 00:14:18

by kernel test robot

[permalink] [raw]
Subject: [tip:core/entry 1/1] include/linux/seccomp.h:45:15: error: use of undeclared identifier 'TIF_WORK_SECCOMP'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core/entry
head: 0395124a2fbff5132afee5767071ebe7e05885ac
commit: 0395124a2fbff5132afee5767071ebe7e05885ac [1/1] entry: Fix boot for !CONFIG_GENERIC_ENTRY
config: riscv-randconfig-r024-20201124 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project df9ae5992889560a8f3c6760b54d5051b47c7bf5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=0395124a2fbff5132afee5767071ebe7e05885ac
git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
git fetch --no-tags tip core/entry
git checkout 0395124a2fbff5132afee5767071ebe7e05885ac
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All errors (new ones prefixed by >>):

In file included from arch/riscv/kernel/asm-offsets.c:10:
In file included from include/linux/sched.h:22:
>> include/linux/seccomp.h:45:15: error: use of undeclared identifier 'TIF_WORK_SECCOMP'
if (unlikely(test_syscall_work(SECCOMP)))
^
include/linux/thread_info.h:136:45: note: expanded from macro 'test_syscall_work'
test_ti_thread_flag(current_thread_info(), TIF_WORK_##fl)
^
<scratch space>:71:1: note: expanded from here
TIF_WORK_SECCOMP
^
arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype for function 'asm_offsets' [-Wmissing-prototypes]
void asm_offsets(void)
^
arch/riscv/kernel/asm-offsets.c:14:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void asm_offsets(void)
^
static
1 warning and 1 error generated.
make[2]: *** [scripts/Makefile.build:117: arch/riscv/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1200: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.

vim +/TIF_WORK_SECCOMP +45 include/linux/seccomp.h

^1da177e4c3f415 Linus Torvalds 2005-04-16 40
a4412fc9486ec85 Andy Lutomirski 2014-07-21 41 #ifdef CONFIG_HAVE_ARCH_SECCOMP_FILTER
2f275de5d1ed726 Andy Lutomirski 2016-05-27 42 extern int __secure_computing(const struct seccomp_data *sd);
fefad9ef58ffc22 Christian Brauner 2019-09-24 43 static inline int secure_computing(void)
^1da177e4c3f415 Linus Torvalds 2005-04-16 44 {
23d67a54857a768 Gabriel Krisman Bertazi 2020-11-16 @45 if (unlikely(test_syscall_work(SECCOMP)))
fefad9ef58ffc22 Christian Brauner 2019-09-24 46 return __secure_computing(NULL);
acf3b2c71ed20c5 Will Drewry 2012-04-12 47 return 0;
^1da177e4c3f415 Linus Torvalds 2005-04-16 48 }
a4412fc9486ec85 Andy Lutomirski 2014-07-21 49 #else
a4412fc9486ec85 Andy Lutomirski 2014-07-21 50 extern void secure_computing_strict(int this_syscall);
a4412fc9486ec85 Andy Lutomirski 2014-07-21 51 #endif
e4da89d02f36945 Will Drewry 2012-04-17 52

:::::: The code at line 45 was first introduced by commit
:::::: 23d67a54857a768acdb0804cdd6037c324a50ecd seccomp: Migrate to use SYSCALL_WORK flag

:::::: TO: Gabriel Krisman Bertazi <[email protected]>
:::::: CC: Thomas Gleixner <[email protected]>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]


Attachments:
(No filename) (4.02 kB)
.config.gz (32.36 kB)
Download all attachments

2020-11-25 00:23:19

by Gabriel Krisman Bertazi

[permalink] [raw]
Subject: Re: [tip:core/entry 1/1] include/linux/seccomp.h:45:15: error: use of undeclared identifier 'TIF_WORK_SECCOMP'

kernel test robot <[email protected]> writes:

> tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core/entry
> head: 0395124a2fbff5132afee5767071ebe7e05885ac
> commit: 0395124a2fbff5132afee5767071ebe7e05885ac [1/1] entry: Fix boot for !CONFIG_GENERIC_ENTRY
> config: riscv-randconfig-r024-20201124 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project df9ae5992889560a8f3c6760b54d5051b47c7bf5)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install riscv cross compiling tool for clang build
> # apt-get install binutils-riscv64-linux-gnu
> # https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=0395124a2fbff5132afee5767071ebe7e05885ac
> git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> git fetch --no-tags tip core/entry
> git checkout 0395124a2fbff5132afee5767071ebe7e05885ac
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> In file included from arch/riscv/kernel/asm-offsets.c:10:
> In file included from include/linux/sched.h:22:
>>> include/linux/seccomp.h:45:15: error: use of undeclared identifier 'TIF_WORK_SECCOMP'
> if (unlikely(test_syscall_work(SECCOMP)))
> ^
> include/linux/thread_info.h:136:45: note: expanded from macro 'test_syscall_work'
> test_ti_thread_flag(current_thread_info(), TIF_WORK_##fl)
> ^
> <scratch space>:71:1: note: expanded from here
> TIF_WORK_SECCOMP

Was this a merge error when applying the commit?

The patch I submitted is different from what is in the TIP tree.

https://www.spinics.net/lists/arm-kernel/msg857461.html

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=core/entry

--
Gabriel Krisman Bertazi