2015-11-12 14:41:42

by Arnd Bergmann

Subject: [PATCH] ARM64: use linux/types.h in kvm.h

We should always use linux/types.h instead of asm/types.h for
consistency, and Kbuild actually warns about it:

./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>

This patch does as Kbuild asks us.

Signed-off-by: Arnd Bergmann <[email protected]>
---
Found on ARM64 allmodconfig

diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h
index 0cd7b5947dfc..2d4ca4bb0dd3 100644
--- a/arch/arm64/include/uapi/asm/kvm.h
+++ b/arch/arm64/include/uapi/asm/kvm.h
@@ -32,7 +32,7 @@

#ifndef __ASSEMBLY__
#include <linux/psci.h>
-#include <asm/types.h>
+#include <linux/types.h>
#include <asm/ptrace.h>

#define __KVM_HAVE_GUEST_DEBUG

2015-11-13 11:38:41

by Christoffer Dall

Subject: Re: [PATCH] ARM64: use linux/types.h in kvm.h

On Thu, Nov 12, 2015 at 03:41:08PM +0100, Arnd Bergmann wrote:
> We should always use linux/types.h instead of asm/types.h for
> consistency, and Kbuild actually warns about it:
>
> ./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>
>
> This patch does as Kbuild asks us.
>
> Signed-off-by: Arnd Bergmann <[email protected]>

I don't see this error when building the kernel, does it require a
special option to check for these things?


In any case, thanks for the patch, I have applied it.

-Christoffer

2015-11-13 11:46:47

by Arnd Bergmann

Subject: Re: [PATCH] ARM64: use linux/types.h in kvm.h

On Friday 13 November 2015 12:38:43 Christoffer Dall wrote:
> On Thu, Nov 12, 2015 at 03:41:08PM +0100, Arnd Bergmann wrote:
> > We should always use linux/types.h instead of asm/types.h for
> > consistency, and Kbuild actually warns about it:
> >
> > ./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>
> >
> > This patch does as Kbuild asks us.
> >
> > Signed-off-by: Arnd Bergmann <[email protected]>
>
> I don't see this error when building the kernel, does it require a
> special option to check for these things?

CONFIG_HEADERS_CHECK should be included in 'allmodconfig', which is the
configuration I used. I think at the moment, allmodconfig builds fail,
so you don't get to this point unless you also apply my other fixes.

> In any case, thanks for the patch, I have applied it.

Thanks!

Arnd