2023-01-29 19:00:24

by H. Nikolaus Schaller

Subject: [PATCH v2] MIPS: DTS: CI20: fix otg power gpio

According to schematics it is PF15 and not PF14 (MIC_SW_EN).
Seems as if it was hidden and not noticed during testing since
there is no sound DT node.

Fixes: 158c774d3c64 ("MIPS: Ingenic: Add missing nodes for Ingenic SoCs and boards.")
Cc: [email protected]
Signed-off-by: H. Nikolaus Schaller <[email protected]>
Acked-by: Paul Cercueil <[email protected]>
---
arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
index 9819abb2465dd..a276488c0f752 100644
--- a/arch/mips/boot/dts/ingenic/ci20.dts
+++ b/arch/mips/boot/dts/ingenic/ci20.dts
@@ -115,7 +115,7 @@ otg_power: fixedregulator@2 {
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;

- gpio = <&gpf 14 GPIO_ACTIVE_LOW>;
+ gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
enable-active-high;
};
};
--
2.38.1

2023-02-05 16:19:52

by Thomas Bogendoerfer

Subject: Re: [PATCH v2] MIPS: DTS: CI20: fix otg power gpio

On Sun, Jan 29, 2023 at 07:57:04PM +0100, H. Nikolaus Schaller wrote:
> According to schematics it is PF15 and not PF14 (MIC_SW_EN).
> Seems as if it was hidden and not noticed during testing since
> there is no sound DT node.
>
> Fixes: 158c774d3c64 ("MIPS: Ingenic: Add missing nodes for Ingenic SoCs and boards.")
> Cc: [email protected]
> Signed-off-by: H. Nikolaus Schaller <[email protected]>
> Acked-by: Paul Cercueil <[email protected]>
> ---
> arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
> index 9819abb2465dd..a276488c0f752 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -115,7 +115,7 @@ otg_power: fixedregulator@2 {
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
>
> - gpio = <&gpf 14 GPIO_ACTIVE_LOW>;
> + gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
> enable-active-high;
> };
> };
> --
> 2.38.1

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]