2019-01-15 16:47:24

by Jitendra

Subject: [PATCH] staging: comedi: Removed not necessary braces for single block

This patch is used to remove not necessary braces for single if block.

Signed-off-by: Jitendra Khasdev <[email protected]>
---
drivers/staging/comedi/comedi_fops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 5d2fcbfe02af..38980fad8be4 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -1605,9 +1605,9 @@ static int do_insn_ioctl(struct comedi_device *dev,
unsigned int n_data = MIN_SAMPLES;
int ret = 0;

- if (copy_from_user(&insn, arg, sizeof(insn))) {
+ if (copy_from_user(&insn, arg, sizeof(insn)))
return -EFAULT;
- }
+

n_data = max(n_data, insn.n);

--
2.13.6

2019-01-15 16:56:33

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: comedi: Removed not necessary braces for single block

On Tue, Jan 15, 2019 at 08:21:08PM +0530, root wrote:
> This patch is used to remove not necessary braces for single if block.
>
> Signed-off-by: Jitendra Kumar Khasdev <[email protected]>
> ---
> drivers/staging/comedi/comedi_fops.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

"interesting" email name you used here :)

Please fix up, it has to match the signed-off-by line.

thanks,

greg k-h

2019-01-16 18:27:48

by Jitendra

Subject: Re: [PATCH] staging: comedi: Removed not necessary braces for single block

>
>"interesting" email name you used here :)
>
>Please fix up, it has to match the signed-off-by line.
>

I fixed and resent the patch again.

---
Jitendra

2019-01-16 19:23:36

by Ian Abbott

Subject: Re: [PATCH] staging: comedi: Removed not necessary braces for single block

On 15/01/2019 15:36, Jitendra Khasdev wrote:
> This patch is used to remove not necessary braces for single if block.
>
> Signed-off-by: Jitendra Khasdev <[email protected]>
> ---
> drivers/staging/comedi/comedi_fops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 5d2fcbfe02af..38980fad8be4 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1605,9 +1605,9 @@ static int do_insn_ioctl(struct comedi_device *dev,
> unsigned int n_data = MIN_SAMPLES;
> int ret = 0;
>
> - if (copy_from_user(&insn, arg, sizeof(insn))) {
> + if (copy_from_user(&insn, arg, sizeof(insn)))
> return -EFAULT;
> - }
> +
>
> n_data = max(n_data, insn.n);
>
>

The patch looks fine. Thanks for the fix!

Reviewed-by: Ian Abbott <[email protected]>

--
-=( Ian Abbott <[email protected]> || Web: http://www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-