2023-06-15 23:44:48

by Konrad Dybcio

Subject: [PATCH] media: venus: core: Set up secure memory ranges for SC7180

Not all SC7180 devices ship with ChromeOS firmware. WoA devices use
Android-like TZ, which uses PAS for image authentication. That requires
the predefined virtual address ranges to be passed via scm calls.
Define them to enable Venus on non-CrOS SC7180 devices.

Signed-off-by: Konrad Dybcio <[email protected]>
---
drivers/media/platform/qcom/venus/core.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index 2ae867cb4c48..bee1b4c98060 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c
@@ -760,6 +760,10 @@ static const struct venus_resources sc7180_res = {
.vmem_size = 0,
.vmem_addr = 0,
.dma_mask = 0xe0000000 - 1,
+ .cp_start = 0,
+ .cp_size = 0x70800000,
+ .cp_nonpixel_start = 0x1000000,
+ .cp_nonpixel_size = 0x24800000,
.fwname = "qcom/venus-5.4/venus.mdt",
};


---
base-commit: 925294c9aa184801cc0a451b69a18dd0fe7d847d
change-id: 20230616-topic-sc7180_venus_lawp-965e5fd18c7a

Best regards,
--
Konrad Dybcio <[email protected]>

2023-06-16 05:50:45

by Nikita Travkin

Subject: Re: [PATCH] media: venus: core: Set up secure memory ranges for SC7180

Konrad Dybcio писал(а) 16.06.2023 04:36:
> Not all SC7180 devices ship with ChromeOS firmware. WoA devices use
> Android-like TZ, which uses PAS for image authentication. That requires
> the predefined virtual address ranges to be passed via scm calls.
> Define them to enable Venus on non-CrOS SC7180 devices.
>
> Signed-off-by: Konrad Dybcio <[email protected]>

This does indeed bring up the venus for me now. Thanks!

Tested-by: Nikita Travkin <[email protected]> # Aspire 1

> ---
> drivers/media/platform/qcom/venus/core.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 2ae867cb4c48..bee1b4c98060 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -760,6 +760,10 @@ static const struct venus_resources sc7180_res = {
> .vmem_size = 0,
> .vmem_addr = 0,
> .dma_mask = 0xe0000000 - 1,
> + .cp_start = 0,
> + .cp_size = 0x70800000,
> + .cp_nonpixel_start = 0x1000000,
> + .cp_nonpixel_size = 0x24800000,
> .fwname = "qcom/venus-5.4/venus.mdt",
> };
>
>
> ---
> base-commit: 925294c9aa184801cc0a451b69a18dd0fe7d847d
> change-id: 20230616-topic-sc7180_venus_lawp-965e5fd18c7a
>
> Best regards,

2023-07-10 07:28:40

by Vikash Garodia

Subject: Re: [PATCH] media: venus: core: Set up secure memory ranges for SC7180

On 6/16/2023 5:06 AM, Konrad Dybcio wrote:
> Not all SC7180 devices ship with ChromeOS firmware. WoA devices use
> Android-like TZ, which uses PAS for image authentication. That requires
> the predefined virtual address ranges to be passed via scm calls.
> Define them to enable Venus on non-CrOS SC7180 devices.
>
> Signed-off-by: Konrad Dybcio <[email protected]>

Reviewed-by: Vikash Garodia <[email protected]>

> ---
> drivers/media/platform/qcom/venus/core.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 2ae867cb4c48..bee1b4c98060 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -760,6 +760,10 @@ static const struct venus_resources sc7180_res = {
> .vmem_size = 0,
> .vmem_addr = 0,
> .dma_mask = 0xe0000000 - 1,
> + .cp_start = 0,
> + .cp_size = 0x70800000,
> + .cp_nonpixel_start = 0x1000000,
> + .cp_nonpixel_size = 0x24800000,
> .fwname = "qcom/venus-5.4/venus.mdt",
> };
>
>
> ---
> base-commit: 925294c9aa184801cc0a451b69a18dd0fe7d847d
> change-id: 20230616-topic-sc7180_venus_lawp-965e5fd18c7a
>
> Best regards,