2020-01-21 08:50:08

by Alex Shi

[permalink] [raw]
Subject: [PATCH] block/bfq: remove unused bfq_class_rt which never used

This macro is never used after introduced from commit aee69d78dec0
("block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler")

Better to remove it.

Signed-off-by: Alex Shi <[email protected]>
Cc: Paolo Valente <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
block/bfq-iosched.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index ad4af4aaf2ce..4686b68b48b4 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -427,7 +427,6 @@ void bfq_schedule_dispatch(struct bfq_data *bfqd)
}

#define bfq_class_idle(bfqq) ((bfqq)->ioprio_class == IOPRIO_CLASS_IDLE)
-#define bfq_class_rt(bfqq) ((bfqq)->ioprio_class == IOPRIO_CLASS_RT)

#define bfq_sample_valid(samples) ((samples) > 80)

--
1.8.3.1


2020-01-22 17:32:57

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] block/bfq: remove unused bfq_class_rt which never used

On 1/21/20 1:48 AM, Alex Shi wrote:
> This macro is never used after introduced from commit aee69d78dec0
> ("block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler")
>
> Better to remove it.

Applied, thanks.

--
Jens Axboe