2021-12-17 08:48:36

by CGEL

[permalink] [raw]
Subject: [PATCH] net: vertexcom: Remove unneeded semicolon

From: Changcheng Deng <[email protected]>

Fix the following coccicheck review:
./drivers/net/ethernet/vertexcom/mse102x.c: 414: 2-3: Unneeded semicolon

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Changcheng Deng <[email protected]>
---
drivers/net/ethernet/vertexcom/mse102x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/vertexcom/mse102x.c b/drivers/net/ethernet/vertexcom/mse102x.c
index a3c2426e5597..89a31783fbb4 100644
--- a/drivers/net/ethernet/vertexcom/mse102x.c
+++ b/drivers/net/ethernet/vertexcom/mse102x.c
@@ -411,7 +411,7 @@ static int mse102x_tx_pkt_spi(struct mse102x_net *mse, struct sk_buff *txb,
} else {
msleep(20);
}
- };
+ }

ret = mse102x_tx_frame_spi(mse, txb, pad);
if (ret)
--
2.25.1



2021-12-17 09:42:39

by Stefan Wahren

[permalink] [raw]
Subject: Re: [PATCH] net: vertexcom: Remove unneeded semicolon

Am 17.12.21 um 09:48 schrieb [email protected]:
> From: Changcheng Deng <[email protected]>
>
> Fix the following coccicheck review:
> ./drivers/net/ethernet/vertexcom/mse102x.c: 414: 2-3: Unneeded semicolon
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Changcheng Deng <[email protected]>
Reviewed-by: Stefan Wahren <[email protected]>

2021-12-17 16:47:47

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH] net: vertexcom: Remove unneeded semicolon

On Fri, 17 Dec 2021 08:48:27 +0000 [email protected] wrote:
> From: Changcheng Deng <[email protected]>
>
> Fix the following coccicheck review:
> ./drivers/net/ethernet/vertexcom/mse102x.c: 414: 2-3: Unneeded semicolon

The Alibaba bot has beaten you to the punch, see commit 431b9b4d9789
("net: vertexcom: remove unneeded semicolon") in net-next.

Here we thought that "robot wars" will be like Terminator, what we got
instead is false scarcity of concert tickets and auto-generated patches
which often don't build :(