This patchset deals with initializations of mptcp_options_received's two
fields, ahmac and port.
Geliang Tang (2):
mptcp: initialize mptcp_options_received's ahmac
mptcp: move mptcp_options_received's port initialization
net/mptcp/options.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.26.2
Hi Geliang,
On 19/10/2020 12:23, Geliang Tang wrote:
> This patchset deals with initializations of mptcp_options_received's two
> fields, ahmac and port.
>
> Geliang Tang (2):
> mptcp: initialize mptcp_options_received's ahmac
> mptcp: move mptcp_options_received's port initialization
Thank you for these two patches. They look good to me except one detail:
these two patches are for -net and not net-next.
I don't know if it is alright for Jakub to apply them to -net or if it
is clearer to re-send them with an updated subject.
If it is OK to apply them to -net without a re-submit, here is my:
Reviewed-by: Matthieu Baerts <[email protected]>
Also, if you don't mind and while I am here, I never know: is it OK for
you the maintainers to send one Acked/Reviewed-by for a whole series --
but then this is not reflected on patchwork -- or should we send one tag
for each patch?
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
http://www.tessares.net
On Mon, 19 Oct 2020 18:27:55 +0200 Matthieu Baerts wrote:
> Hi Geliang,
>
> On 19/10/2020 12:23, Geliang Tang wrote:
> > This patchset deals with initializations of mptcp_options_received's two
> > fields, ahmac and port.
> >
> > Geliang Tang (2):
> > mptcp: initialize mptcp_options_received's ahmac
> > mptcp: move mptcp_options_received's port initialization
>
> Thank you for these two patches. They look good to me except one detail:
> these two patches are for -net and not net-next.
>
> I don't know if it is alright for Jakub to apply them to -net or if it
> is clearer to re-send them with an updated subject.
>
> If it is OK to apply them to -net without a re-submit, here is my:
>
> Reviewed-by: Matthieu Baerts <[email protected]>
Thanks, I can apply to net.
> Also, if you don't mind and while I am here, I never know: is it OK for
> you the maintainers to send one Acked/Reviewed-by for a whole series --
> but then this is not reflected on patchwork -- or should we send one tag
> for each patch?
It's fine, we propagate those semi-manually, but it's not a problem.
Hopefully patchwork will address this at some point :(
Hi Jakub,
On 19/10/2020 22:40, Jakub Kicinski wrote:
> On Mon, 19 Oct 2020 18:27:55 +0200 Matthieu Baerts wrote:
>> Hi Geliang,
>>
>> On 19/10/2020 12:23, Geliang Tang wrote:
>>> This patchset deals with initializations of mptcp_options_received's two
>>> fields, ahmac and port.
>>>
>>> Geliang Tang (2):
>>> mptcp: initialize mptcp_options_received's ahmac
>>> mptcp: move mptcp_options_received's port initialization
>>
>> Thank you for these two patches. They look good to me except one detail:
>> these two patches are for -net and not net-next.
>>
>> I don't know if it is alright for Jakub to apply them to -net or if it
>> is clearer to re-send them with an updated subject.
>>
>> If it is OK to apply them to -net without a re-submit, here is my:
>>
>> Reviewed-by: Matthieu Baerts <[email protected]>
>
> Thanks, I can apply to net.
Great, thank you!
BTW, nice work with the maintenance of Net! More reasons for davem to
take time recovering :)
>
>> Also, if you don't mind and while I am here, I never know: is it OK for
>> you the maintainers to send one Acked/Reviewed-by for a whole series --
>> but then this is not reflected on patchwork -- or should we send one tag
>> for each patch?
>
> It's fine, we propagate those semi-manually, but it's not a problem.
> Hopefully patchwork will address this at some point :(
Thank you for your reply, good to know!
Then next time, I will send these tags per patch to save you some
semi-manual operations :)
Some preparation works have been done on patchwork side but the feature
is not available yet:
https://github.com/getpatchwork/patchwork/issues/113
Hopefully soon!
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
http://www.tessares.net
Hi Jakub,
Jakub Kicinski <[email protected]> 于2020年10月21日周三 上午7:39写道：
>
> On Mon, 19 Oct 2020 18:23:14 +0800 Geliang Tang wrote:
> > This patchset deals with initializations of mptcp_options_received's two
> > fields, ahmac and port.
>
> Applied, but two extra comments:
> - please make sure the commit messages are in imperative form
> e.g. "Initialize x..." rather than "This patches initializes x.."
> - I dropped the Fixes tag from patch 2, and only queued patch 1 for
> stable - patch 2 is a minor clean up, right?
Yes, that's right. Thanks for applying and updating the patches.
-Geliang
>
> Thanks!
On Mon, 19 Oct 2020 18:23:14 +0800 Geliang Tang wrote:
> This patchset deals with initializations of mptcp_options_received's two
> fields, ahmac and port.
Applied, but two extra comments:
- please make sure the commit messages are in imperative form
e.g. "Initialize x..." rather than "This patches initializes x.."
- I dropped the Fixes tag from patch 2, and only queued patch 1 for
stable - patch 2 is a minor clean up, right?
Thanks!