This condition already uses an object of type ipv6hdr in the line above.
Use the object directly instead of calling ipv6_hdr
Signed-off-by: Mohammed Gamal <[email protected]>
---
drivers/net/hyperv/netvsc_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 63c98bb..06d591c 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb)
if (ip6->nexthdr == IPPROTO_TCP)
return TRANSPORT_INFO_IPV6_TCP;
- else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP)
+ else if (ip6->nexthdr == IPPROTO_UDP)
return TRANSPORT_INFO_IPV6_UDP;
}
--
2.9.4
> -----Original Message-----
> From: Mohammed Gamal [mailto:[email protected]]
> Sent: Wednesday, July 19, 2017 9:19 AM
> To: KY Srinivasan <[email protected]>; Haiyang Zhang
> <[email protected]>; Stephen Hemminger <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; Mohammed Gamal
> <[email protected]>
> Subject: [PATCH] netvsc: Remove redundant use of ipv6_hdr()
>
> This condition already uses an object of type ipv6hdr in the line above.
> Use the object directly instead of calling ipv6_hdr
>
> Signed-off-by: Mohammed Gamal <[email protected]>
Reviewed-by: Haiyang Zhang <[email protected]>
Thanks.
On Wed, 19 Jul 2017 15:19:28 +0200
Mohammed Gamal <[email protected]> wrote:
> This condition already uses an object of type ipv6hdr in the line above.
> Use the object directly instead of calling ipv6_hdr
>
> Signed-off-by: Mohammed Gamal <[email protected]>
> ---
> drivers/net/hyperv/netvsc_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 63c98bb..06d591c 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb)
>
> if (ip6->nexthdr == IPPROTO_TCP)
> return TRANSPORT_INFO_IPV6_TCP;
> - else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP)
> + else if (ip6->nexthdr == IPPROTO_UDP)
> return TRANSPORT_INFO_IPV6_UDP;
> }
>
Patch looks fine.
Network patches go through [email protected] not linux driver mailing list.
I will add it to my next patch of patches that are going to netdev for net-next.
----- Original Message -----
> On Wed, 19 Jul 2017 15:19:28 +0200
> Mohammed Gamal <[email protected]> wrote:
>
> > This condition already uses an object of type ipv6hdr in the line above.
> > Use the object directly instead of calling ipv6_hdr
> >
> > Signed-off-by: Mohammed Gamal <[email protected]>
> > ---
> > drivers/net/hyperv/netvsc_drv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/hyperv/netvsc_drv.c
> > b/drivers/net/hyperv/netvsc_drv.c
> > index 63c98bb..06d591c 100644
> > --- a/drivers/net/hyperv/netvsc_drv.c
> > +++ b/drivers/net/hyperv/netvsc_drv.c
> > @@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb)
> >
> > if (ip6->nexthdr == IPPROTO_TCP)
> > return TRANSPORT_INFO_IPV6_TCP;
> > - else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP)
> > + else if (ip6->nexthdr == IPPROTO_UDP)
> > return TRANSPORT_INFO_IPV6_UDP;
> > }
> >
>
> Patch looks fine.
> Network patches go through [email protected] not linux driver mailing
> list.
> I will add it to my next patch of patches that are going to netdev for
> net-next.
>
Thanks for the heads up. Will take that into consideration next time.
It's worth pointing out that MAINTAINERS points that files under
drivers/net/hyperv are to be sent to [email protected].
Perhaps that should be updated.
On Wed, 19 Jul 2017 13:48:03 -0400 (EDT)
Mohammed Gamal <[email protected]> wrote:
> ----- Original Message -----
> > On Wed, 19 Jul 2017 15:19:28 +0200
> > Mohammed Gamal <[email protected]> wrote:
> >
> > > This condition already uses an object of type ipv6hdr in the line above.
> > > Use the object directly instead of calling ipv6_hdr
> > >
> > > Signed-off-by: Mohammed Gamal <[email protected]>
> > > ---
> > > drivers/net/hyperv/netvsc_drv.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/hyperv/netvsc_drv.c
> > > b/drivers/net/hyperv/netvsc_drv.c
> > > index 63c98bb..06d591c 100644
> > > --- a/drivers/net/hyperv/netvsc_drv.c
> > > +++ b/drivers/net/hyperv/netvsc_drv.c
> > > @@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb)
> > >
> > > if (ip6->nexthdr == IPPROTO_TCP)
> > > return TRANSPORT_INFO_IPV6_TCP;
> > > - else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP)
> > > + else if (ip6->nexthdr == IPPROTO_UDP)
> > > return TRANSPORT_INFO_IPV6_UDP;
> > > }
> > >
> >
> > Patch looks fine.
> > Network patches go through [email protected] not linux driver mailing
> > list.
> > I will add it to my next patch of patches that are going to netdev for
> > net-next.
> >
> Thanks for the heads up. Will take that into consideration next time.
>
> It's worth pointing out that MAINTAINERS points that files under
> drivers/net/hyperv are to be sent to [email protected].
> Perhaps that should be updated.
MAINTAINERS doesn't have a good way to handle dual sub-trees.
> -----Original Message-----
> From: Mohammed Gamal [mailto:[email protected]]
> Sent: Wednesday, July 19, 2017 1:48 PM
> To: Stephen Hemminger <[email protected]>
> Cc: KY Srinivasan <[email protected]>; Haiyang Zhang
> <[email protected]>; Stephen Hemminger <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr()
>
>
>
> ----- Original Message -----
> > On Wed, 19 Jul 2017 15:19:28 +0200
> > Mohammed Gamal <[email protected]> wrote:
> >
> > > This condition already uses an object of type ipv6hdr in the line
> above.
> > > Use the object directly instead of calling ipv6_hdr
> > >
> > > Signed-off-by: Mohammed Gamal <[email protected]>
> > > ---
> > > drivers/net/hyperv/netvsc_drv.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/hyperv/netvsc_drv.c
> > > b/drivers/net/hyperv/netvsc_drv.c
> > > index 63c98bb..06d591c 100644
> > > --- a/drivers/net/hyperv/netvsc_drv.c
> > > +++ b/drivers/net/hyperv/netvsc_drv.c
> > > @@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb)
> > >
> > > if (ip6->nexthdr == IPPROTO_TCP)
> > > return TRANSPORT_INFO_IPV6_TCP;
> > > - else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP)
> > > + else if (ip6->nexthdr == IPPROTO_UDP)
> > > return TRANSPORT_INFO_IPV6_UDP;
> > > }
> > >
> >
> > Patch looks fine.
> > Network patches go through [email protected] not linux driver
> mailing
> > list.
> > I will add it to my next patch of patches that are going to netdev for
> > net-next.
> >
> Thanks for the heads up. Will take that into consideration next time.
>
> It's worth pointing out that MAINTAINERS points that files under
> drivers/net/hyperv are to be sent to [email protected].
> Perhaps that should be updated.
I will update [email protected] in MAINTAINERS to the new
mailing list name of the Linux driver project.
Thanks,
- Haiyang
On Wed, Jul 19, 2017 at 01:48:03PM -0400, Mohammed Gamal wrote:
> It's worth pointing out that MAINTAINERS points that files under
> drivers/net/hyperv are to be sent to [email protected].
> Perhaps that should be updated.
get_maintainer.pl gives you both because drivers/net/ is netdev. Just
use the script.
regards,
dan carpenter