2021-01-15 15:14:03

by Akira Yokosawa

[permalink] [raw]
Subject: [PATCH -rcu] rculist: Replace reference to atomic_ops.rst

From f92cae321e9a42a1d4bc8a2d5d1a2cd62ab35410 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Fri, 15 Jan 2021 23:39:03 +0900
Subject: [PATCH -rcu] rculist: Replace reference to atomic_ops.rst

atomic_ops.rst was removed in commit f0400a77ebdc ("atomic: Delete
obsolete documentation").
Instead, reference a section in memory-barriers.txt discussing
the use of barrier() in loops.

Cc: Peter Zijlstra <[email protected]>
Signed-off-by: Akira Yokosawa <[email protected]>
---
include/linux/rculist_nulls.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/rculist_nulls.h b/include/linux/rculist_nulls.h
index ff3e94779e73..d8afdb8784c1 100644
--- a/include/linux/rculist_nulls.h
+++ b/include/linux/rculist_nulls.h
@@ -161,7 +161,7 @@ static inline void hlist_nulls_add_fake(struct hlist_nulls_node *n)
*
* The barrier() is needed to make sure compiler doesn't cache first element [1],
* as this loop can be restarted [2]
- * [1] Documentation/core-api/atomic_ops.rst around line 114
+ * [1] Documentation/memory-barriers.txt around line 1533
* [2] Documentation/RCU/rculist_nulls.rst around line 146
*/
#define hlist_nulls_for_each_entry_rcu(tpos, pos, head, member) \
--
2.17.1


2021-01-15 18:24:03

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [PATCH -rcu] rculist: Replace reference to atomic_ops.rst

On Sat, Jan 16, 2021 at 12:11:45AM +0900, Akira Yokosawa wrote:
> >From f92cae321e9a42a1d4bc8a2d5d1a2cd62ab35410 Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <[email protected]>
> Date: Fri, 15 Jan 2021 23:39:03 +0900
> Subject: [PATCH -rcu] rculist: Replace reference to atomic_ops.rst
>
> atomic_ops.rst was removed in commit f0400a77ebdc ("atomic: Delete
> obsolete documentation").
> Instead, reference a section in memory-barriers.txt discussing
> the use of barrier() in loops.
>
> Cc: Peter Zijlstra <[email protected]>
> Signed-off-by: Akira Yokosawa <[email protected]>

Queued, thank you!

Thanx, Paul

> ---
> include/linux/rculist_nulls.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/rculist_nulls.h b/include/linux/rculist_nulls.h
> index ff3e94779e73..d8afdb8784c1 100644
> --- a/include/linux/rculist_nulls.h
> +++ b/include/linux/rculist_nulls.h
> @@ -161,7 +161,7 @@ static inline void hlist_nulls_add_fake(struct hlist_nulls_node *n)
> *
> * The barrier() is needed to make sure compiler doesn't cache first element [1],
> * as this loop can be restarted [2]
> - * [1] Documentation/core-api/atomic_ops.rst around line 114
> + * [1] Documentation/memory-barriers.txt around line 1533
> * [2] Documentation/RCU/rculist_nulls.rst around line 146
> */
> #define hlist_nulls_for_each_entry_rcu(tpos, pos, head, member) \
> --
> 2.17.1
>