2022-08-02 10:43:15

by Christophe Leroy

Subject: [PATCH] EDAC/ppc_4xx: Include required of_irq header directly

Commit 4d5c5bad5193 ("powerpc: Remove asm/prom.h from asm/mpc52xx.h
and asm/pci.h") that cleans up powerpc's asm/prom.h leads to build
errors in ppc4xx_edac.c due to missing header. Include required
header directly to avoid the build failure.

Reported-by: kernel test robot <[email protected]>
Fixes: 4d5c5bad5193 ("powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h")
Signed-off-by: Christophe Leroy <[email protected]>
---
drivers/edac/ppc4xx_edac.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/edac/ppc4xx_edac.c b/drivers/edac/ppc4xx_edac.c
index 6793f6d799e7..0bc670778c99 100644
--- a/drivers/edac/ppc4xx_edac.c
+++ b/drivers/edac/ppc4xx_edac.c
@@ -11,6 +11,7 @@
#include <linux/mm.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_irq.h>
#include <linux/of_platform.h>
#include <linux/types.h>

--
2.36.1

2022-08-02 12:11:51

by Michael Ellerman

Subject: Re: [PATCH] EDAC/ppc_4xx: Include required of_irq header directly

Christophe Leroy <[email protected]> writes:
> Commit 4d5c5bad5193 ("powerpc: Remove asm/prom.h from asm/mpc52xx.h
> and asm/pci.h") that cleans up powerpc's asm/prom.h leads to build
> errors in ppc4xx_edac.c due to missing header. Include required
> header directly to avoid the build failure.
>
> Reported-by: kernel test robot <[email protected]>
> Fixes: 4d5c5bad5193 ("powerpc: Remove asm/prom.h from asm/mpc52xx.h and asm/pci.h")
> Signed-off-by: Christophe Leroy <[email protected]>
> ---
> drivers/edac/ppc4xx_edac.c | 1 +
> 1 file changed, 1 insertion(+)

I'll pick this up as I merged the commit that broke it.

cheers

> diff --git a/drivers/edac/ppc4xx_edac.c b/drivers/edac/ppc4xx_edac.c
> index 6793f6d799e7..0bc670778c99 100644
> --- a/drivers/edac/ppc4xx_edac.c
> +++ b/drivers/edac/ppc4xx_edac.c
> @@ -11,6 +11,7 @@
> #include <linux/mm.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_irq.h>
> #include <linux/of_platform.h>
> #include <linux/types.h>
>
> --
> 2.36.1

2022-08-06 07:22:38

by Michael Ellerman

Subject: Re: [PATCH] EDAC/ppc_4xx: Include required of_irq header directly

On Tue, 2 Aug 2022 12:30:38 +0200, Christophe Leroy wrote:
> Commit 4d5c5bad5193 ("powerpc: Remove asm/prom.h from asm/mpc52xx.h
> and asm/pci.h") that cleans up powerpc's asm/prom.h leads to build
> errors in ppc4xx_edac.c due to missing header. Include required
> header directly to avoid the build failure.
>
>

Applied to powerpc/next.

[1/1] EDAC/ppc_4xx: Include required of_irq header directly
https://git.kernel.org/powerpc/c/bce02f71e48f7b89b9b52424ad2df4e5bc87a8ec

cheers