2022-12-01 11:22:41

by Arend van Spriel

[permalink] [raw]
Subject: Re: [PATCH wireless v2] brcmfmac: fix potential memory leak in brcmf_netdev_start_xmit()

On 11/17/2022 12:33 PM, 'Zhang Changzhong' via BRCM80211-DEV-LIST,PDL wrote:
> The brcmf_netdev_start_xmit() returns NETDEV_TX_OK without freeing skb
> in case of pskb_expand_head() fails, add dev_kfree_skb() to fix it.
> Compile tested only.
>
> Fixes: 270a6c1f65fe ("brcmfmac: rework headroom check in .start_xmit()")
Reviewed-by: Arend van Spriel <[email protected]>
> Signed-off-by: Zhang Changzhong <[email protected]>
> ---
> v1->v2: add "Compile tested only" to commit log
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 1 +
> 1 file changed, 1 insertion(+)


Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature