2019-05-25 18:01:51

by Hariprasad Kelam

Subject: [PATCH] drm/bridge: analogix_dp: possible condition with no effect (if == else)

fix below warning reported by coccicheck

./drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1414:6-8: WARNING:
possible condition with no effect (if == else)

Signed-off-by: Hariprasad Kelam <[email protected]>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 257d69b..cfcd159 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1411,8 +1411,6 @@ static void analogix_dp_bridge_mode_set(struct drm_bridge *bridge,
video->color_space = COLOR_YCBCR444;
else if (display_info->color_formats & DRM_COLOR_FORMAT_YCRCB422)
video->color_space = COLOR_YCBCR422;
- else if (display_info->color_formats & DRM_COLOR_FORMAT_RGB444)
- video->color_space = COLOR_RGB;
else
video->color_space = COLOR_RGB;

--
2.7.4

2019-06-13 15:19:34

by Andrzej Hajda

Subject: Re: [PATCH] drm/bridge: analogix_dp: possible condition with no effect (if == else)

On 25.05.2019 19:59, Hariprasad Kelam wrote:
> fix below warning reported by coccicheck
>
> ./drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1414:6-8: WARNING:
> possible condition with no effect (if == else)
>
> Signed-off-by: Hariprasad Kelam <[email protected]>


Mixed feelings about it, but:

Reviewed-by: Andrzej Hajda <[email protected]>


I will queue it to drm-misc-next.
 --
Regards
Andrzej


> ---
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 257d69b..cfcd159 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1411,8 +1411,6 @@ static void analogix_dp_bridge_mode_set(struct drm_bridge *bridge,
> video->color_space = COLOR_YCBCR444;
> else if (display_info->color_formats & DRM_COLOR_FORMAT_YCRCB422)
> video->color_space = COLOR_YCBCR422;
> - else if (display_info->color_formats & DRM_COLOR_FORMAT_RGB444)
> - video->color_space = COLOR_RGB;
> else
> video->color_space = COLOR_RGB;
>