2020-04-01 11:00:45

by Hu Haowen

Subject: [PATCH] net/faraday: fix grammar in function ftgmac100_setup_clk() in ftgmac100.c

"its not" is wrong. The words should be "it's not".

Signed-off-by: Hu Haowen <[email protected]>
---
drivers/net/ethernet/faraday/ftgmac100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
index 835b7816e372..87236206366f 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.c
+++ b/drivers/net/ethernet/faraday/ftgmac100.c
@@ -1731,7 +1731,7 @@ static int ftgmac100_setup_clk(struct ftgmac100 *priv)
if (rc)
goto cleanup_clk;

- /* RCLK is for RMII, typically used for NCSI. Optional because its not
+ /* RCLK is for RMII, typically used for NCSI. Optional because it's not
* necessary if it's the AST2400 MAC, or the MAC is configured for
* RGMII, or the controller is not an ASPEED-based controller.
*/
--
2.20.1

2020-04-01 18:26:14

by David Miller

Subject: Re: [PATCH] net/faraday: fix grammar in function ftgmac100_setup_clk() in ftgmac100.c

From: Hu Haowen <[email protected]>
Date: Wed, 1 Apr 2020 18:56:24 +0800

> "its not" is wrong. The words should be "it's not".
>
> Signed-off-by: Hu Haowen <[email protected]>

Applied.

2020-04-02 10:44:46

by Benjamin Herrenschmidt

Subject: Re: [PATCH] net/faraday: fix grammar in function ftgmac100_setup_clk() in ftgmac100.c

On Wed, 2020-04-01 at 18:56 +0800, Hu Haowen wrote:
> "its not" is wrong. The words should be "it's not".
>
> Signed-off-by: Hu Haowen <[email protected]>

Typo more than grammer :-)

Acked-by: Benjamin Herrenschmidt <[email protected]>

(the offender)

> ---
> drivers/net/ethernet/faraday/ftgmac100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index 835b7816e372..87236206366f 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -1731,7 +1731,7 @@ static int ftgmac100_setup_clk(struct ftgmac100 *priv)
> if (rc)
> goto cleanup_clk;
>
> - /* RCLK is for RMII, typically used for NCSI. Optional because its not
> + /* RCLK is for RMII, typically used for NCSI. Optional because it's not
> * necessary if it's the AST2400 MAC, or the MAC is configured for
> * RGMII, or the controller is not an ASPEED-based controller.
> */

2020-04-02 10:49:17

by Andrew Jeffery

Subject: Re: [PATCH] net/faraday: fix grammar in function ftgmac100_setup_clk() in ftgmac100.c

On Thu, 2 Apr 2020, at 21:13, Benjamin Herrenschmidt wrote:
> On Wed, 2020-04-01 at 18:56 +0800, Hu Haowen wrote:
> > "its not" is wrong. The words should be "it's not".
> >
> > Signed-off-by: Hu Haowen <[email protected]>
>
> Typo more than grammer :-)
>
> Acked-by: Benjamin Herrenschmidt <[email protected]>
>
> (the offender)

No, I am Spartacus!

But yeah:

Acked-by: Andrew Jeffery <[email protected]>

2020-04-02 11:16:41

by Hu Haowen

Subject: Re: [PATCH] net/faraday: fix grammar in function ftgmac100_setup_clk() in ftgmac100.c

On 2020/4/2 6:43 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2020-04-01 at 18:56 +0800, Hu Haowen wrote:
>> "its not" is wrong. The words should be "it's not".
>>
>> Signed-off-by: Hu Haowen <[email protected]>
> Typo more than grammer :-)


Emm...


In fact I just found the mistake by accident and decided to fix it up
because it is a standard in the kernel documention not to misspell
words :-)


>
> Acked-by: Benjamin Herrenschmidt <[email protected]>
>
> (the offender)
>
>> ---
>> drivers/net/ethernet/faraday/ftgmac100.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
>> index 835b7816e372..87236206366f 100644
>> --- a/drivers/net/ethernet/faraday/ftgmac100.c
>> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
>> @@ -1731,7 +1731,7 @@ static int ftgmac100_setup_clk(struct ftgmac100 *priv)
>> if (rc)
>> goto cleanup_clk;
>>
>> - /* RCLK is for RMII, typically used for NCSI. Optional because its not
>> + /* RCLK is for RMII, typically used for NCSI. Optional because it's not
>> * necessary if it's the AST2400 MAC, or the MAC is configured for
>> * RGMII, or the controller is not an ASPEED-based controller.
>> */