2021-06-05 12:19:55

by Yang Yingliang

[permalink] [raw]
Subject: [PATCH net-next v2] net: lantiq: Use devm_platform_get_and_ioremap_resource()

Use devm_platform_get_and_ioremap_resource() to simplify
code.

Signed-off-by: Yang Yingliang <[email protected]>
---
v2:
remove 'res'
---
drivers/net/ethernet/lantiq_xrx200.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/lantiq_xrx200.c b/drivers/net/ethernet/lantiq_xrx200.c
index 36dc3e5f6218..27df06ed355e 100644
--- a/drivers/net/ethernet/lantiq_xrx200.c
+++ b/drivers/net/ethernet/lantiq_xrx200.c
@@ -436,7 +436,6 @@ static int xrx200_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct device_node *np = dev->of_node;
- struct resource *res;
struct xrx200_priv *priv;
struct net_device *net_dev;
int err;
@@ -456,13 +455,7 @@ static int xrx200_probe(struct platform_device *pdev)
net_dev->max_mtu = XRX200_DMA_DATA_LEN;

/* load the memory ranges */
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- dev_err(dev, "failed to get resources\n");
- return -ENOENT;
- }
-
- priv->pmac_reg = devm_ioremap_resource(dev, res);
+ priv->pmac_reg = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(priv->pmac_reg))
return PTR_ERR(priv->pmac_reg);

--
2.25.1


2021-06-05 12:55:17

by Hauke Mehrtens

[permalink] [raw]
Subject: Re: [PATCH net-next v2] net: lantiq: Use devm_platform_get_and_ioremap_resource()

On 6/5/21 2:21 PM, Yang Yingliang wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
>
> Signed-off-by: Yang Yingliang <[email protected]>

Acked-by: Hauke Mehrtens <[email protected]>

> ---
> v2:
> remove 'res'
> ---
> drivers/net/ethernet/lantiq_xrx200.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/lantiq_xrx200.c b/drivers/net/ethernet/lantiq_xrx200.c
> index 36dc3e5f6218..27df06ed355e 100644
> --- a/drivers/net/ethernet/lantiq_xrx200.c
> +++ b/drivers/net/ethernet/lantiq_xrx200.c
> @@ -436,7 +436,6 @@ static int xrx200_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct device_node *np = dev->of_node;
> - struct resource *res;
> struct xrx200_priv *priv;
> struct net_device *net_dev;
> int err;
> @@ -456,13 +455,7 @@ static int xrx200_probe(struct platform_device *pdev)
> net_dev->max_mtu = XRX200_DMA_DATA_LEN;
>
> /* load the memory ranges */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "failed to get resources\n");
> - return -ENOENT;
> - }
> -
> - priv->pmac_reg = devm_ioremap_resource(dev, res);
> + priv->pmac_reg = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(priv->pmac_reg))
> return PTR_ERR(priv->pmac_reg);
>
>

Attachments:
OpenPGP_0x93DD20630910B515.asc (9.79 kB)
OpenPGP public key OpenPGP_signature (499.00 B)
OpenPGP digital signature Download all attachments

2021-06-07 20:14:03

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net-next v2] net: lantiq: Use devm_platform_get_and_ioremap_resource()

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 5 Jun 2021 20:21:27 +0800 you wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
>
> Signed-off-by: Yang Yingliang <[email protected]>
> ---
> v2:
> remove 'res'
>
> [...]

Here is the summary with links:
- [net-next,v2] net: lantiq: Use devm_platform_get_and_ioremap_resource()
https://git.kernel.org/netdev/net-next/c/d402af20315c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html