2022-10-04 02:39:43

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: manual merge of the fbdev tree with the drm tree

---

Hi all,

Today's linux-next merge of the fbdev tree got a conflict in:

drivers/video/fbdev/tridentfb.c

between commit:

145eed48de27 ("fbdev: Remove conflicting devices on PCI bus")

from the drm tree and commit:

d738bf0123d6 ("fbdev: tridentfb: Fix missing pci_disable_device() in probe and remove")

from the fbdev tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

--
Cheers,
Stephen Rothwell

diff --cc drivers/video/fbdev/tridentfb.c
index f9c3b1d38fc2,4d08f4489a0a..000000000000
--- a/drivers/video/fbdev/tridentfb.c
+++ b/drivers/video/fbdev/tridentfb.c
@@@ -1471,11 -1465,7 +1466,11 @@@ static int trident_pci_probe(struct pci
int chip_id;
bool found = false;

+ err = aperture_remove_conflicting_pci_devices(dev, "tridentfb");
+ if (err)
+ return err;
+
- err = pci_enable_device(dev);
+ err = pcim_enable_device(dev);
if (err)
return err;

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2022-10-04 07:43:34

by Helge Deller

[permalink] [raw]

Subject: Re: linux-next: manual merge of the fbdev tree with the drm tree

---

On 10/4/22 04:27, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the fbdev tree got a conflict in:
>
> drivers/video/fbdev/tridentfb.c
>
> between commit:
>
> 145eed48de27 ("fbdev: Remove conflicting devices on PCI bus")
>
> from the drm tree and commit:
>
> d738bf0123d6 ("fbdev: tridentfb: Fix missing pci_disable_device() in probe and remove")
>
> from the fbdev tree.

Thanks for the notice!
I'll fix it up in the fbdev tree, either by dropping that offending patch or fix the conflict.

Helge