On 09/04/2022 14:24, Paul Cercueil wrote:
> Hi Krzysztof,
>
> Le sam., avril 9 2022 at 13:11:48 +0200, Krzysztof Kozlowski
> <[email protected]> a écrit :
>> On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
>>> arch/mips/boot/dts/ingenic/ci20.dtb: timer@10002000: compatible:
>>> 'oneOf' conditional failed, one must be fixed:
>>> ['ingenic,jz4780-tcu', 'ingenic,jz4770-tcu', 'simple-mfd'] is too
>>> long
>>> 'ingenic,jz4780-tcu' is not one of ['ingenic,jz4740-tcu',
>>> 'ingenic,jz4725b-tcu', 'ingenic,jz4760-tcu', 'ingenic,x1000-tcu']
>>> 'simple-mfd' was expected
>>> 'ingenic,jz4760-tcu' was expected
>>
>> Trim it a bit...
>>
>>> From schema:
>>> Documentation/devicetree/bindings/timer/ingenic,tcu.yaml
>>
>> You need to explain this. You're changing the effective compatible of
>> the device and doing so based only on schema warning does not look
>> enough. Please write real reason instead of this fat warning, e.g.
>> that
>> both devices are actually compatible and this has no real effect
>> except
>> schema checks.
>
> Well, if the schema says that it should use a particular fallback
> string, then that's what the DTS should use, right?
Or the schema is wrong. :)
> If making the DTS schema-compliant causes breakages, then that means
> the schema is wrong and should be fixed.
Exactly, so the commit needs a bit of explanation why one solution was
chosen over the other. BTW, I am not saying that schema or DTS is wrong,
just that commit is not explained enough.
Best regards,
Krzysztof
> Am 09.04.2022 um 14:38 schrieb Krzysztof Kozlowski <[email protected]>:
>
> On 09/04/2022 14:24, Paul Cercueil wrote:
>> Hi Krzysztof,
>>
>> Le sam., avril 9 2022 at 13:11:48 +0200, Krzysztof Kozlowski
>> <[email protected]> a écrit :
>>> On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: timer@10002000: compatible:
>>>> 'oneOf' conditional failed, one must be fixed:
>>>> ['ingenic,jz4780-tcu', 'ingenic,jz4770-tcu', 'simple-mfd'] is too
>>>> long
>>>> 'ingenic,jz4780-tcu' is not one of ['ingenic,jz4740-tcu',
>>>> 'ingenic,jz4725b-tcu', 'ingenic,jz4760-tcu', 'ingenic,x1000-tcu']
>>>> 'simple-mfd' was expected
>>>> 'ingenic,jz4760-tcu' was expected
>>>
>>> Trim it a bit...
>>>
>>>> From schema:
>>>> Documentation/devicetree/bindings/timer/ingenic,tcu.yaml
>>>
>>> You need to explain this. You're changing the effective compatible of
>>> the device and doing so based only on schema warning does not look
>>> enough. Please write real reason instead of this fat warning, e.g.
>>> that
>>> both devices are actually compatible and this has no real effect
>>> except
>>> schema checks.
>>
>> Well, if the schema says that it should use a particular fallback
>> string, then that's what the DTS should use, right?
>
> Or the schema is wrong. :)
>
>> If making the DTS schema-compliant causes breakages, then that means
>> the schema is wrong and should be fixed.
Well, in this case making the DTS fit the schema does not break.
So why think or explain why the schema is right?
>
> Exactly, so the commit needs a bit of explanation why one solution was
> chosen over the other. BTW, I am not saying that schema or DTS is wrong,
> just that commit is not explained enough.
>
> Best regards,
> Krzysztof