This is a part of LP3943 MFD driver.
LP3943 is configurable as a GPIO expander, up to 16 GPIOs.
* Application note: how to configure LP3943 as a GPIO expander
http://www.ti.com/lit/an/snva287a/snva287a.pdf
* Supported GPIO controller operations
direction_input, direction_output, get, set
* GPIO direction register not supported
LP3943 doesn't have the GPIO direction register. It only provides input and
output status registers.
So, private data for the direction should be handled manually.
This variable is updated whenever the direction is changed and
used in 'get' operation.
* Register access through exported LP3943 MFD functions
Signed-off-by: Milo Kim <[email protected]>
---
drivers/gpio/Kconfig | 6 ++
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio-lp3943.c | 224 ++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 231 insertions(+)
create mode 100644 drivers/gpio/gpio-lp3943.c
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 573c449..d80801f 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -325,6 +325,12 @@ config GPIO_ARIZONA
help
Support for GPIOs on Wolfson Arizona class devices.
+config GPIO_LP3943
+ tristate "TI/National Semiconductor LP3943 GPIO expander"
+ depends on MFD_LP3943
+ help
+ GPIO driver for LP3943 MFD.
+
config GPIO_MAX7300
tristate "Maxim MAX7300 GPIO expander"
depends on I2C
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index 0cb2d65..ff580ac 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -31,6 +31,7 @@ obj-$(CONFIG_GPIO_IT8761E) += gpio-it8761e.o
obj-$(CONFIG_GPIO_JANZ_TTL) += gpio-janz-ttl.o
obj-$(CONFIG_ARCH_KS8695) += gpio-ks8695.o
obj-$(CONFIG_GPIO_LANGWELL) += gpio-langwell.o
+obj-$(CONFIG_GPIO_LP3943) += gpio-lp3943.o
obj-$(CONFIG_ARCH_LPC32XX) += gpio-lpc32xx.o
obj-$(CONFIG_GPIO_LYNXPOINT) += gpio-lynxpoint.o
obj-$(CONFIG_GPIO_MAX730X) += gpio-max730x.o
diff --git a/drivers/gpio/gpio-lp3943.c b/drivers/gpio/gpio-lp3943.c
new file mode 100644
index 0000000..dc74ca4
--- /dev/null
+++ b/drivers/gpio/gpio-lp3943.c
@@ -0,0 +1,224 @@
+/*
+ * TI/National Semiconductor LP3943 GPIO driver
+ *
+ * Copyright (C) 2013 Texas Instruments
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2.
+ */
+
+#include <linux/err.h>
+#include <linux/gpio.h>
+#include <linux/i2c.h>
+#include <linux/mfd/lp3943.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+
+#define to_lp3943_gpio(_chip) container_of(_chip, struct lp3943_gpio, chip)
+
+enum lp3943_gpios {
+ LP3943_GPIO1,
+ LP3943_GPIO2,
+ LP3943_GPIO3,
+ LP3943_GPIO4,
+ LP3943_GPIO5,
+ LP3943_GPIO6,
+ LP3943_GPIO7,
+ LP3943_GPIO8,
+ LP3943_GPIO9,
+ LP3943_GPIO10,
+ LP3943_GPIO11,
+ LP3943_GPIO12,
+ LP3943_GPIO13,
+ LP3943_GPIO14,
+ LP3943_GPIO15,
+ LP3943_GPIO16,
+ LP3943_MAX_GPIO,
+};
+
+struct lp3943_gpio {
+ struct gpio_chip chip;
+ struct lp3943 *l;
+ bool is_input[LP3943_MAX_GPIO];
+};
+
+static int lp3943_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
+{
+ struct lp3943_gpio *lg = to_lp3943_gpio(chip);
+ const struct lp3943_reg_cfg *mux = lg->l->mux_cfg;
+ u8 addr;
+ u8 mask;
+ u8 shift;
+
+ lg->is_input[offset] = true;
+
+ addr = mux[offset].reg;
+ mask = mux[offset].mask;
+ shift = mux[offset].shift;
+
+ return lp3943_update_bits(lg->l, addr, mask, LP3943_GPIO_IN << shift);
+}
+
+static int lp3943_get_gpio_in_status(struct lp3943_gpio *lg,
+ struct gpio_chip *chip, unsigned offset)
+{
+ u8 addr;
+ u8 read;
+ int err;
+
+ switch (offset) {
+ case LP3943_GPIO1 ... LP3943_GPIO8:
+ addr = LP3943_REG_GPIO_A;
+ break;
+ case LP3943_GPIO9 ... LP3943_GPIO16:
+ addr = LP3943_REG_GPIO_B;
+ offset = offset - 8;
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ err = lp3943_read_byte(lg->l, addr, &read);
+ if (err)
+ return err;
+
+ if (read & (1 << offset))
+ return 1;
+ else
+ return 0;
+}
+
+static int lp3943_get_gpio_out_status(struct lp3943_gpio *lg,
+ struct gpio_chip *chip, unsigned offset)
+{
+ const struct lp3943_reg_cfg *mux = lg->l->mux_cfg;
+ u8 addr = mux[offset].reg;
+ u8 mask = mux[offset].mask;
+ u8 shift = mux[offset].shift;
+ u8 read;
+ int err;
+
+ err = lp3943_read_byte(lg->l, addr, &read);
+ if (err)
+ return err;
+
+ read = (read & mask) >> shift;
+
+ if (read == LP3943_GPIO_OUT_HIGH)
+ return 1;
+ else if (read == LP3943_GPIO_OUT_LOW)
+ return 0;
+ else
+ return -EINVAL;
+}
+
+static int lp3943_gpio_get(struct gpio_chip *chip, unsigned offset)
+{
+ struct lp3943_gpio *lg = to_lp3943_gpio(chip);
+
+ /*
+ * Limitation:
+ * LP3943 doesn't have the GPIO direction register. It provides
+ * only input and output status registers.
+ * So, direction info is required to handle the 'get' operation.
+ * This variable is updated whenever the direction is changed and
+ * it is used here.
+ */
+
+ if (lg->is_input[offset])
+ return lp3943_get_gpio_in_status(lg, chip, offset);
+ else
+ return lp3943_get_gpio_out_status(lg, chip, offset);
+}
+
+static void lp3943_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
+{
+ struct lp3943_gpio *lg = to_lp3943_gpio(chip);
+ const struct lp3943_reg_cfg *mux = lg->l->mux_cfg;
+ u8 addr;
+ u8 mask;
+ u8 shift;
+ u8 data;
+
+ addr = mux[offset].reg;
+ mask = mux[offset].mask;
+ shift = mux[offset].shift;
+
+ if (value)
+ data = LP3943_GPIO_OUT_HIGH;
+ else
+ data = LP3943_GPIO_OUT_LOW;
+
+ lp3943_update_bits(lg->l, addr, mask, data << shift);
+}
+
+static int lp3943_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
+ int value)
+{
+ struct lp3943_gpio *lg = to_lp3943_gpio(chip);
+
+ lp3943_gpio_set(chip, offset, value);
+ lg->is_input[offset] = false;
+
+ return 0;
+}
+
+static const struct gpio_chip lp3943_gpio_chip = {
+ .label = "lp3943",
+ .owner = THIS_MODULE,
+ .direction_input = lp3943_gpio_direction_input,
+ .get = lp3943_gpio_get,
+ .direction_output = lp3943_gpio_direction_output,
+ .set = lp3943_gpio_set,
+ .base = -1,
+ .ngpio = LP3943_MAX_GPIO,
+ .can_sleep = 1,
+};
+
+static int lp3943_gpio_probe(struct platform_device *pdev)
+{
+ struct lp3943 *l = dev_get_drvdata(pdev->dev.parent);
+ struct lp3943_gpio *lg;
+ int ret;
+
+ lg = devm_kzalloc(&pdev->dev, sizeof(struct lp3943_gpio), GFP_KERNEL);
+ if (!lg)
+ return -ENOMEM;
+
+ lg->l = l;
+ lg->chip = lp3943_gpio_chip;
+ lg->chip.dev = &pdev->dev;
+
+ platform_set_drvdata(pdev, lg);
+
+ ret = gpiochip_add(&lg->chip);
+ if (ret < 0) {
+ dev_err(&pdev->dev, "failed to add GPIO chip, err:%d\n", ret);
+ return ret;
+ }
+
+ return 0;
+}
+
+static int lp3943_gpio_remove(struct platform_device *pdev)
+{
+ struct lp3943_gpio *lg = platform_get_drvdata(pdev);
+ return gpiochip_remove(&lg->chip);
+}
+
+static struct platform_driver lp3943_gpio_driver = {
+ .probe = lp3943_gpio_probe,
+ .remove = lp3943_gpio_remove,
+ .driver = {
+ .name = "lp3943-gpio",
+ .owner = THIS_MODULE,
+ },
+};
+module_platform_driver(lp3943_gpio_driver);
+
+MODULE_DESCRIPTION("LP3943 GPIO driver");
+MODULE_AUTHOR("Milo Kim");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:lp3943-gpio");
--
1.7.9.5
Best Regards,
Milo
On Tue, Jul 16, 2013 at 4:38 AM, Kim, Milo <[email protected]> wrote:
> +++ b/drivers/gpio/gpio-lp3943.c
> @@ -0,0 +1,224 @@
> +/*
> + * TI/National Semiconductor LP3943 GPIO driver
> + *
> + * Copyright (C) 2013 Texas Instruments
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 2.
> + */
> +
> +#include <linux/err.h>
> +#include <linux/gpio.h>
> +#include <linux/i2c.h>
> +#include <linux/mfd/lp3943.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/slab.h>
#include <linus/bitops.h>
> +#define to_lp3943_gpio(_chip) container_of(_chip, struct lp3943_gpio, chip)
> +
> +enum lp3943_gpios {
> + LP3943_GPIO1,
> + LP3943_GPIO2,
> + LP3943_GPIO3,
> + LP3943_GPIO4,
> + LP3943_GPIO5,
> + LP3943_GPIO6,
> + LP3943_GPIO7,
> + LP3943_GPIO8,
> + LP3943_GPIO9,
> + LP3943_GPIO10,
> + LP3943_GPIO11,
> + LP3943_GPIO12,
> + LP3943_GPIO13,
> + LP3943_GPIO14,
> + LP3943_GPIO15,
> + LP3943_GPIO16,
> + LP3943_MAX_GPIO,
> +};
> +
> +struct lp3943_gpio {
> + struct gpio_chip chip;
> + struct lp3943 *l;
> + bool is_input[LP3943_MAX_GPIO];
Please do this instead:
u16 is_input;
> +static int lp3943_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
> +{
> + struct lp3943_gpio *lg = to_lp3943_gpio(chip);
> + const struct lp3943_reg_cfg *mux = lg->l->mux_cfg;
> + u8 addr;
> + u8 mask;
> + u8 shift;
> +
> + lg->is_input[offset] = true;
So it would be:
lg->is_input |= BIT(offset);
> + addr = mux[offset].reg;
> + mask = mux[offset].mask;
> + shift = mux[offset].shift;
> +
> + return lp3943_update_bits(lg->l, addr, mask, LP3943_GPIO_IN << shift);
> +}
> +
> +static int lp3943_get_gpio_in_status(struct lp3943_gpio *lg,
> + struct gpio_chip *chip, unsigned offset)
> +{
> + u8 addr;
> + u8 read;
> + int err;
> +
> + switch (offset) {
> + case LP3943_GPIO1 ... LP3943_GPIO8:
> + addr = LP3943_REG_GPIO_A;
> + break;
> + case LP3943_GPIO9 ... LP3943_GPIO16:
> + addr = LP3943_REG_GPIO_B;
> + offset = offset - 8;
> + break;
> + default:
> + return -EINVAL;
> + }
> +
> + err = lp3943_read_byte(lg->l, addr, &read);
> + if (err)
> + return err;
> +
> + if (read & (1 << offset))
> + return 1;
> + else
> + return 0;
Just:
return !!(read & BIT(offset));
> +}
> +
> +static int lp3943_get_gpio_out_status(struct lp3943_gpio *lg,
> + struct gpio_chip *chip, unsigned offset)
> +{
> + const struct lp3943_reg_cfg *mux = lg->l->mux_cfg;
> + u8 addr = mux[offset].reg;
> + u8 mask = mux[offset].mask;
> + u8 shift = mux[offset].shift;
> + u8 read;
> + int err;
> +
> + err = lp3943_read_byte(lg->l, addr, &read);
> + if (err)
> + return err;
> +
> + read = (read & mask) >> shift;
> +
> + if (read == LP3943_GPIO_OUT_HIGH)
> + return 1;
> + else if (read == LP3943_GPIO_OUT_LOW)
> + return 0;
> + else
> + return -EINVAL;
> +}
> +
> +static int lp3943_gpio_get(struct gpio_chip *chip, unsigned offset)
> +{
> + struct lp3943_gpio *lg = to_lp3943_gpio(chip);
> +
> + /*
> + * Limitation:
> + * LP3943 doesn't have the GPIO direction register. It provides
> + * only input and output status registers.
> + * So, direction info is required to handle the 'get' operation.
> + * This variable is updated whenever the direction is changed and
> + * it is used here.
> + */
> +
> + if (lg->is_input[offset])
if (lg->is_input & BIT(offset))
> + return lp3943_get_gpio_in_status(lg, chip, offset);
> + else
> + return lp3943_get_gpio_out_status(lg, chip, offset);
> +}
> +
> +static void lp3943_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
> +{
> + struct lp3943_gpio *lg = to_lp3943_gpio(chip);
> + const struct lp3943_reg_cfg *mux = lg->l->mux_cfg;
> + u8 addr;
> + u8 mask;
> + u8 shift;
> + u8 data;
> +
> + addr = mux[offset].reg;
> + mask = mux[offset].mask;
> + shift = mux[offset].shift;
> +
> + if (value)
> + data = LP3943_GPIO_OUT_HIGH;
> + else
> + data = LP3943_GPIO_OUT_LOW;
> +
> + lp3943_update_bits(lg->l, addr, mask, data << shift);
> +}
> +
> +static int lp3943_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
> + int value)
> +{
> + struct lp3943_gpio *lg = to_lp3943_gpio(chip);
> +
> + lp3943_gpio_set(chip, offset, value);
> + lg->is_input[offset] = false;
lg->is_input &= ~BIT(offset);
> +
> + return 0;
> +}
> +
> +static const struct gpio_chip lp3943_gpio_chip = {
> + .label = "lp3943",
> + .owner = THIS_MODULE,
> + .direction_input = lp3943_gpio_direction_input,
> + .get = lp3943_gpio_get,
> + .direction_output = lp3943_gpio_direction_output,
> + .set = lp3943_gpio_set,
> + .base = -1,
> + .ngpio = LP3943_MAX_GPIO,
> + .can_sleep = 1,
> +};
> +
> +static int lp3943_gpio_probe(struct platform_device *pdev)
> +{
> + struct lp3943 *l = dev_get_drvdata(pdev->dev.parent);
> + struct lp3943_gpio *lg;
> + int ret;
> +
> + lg = devm_kzalloc(&pdev->dev, sizeof(struct lp3943_gpio), GFP_KERNEL);
> + if (!lg)
> + return -ENOMEM;
> +
> + lg->l = l;
> + lg->chip = lp3943_gpio_chip;
> + lg->chip.dev = &pdev->dev;
> +
> + platform_set_drvdata(pdev, lg);
> +
> + ret = gpiochip_add(&lg->chip);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "failed to add GPIO chip, err:%d\n", ret);
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static int lp3943_gpio_remove(struct platform_device *pdev)
> +{
> + struct lp3943_gpio *lg = platform_get_drvdata(pdev);
> + return gpiochip_remove(&lg->chip);
> +}
> +
> +static struct platform_driver lp3943_gpio_driver = {
> + .probe = lp3943_gpio_probe,
> + .remove = lp3943_gpio_remove,
> + .driver = {
> + .name = "lp3943-gpio",
> + .owner = THIS_MODULE,
> + },
No device tree probing support? Why?
Yours,
Linus Walleij
I forgot one thing:
On Tue, Jul 16, 2013 at 4:38 AM, Kim, Milo <[email protected]> wrote:
> +static int lp3943_gpio_probe(struct platform_device *pdev)
> +{
> + struct lp3943 *l = dev_get_drvdata(pdev->dev.parent);
> + struct lp3943_gpio *lg;
> + int ret;
This is where I want you to assign to a member of struct
lp3943 another u16 mask which tells which lines are
actually available for GPIO, and you should also add code to
make sure that lines that are not available fail gpio_request().
This configuration can probably be read out from the device
tree if you add the compatible node to the MFD cell when
registering it.
Yours,
Linus Walleij
Hi Linus,
Thanks for both of GPIO patch reviews.
I'll fix them.
> I forgot one thing:
>
> On Tue, Jul 16, 2013 at 4:38 AM, Kim, Milo <[email protected]> wrote:
>
> > +static int lp3943_gpio_probe(struct platform_device *pdev)
> > +{
> > + struct lp3943 *l = dev_get_drvdata(pdev->dev.parent);
> > + struct lp3943_gpio *lg;
> > + int ret;
>
> This is where I want you to assign to a member of struct
> lp3943 another u16 mask which tells which lines are
> actually available for GPIO, and you should also add code to
> make sure that lines that are not available fail gpio_request().
>
> This configuration can probably be read out from the device
> tree if you add the compatible node to the MFD cell when
> registering it.
>
> Yours,
> Linus Walleij
Regards,
Milo