2010-06-30 01:03:23

by Dave Airlie

[permalink] [raw]
Subject: [git pull] drm fixes + agp + one fb patch


Hi Linus,

one fb layer fix in a flag I introduced,

the rest are drm fixes:
radeon fixes: the larger ones in the command stream checker for older cards,
which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
along with some updates to the evergreen command stream checker introduced in -rc1.

agp: fix issue with warning on memory allocation + fallback to vmalloc.
ttm: fix regression introduced in -rc1 in memory allocation paths.

The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:

Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)

are available in the git repository at:
ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git drm-fixes

Adam Jackson (1):
drm/fb: Fix video= mode computation

Alex Deucher (7):
drm/radeon/kms: fix bandwidth calculation when sideport is present
drm/radeon/kms: fix DP after DPMS cycle
drm/radeon/kms: fix typo in evergreen_gpu_init
drm/radeon/kms: disable frac fb dividers for rs6xx
drm/radeon/kms: avoid oops on mac r4xx cards
drm/radeon/kms: fix typos in evergreen command checker
drm/radeon/kms: add some missing regs to evergreen gpu init

Cedric Godin (1):
drm/radeon/kms: fix dpms state on resume

Dave Airlie (7):
drm/radeon: fix dual-head on rv250
radeon/kms: fix powerpc/rn50 untiled behaviour.
agp: drop vmalloc flag.
agp: add no warn since we have a fallback to vmalloc paths
drm/radeon: add fake RN50 table for powerpc
drm/radeon/kms: don't read attempt to read bios from VRAM on unposted GPU.
fb: fix colliding defines for fb flags.

Jerome Glisse (2):
drm/ttm: non pooled page allocation should have GFP_USER set
drm/radeon/kms: Force HDP_NONSURF to maximum size

Matt Turner (1):
drm/radeon/kms: return ret in cursor_set failure path

Roland Scheidegger (3):
drm/radeon/kms: CS checker texture fixes for r1xx/r2xx/r3xx
drm/radeon/r200: handle more hw tex coord types
drm/radeon/r100/r200: fix calculation of compressed cube maps

drivers/char/agp/generic.c | 6 +-
drivers/gpu/drm/drm_fb_helper.c | 19 ++++--
drivers/gpu/drm/radeon/atombios_crtc.c | 2 +-
drivers/gpu/drm/radeon/evergreen.c | 35 ++++++++--
drivers/gpu/drm/radeon/evergreen_cs.c | 4 +-
drivers/gpu/drm/radeon/evergreend.h | 3 +
drivers/gpu/drm/radeon/r100.c | 81 +++++++++++++---------
drivers/gpu/drm/radeon/r200.c | 5 ++
drivers/gpu/drm/radeon/r300.c | 5 ++
drivers/gpu/drm/radeon/r600.c | 2 +-
drivers/gpu/drm/radeon/radeon_asic.c | 7 ++
drivers/gpu/drm/radeon/radeon_bios.c | 4 +
drivers/gpu/drm/radeon/radeon_combios.c | 32 +++++++++
drivers/gpu/drm/radeon/radeon_cursor.c | 2 +-
drivers/gpu/drm/radeon/radeon_device.c | 7 ++
drivers/gpu/drm/radeon/radeon_encoders.c | 4 +-
drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 22 +++----
drivers/gpu/drm/radeon/radeon_mode.h | 1 +
drivers/gpu/drm/radeon/reg_srcs/evergreen | 10 ++--
drivers/gpu/drm/radeon/rs690.c | 6 +--
drivers/gpu/drm/radeon/rv770.c | 2 +-
drivers/gpu/drm/ttm/ttm_page_alloc.c | 2 +-
include/linux/agp_backend.h | 1 -
include/linux/fb.h | 4 +-
24 files changed, 182 insertions(+), 84 deletions(-)


2010-06-30 04:42:26

by Rafał Miłecki

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch

2010/6/30 Dave Airlie <[email protected]>:
> Hi Linus,
>
> one fb layer fix in a flag I introduced,
>
> the rest are drm fixes:
> radeon fixes: the larger ones in the command stream checker for older cards,
> which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
> along with some updates to the evergreen command stream checker introduced in -rc1.
>
> agp: fix issue with warning on memory allocation + fallback to vmalloc.
> ttm: fix regression introduced in -rc1 in memory allocation paths.

Dave, could you queue
[PATCH] drm/radeon/kms/pm: fix power state indexing on igp chips in dynpm mode
for next (still .35) drm pull request?

It fixes FDO bug https://bugs.freedesktop.org/show_bug.cgi?id=28745 ,
div by zero which actually I consider a regression since:
1) In .34 I was able to use radeon.dynpm=1
2) In .35-rc div by zero + lockup on echo dynpm > /sys/devices/.../power_method

--
Rafał

2010-06-30 06:54:47

by Markus Trippelsdorf

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch

On Wed, Jun 30, 2010 at 02:03:04AM +0100, Dave Airlie wrote:
>
> Hi Linus,
>
> one fb layer fix in a flag I introduced,
>
> the rest are drm fixes:
> radeon fixes: the larger ones in the command stream checker for older cards,
> which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
> along with some updates to the evergreen command stream checker introduced in -rc1.
>
> agp: fix issue with warning on memory allocation + fallback to vmalloc.
> ttm: fix regression introduced in -rc1 in memory allocation paths.
>
> The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
>
> Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
>

I've tested these patches and they break my setup (RS780). On reboot, the
monitor goes straight to powersaving mode and no framebuffer is shown.

--
Markus

2010-06-30 07:31:52

by Markus Trippelsdorf

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch (bisected)

On Wed, Jun 30, 2010 at 08:54:40AM +0200, Markus Trippelsdorf wrote:
> On Wed, Jun 30, 2010 at 02:03:04AM +0100, Dave Airlie wrote:
> >
> > one fb layer fix in a flag I introduced,
> >
> > the rest are drm fixes:
> > radeon fixes: the larger ones in the command stream checker for older cards,
> > which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
> > along with some updates to the evergreen command stream checker introduced in -rc1.
> >
> > agp: fix issue with warning on memory allocation + fallback to vmalloc.
> > ttm: fix regression introduced in -rc1 in memory allocation paths.
> >
> > The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
> >
> > Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
> >
>
> I've tested these patches and they break my setup (RS780). On reboot, the
> monitor goes straight to powersaving mode and no framebuffer is shown.

This is the result of the bisection:

07d4190327b02ab3aaad25a2d168f79d92e8f8c2 is the first bad commit
commit 07d4190327b02ab3aaad25a2d168f79d92e8f8c2
Author: Alex Deucher <[email protected]>
Date: Sat Jun 12 11:50:13 2010 -0400

drm/radeon/kms: fix bandwidth calculation when sideport is present

Fixes fdo bug 27529:
https://bugs.freedesktop.org/show_bug.cgi?id=27529

Reported-by: [email protected]
Signed-off-by: Alex Deucher <[email protected]>
Cc: stable <[email protected]>
Signed-off-by: Dave Airlie <[email protected]>

--
Markus

2010-06-30 07:57:11

by Dave Airlie

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch

On Wed, Jun 30, 2010 at 4:54 PM, Markus Trippelsdorf
<[email protected]> wrote:
> On Wed, Jun 30, 2010 at 02:03:04AM +0100, Dave Airlie wrote:
>>
>> Hi Linus,
>>
>> one fb layer fix in a flag I introduced,
>>
>> the rest are drm fixes:
>> radeon fixes: the larger ones in the command stream checker for older cards,
>> which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
>> along with some updates to the evergreen command stream checker introduced in -rc1.
>>
>> agp: fix issue with warning on memory allocation + fallback to vmalloc.
>> ttm: fix regression introduced in -rc1 in memory allocation paths.
>>
>> The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
>>
>> ? Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
>>
>
> I've tested these patches and they break my setup (RS780). On reboot, the
> monitor goes straight to powersaving mode and no framebuffer is shown.

Can you bisect which one does it? 2.6.35-rc3 works okay?

Dave.

2010-06-30 08:00:35

by Dave Airlie

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch

On Wed, Jun 30, 2010 at 5:57 PM, Dave Airlie <[email protected]> wrote:
> On Wed, Jun 30, 2010 at 4:54 PM, Markus Trippelsdorf
> <[email protected]> wrote:
>> On Wed, Jun 30, 2010 at 02:03:04AM +0100, Dave Airlie wrote:
>>>
>>> Hi Linus,
>>>
>>> one fb layer fix in a flag I introduced,
>>>
>>> the rest are drm fixes:
>>> radeon fixes: the larger ones in the command stream checker for older cards,
>>> which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
>>> along with some updates to the evergreen command stream checker introduced in -rc1.
>>>
>>> agp: fix issue with warning on memory allocation + fallback to vmalloc.
>>> ttm: fix regression introduced in -rc1 in memory allocation paths.
>>>
>>> The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
>>>
>>> ? Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
>>>
>>
>> I've tested these patches and they break my setup (RS780). On reboot, the
>> monitor goes straight to powersaving mode and no framebuffer is shown.
>
> ?Can you bisect which one does it? 2.6.35-rc3 works okay?

first guess is 6d35ce0a468b8098c22ca54b4e222c27e364f9bb
then 8ed219f50c943a21a0b4f545876b58a344a28f45
then d2c1736971e3cc3b5315d034424a872dc5f44f4a

Dave.

>
> Dave.
>

2010-06-30 08:03:56

by Markus Trippelsdorf

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch

On Wed, Jun 30, 2010 at 06:00:32PM +1000, Dave Airlie wrote:
> On Wed, Jun 30, 2010 at 5:57 PM, Dave Airlie <[email protected]> wrote:
> > On Wed, Jun 30, 2010 at 4:54 PM, Markus Trippelsdorf
> > <[email protected]> wrote:
> >> On Wed, Jun 30, 2010 at 02:03:04AM +0100, Dave Airlie wrote:
> >>>
> >>> Hi Linus,
> >>>
> >>> one fb layer fix in a flag I introduced,
> >>>
> >>> the rest are drm fixes:
> >>> radeon fixes: the larger ones in the command stream checker for older cards,
> >>> which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
> >>> along with some updates to the evergreen command stream checker introduced in -rc1.
> >>>
> >>> agp: fix issue with warning on memory allocation + fallback to vmalloc.
> >>> ttm: fix regression introduced in -rc1 in memory allocation paths.
> >>>
> >>> The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
> >>>
> >>> ? Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
> >>>
> >>
> >> I've tested these patches and they break my setup (RS780). On reboot, the
> >> monitor goes straight to powersaving mode and no framebuffer is shown.
> >
> > ?Can you bisect which one does it? 2.6.35-rc3 works okay?
>
> first guess is 6d35ce0a468b8098c22ca54b4e222c27e364f9bb
> then 8ed219f50c943a21a0b4f545876b58a344a28f45
> then d2c1736971e3cc3b5315d034424a872dc5f44f4a

It's 07d4190327b02ab3aaad25a2d168f79d92e8f8c2 :-)
see my other email.

--
Markus

2010-06-30 09:22:26

by Dave Airlie

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch (bisected)

On Wed, Jun 30, 2010 at 5:31 PM, Markus Trippelsdorf
<[email protected]> wrote:
> On Wed, Jun 30, 2010 at 08:54:40AM +0200, Markus Trippelsdorf wrote:
>> On Wed, Jun 30, 2010 at 02:03:04AM +0100, Dave Airlie wrote:
>> >
>> > one fb layer fix in a flag I introduced,
>> >
>> > the rest are drm fixes:
>> > radeon fixes: the larger ones in the command stream checker for older cards,
>> > which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
>> > along with some updates to the evergreen command stream checker introduced in -rc1.
>> >
>> > agp: fix issue with warning on memory allocation + fallback to vmalloc.
>> > ttm: fix regression introduced in -rc1 in memory allocation paths.
>> >
>> > The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
>> >
>> > ? Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
>> >
>>
>> I've tested these patches and they break my setup (RS780). On reboot, the
>> monitor goes straight to powersaving mode and no framebuffer is shown.
>
> This is the result of the bisection:
>
> 07d4190327b02ab3aaad25a2d168f79d92e8f8c2 is the first bad commit
> commit 07d4190327b02ab3aaad25a2d168f79d92e8f8c2
> Author: Alex Deucher <[email protected]>
> Date: ? Sat Jun 12 11:50:13 2010 -0400
>
> ? ?drm/radeon/kms: fix bandwidth calculation when sideport is present
>
> ? ?Fixes fdo bug 27529:
> ? ?https://bugs.freedesktop.org/show_bug.cgi?id=27529
>
> ? ?Reported-by: [email protected]
> ? ?Signed-off-by: Alex Deucher <[email protected]>
> ? ?Cc: stable <[email protected]>
> ? ?Signed-off-by: Dave Airlie <[email protected]>
>

Okay Linus, hold off on pulling this, and I'll revert it in the
morning when I get back to my tree and resend the pull.

Maybe Alex will have time to figure out whats gone wrong overnight.

Dave.

2010-06-30 10:14:37

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch

On Wednesday, June 30, 2010, Dave Airlie wrote:
>
> Hi Linus,
>
> one fb layer fix in a flag I introduced,
>
> the rest are drm fixes:
> radeon fixes: the larger ones in the command stream checker for older cards,
> which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
> along with some updates to the evergreen command stream checker introduced in -rc1.
>
> agp: fix issue with warning on memory allocation + fallback to vmalloc.
> ttm: fix regression introduced in -rc1 in memory allocation paths.
>
> The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
>
> Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
>
> are available in the git repository at:
> ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git drm-fixes
>
> Adam Jackson (1):
> drm/fb: Fix video= mode computation
>
> Alex Deucher (7):
> drm/radeon/kms: fix bandwidth calculation when sideport is present
> drm/radeon/kms: fix DP after DPMS cycle
> drm/radeon/kms: fix typo in evergreen_gpu_init
> drm/radeon/kms: disable frac fb dividers for rs6xx
> drm/radeon/kms: avoid oops on mac r4xx cards
> drm/radeon/kms: fix typos in evergreen command checker
> drm/radeon/kms: add some missing regs to evergreen gpu init
>
> Cedric Godin (1):
> drm/radeon/kms: fix dpms state on resume
>
> Dave Airlie (7):
> drm/radeon: fix dual-head on rv250
> radeon/kms: fix powerpc/rn50 untiled behaviour.
> agp: drop vmalloc flag.
> agp: add no warn since we have a fallback to vmalloc paths
> drm/radeon: add fake RN50 table for powerpc
> drm/radeon/kms: don't read attempt to read bios from VRAM on unposted GPU.
> fb: fix colliding defines for fb flags.
>
> Jerome Glisse (2):
> drm/ttm: non pooled page allocation should have GFP_USER set
> drm/radeon/kms: Force HDP_NONSURF to maximum size
>
> Matt Turner (1):
> drm/radeon/kms: return ret in cursor_set failure path
>
> Roland Scheidegger (3):
> drm/radeon/kms: CS checker texture fixes for r1xx/r2xx/r3xx
> drm/radeon/r200: handle more hw tex coord types
> drm/radeon/r100/r200: fix calculation of compressed cube maps

Hmm. What about:

https://patchwork.kernel.org/patch/106757/ ?

It fixes a regression from 2.6.34.

Rafael

2010-06-30 14:49:44

by Alex Deucher

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch (bisected)

On Wed, Jun 30, 2010 at 3:31 AM, Markus Trippelsdorf
<[email protected]> wrote:
> On Wed, Jun 30, 2010 at 08:54:40AM +0200, Markus Trippelsdorf wrote:
>> On Wed, Jun 30, 2010 at 02:03:04AM +0100, Dave Airlie wrote:
>> >
>> > one fb layer fix in a flag I introduced,
>> >
>> > the rest are drm fixes:
>> > radeon fixes: the larger ones in the command stream checker for older cards,
>> > which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
>> > along with some updates to the evergreen command stream checker introduced in -rc1.
>> >
>> > agp: fix issue with warning on memory allocation + fallback to vmalloc.
>> > ttm: fix regression introduced in -rc1 in memory allocation paths.
>> >
>> > The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
>> >
>> > ? Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
>> >
>>
>> I've tested these patches and they break my setup (RS780). On reboot, the
>> monitor goes straight to powersaving mode and no framebuffer is shown.
>
> This is the result of the bisection:
>
> 07d4190327b02ab3aaad25a2d168f79d92e8f8c2 is the first bad commit
> commit 07d4190327b02ab3aaad25a2d168f79d92e8f8c2
> Author: Alex Deucher <[email protected]>
> Date: ? Sat Jun 12 11:50:13 2010 -0400
>
> ? ?drm/radeon/kms: fix bandwidth calculation when sideport is present
>
> ? ?Fixes fdo bug 27529:
> ? ?https://bugs.freedesktop.org/show_bug.cgi?id=27529
>
> ? ?Reported-by: [email protected]
> ? ?Signed-off-by: Alex Deucher <[email protected]>
> ? ?Cc: stable <[email protected]>
> ? ?Signed-off-by: Dave Airlie <[email protected]>

Markus, can you send me a copy of your vbios? as root:
cd /sys/bus/pci/devices/<pci bus id of video card>
echo 1 > rom
cat rom ? /tmp/vbio.rom
echo 0 > rom

Also, when you say "on reboot" do you mean the card comes up ok
initially with the new kernel and then fails after a reboot, or fails
directly after booting the new kernel? Also, is there an oops or
anything like that in dmesg?

Thanks,

Alex

2010-06-30 14:59:08

by Markus Trippelsdorf

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch (bisected)

On Wed, Jun 30, 2010 at 10:49:41AM -0400, Alex Deucher wrote:
> On Wed, Jun 30, 2010 at 3:31 AM, Markus Trippelsdorf
> <[email protected]> wrote:
> > On Wed, Jun 30, 2010 at 08:54:40AM +0200, Markus Trippelsdorf wrote:
> >> On Wed, Jun 30, 2010 at 02:03:04AM +0100, Dave Airlie wrote:
> >> >
> >> > one fb layer fix in a flag I introduced,
> >> >
> >> > the rest are drm fixes:
> >> > radeon fixes: the larger ones in the command stream checker for older cards,
> >> > which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
> >> > along with some updates to the evergreen command stream checker introduced in -rc1.
> >> >
> >> > agp: fix issue with warning on memory allocation + fallback to vmalloc.
> >> > ttm: fix regression introduced in -rc1 in memory allocation paths.
> >> >
> >> > The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
> >> >
> >> > ? Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
> >> >
> >>
> >> I've tested these patches and they break my setup (RS780). On reboot, the
> >> monitor goes straight to powersaving mode and no framebuffer is shown.
> >
> > This is the result of the bisection:
> >
> > 07d4190327b02ab3aaad25a2d168f79d92e8f8c2 is the first bad commit
> > commit 07d4190327b02ab3aaad25a2d168f79d92e8f8c2
> > Author: Alex Deucher <[email protected]>
> > Date: ? Sat Jun 12 11:50:13 2010 -0400
> >
> > ? ?drm/radeon/kms: fix bandwidth calculation when sideport is present
> >
> > ? ?Fixes fdo bug 27529:
> > ? ?https://bugs.freedesktop.org/show_bug.cgi?id=27529
> >
> > ? ?Reported-by: [email protected]
> > ? ?Signed-off-by: Alex Deucher <[email protected]>
> > ? ?Cc: stable <[email protected]>
> > ? ?Signed-off-by: Dave Airlie <[email protected]>
>
> Markus, can you send me a copy of your vbios? as root:
> cd /sys/bus/pci/devices/<pci bus id of video card>
> echo 1 > rom
> cat rom ? /tmp/vbio.rom
> echo 0 > rom

Attached.

>
> Also, when you say "on reboot" do you mean the card comes up ok
> initially with the new kernel and then fails after a reboot, or fails
> directly after booting the new kernel? Also, is there an oops or
> anything like that in dmesg?

It fails directly after booting the new kernel. There is no oops or
anything like it in dmesg, because the kernel fails so early that it
could not log anything.

--
Markus


Attachments:
(No filename) (2.29 kB)
vbio.rom (58.50 kB)
Download all attachments

2010-06-30 15:03:36

by Alex Deucher

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch (bisected)

On Wed, Jun 30, 2010 at 10:58 AM, Markus Trippelsdorf
<[email protected]> wrote:
> On Wed, Jun 30, 2010 at 10:49:41AM -0400, Alex Deucher wrote:
>> On Wed, Jun 30, 2010 at 3:31 AM, Markus Trippelsdorf
>> <[email protected]> wrote:
>> > On Wed, Jun 30, 2010 at 08:54:40AM +0200, Markus Trippelsdorf wrote:
>> >> On Wed, Jun 30, 2010 at 02:03:04AM +0100, Dave Airlie wrote:
>> >> >
>> >> > one fb layer fix in a flag I introduced,
>> >> >
>> >> > the rest are drm fixes:
>> >> > radeon fixes: the larger ones in the command stream checker for older cards,
>> >> > which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
>> >> > along with some updates to the evergreen command stream checker introduced in -rc1.
>> >> >
>> >> > agp: fix issue with warning on memory allocation + fallback to vmalloc.
>> >> > ttm: fix regression introduced in -rc1 in memory allocation paths.
>> >> >
>> >> > The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
>> >> >
>> >> > ? Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
>> >> >
>> >>
>> >> I've tested these patches and they break my setup (RS780). On reboot, the
>> >> monitor goes straight to powersaving mode and no framebuffer is shown.
>> >
>> > This is the result of the bisection:
>> >
>> > 07d4190327b02ab3aaad25a2d168f79d92e8f8c2 is the first bad commit
>> > commit 07d4190327b02ab3aaad25a2d168f79d92e8f8c2
>> > Author: Alex Deucher <[email protected]>
>> > Date: ? Sat Jun 12 11:50:13 2010 -0400
>> >
>> > ? ?drm/radeon/kms: fix bandwidth calculation when sideport is present
>> >
>> > ? ?Fixes fdo bug 27529:
>> > ? ?https://bugs.freedesktop.org/show_bug.cgi?id=27529
>> >
>> > ? ?Reported-by: [email protected]
>> > ? ?Signed-off-by: Alex Deucher <[email protected]>
>> > ? ?Cc: stable <[email protected]>
>> > ? ?Signed-off-by: Dave Airlie <[email protected]>
>>
>> Markus, can you send me a copy of your vbios? as root:
>> cd /sys/bus/pci/devices/<pci bus id of video card>
>> echo 1 > rom
>> cat rom ? /tmp/vbio.rom
>> echo 0 > rom
>
> Attached.
>
>>
>> Also, when you say "on reboot" do you mean the card comes up ok
>> initially with the new kernel and then fails after a reboot, or fails
>> directly after booting the new kernel? ?Also, is there an oops or
>> anything like that in dmesg?
>
> It fails directly after booting the new kernel. There is no oops or
> anything like it in dmesg, because the kernel fails so early that it
> could not log anything.

Is the machine still pingable? Can you ssh in? or is it completely dead?

Alex

2010-06-30 15:14:54

by Markus Trippelsdorf

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch (bisected)

On Wed, Jun 30, 2010 at 11:03:33AM -0400, Alex Deucher wrote:
> On Wed, Jun 30, 2010 at 10:58 AM, Markus Trippelsdorf
> <[email protected]> wrote:
> > On Wed, Jun 30, 2010 at 10:49:41AM -0400, Alex Deucher wrote:
> >> On Wed, Jun 30, 2010 at 3:31 AM, Markus Trippelsdorf
> >> <[email protected]> wrote:
> >> > On Wed, Jun 30, 2010 at 08:54:40AM +0200, Markus Trippelsdorf wrote:
> >> >> On Wed, Jun 30, 2010 at 02:03:04AM +0100, Dave Airlie wrote:
> >> >> >
> >> >> > one fb layer fix in a flag I introduced,
> >> >> >
> >> >> > the rest are drm fixes:
> >> >> > radeon fixes: the larger ones in the command stream checker for older cards,
> >> >> > which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
> >> >> > along with some updates to the evergreen command stream checker introduced in -rc1.
> >> >> >
> >> >> > agp: fix issue with warning on memory allocation + fallback to vmalloc.
> >> >> > ttm: fix regression introduced in -rc1 in memory allocation paths.
> >> >> >
> >> >> > The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
> >> >> >
> >> >> > ? Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
> >> >> >
> >> >>
> >> >> I've tested these patches and they break my setup (RS780). On reboot, the
> >> >> monitor goes straight to powersaving mode and no framebuffer is shown.
> >> >
> >> > This is the result of the bisection:
> >> >
> >> > 07d4190327b02ab3aaad25a2d168f79d92e8f8c2 is the first bad commit
> >> > commit 07d4190327b02ab3aaad25a2d168f79d92e8f8c2
> >> > Author: Alex Deucher <[email protected]>
> >> > Date: ? Sat Jun 12 11:50:13 2010 -0400
> >> >
> >> > ? ?drm/radeon/kms: fix bandwidth calculation when sideport is present
> >> >
> >> > ? ?Fixes fdo bug 27529:
> >> > ? ?https://bugs.freedesktop.org/show_bug.cgi?id=27529
> >> >
> >> > ? ?Reported-by: [email protected]
> >> > ? ?Signed-off-by: Alex Deucher <[email protected]>
> >> > ? ?Cc: stable <[email protected]>
> >> > ? ?Signed-off-by: Dave Airlie <[email protected]>
> >>
> >> Markus, can you send me a copy of your vbios? as root:
> >> cd /sys/bus/pci/devices/<pci bus id of video card>
> >> echo 1 > rom
> >> cat rom ? /tmp/vbio.rom
> >> echo 0 > rom
> >
> > Attached.
> >
> >>
> >> Also, when you say "on reboot" do you mean the card comes up ok
> >> initially with the new kernel and then fails after a reboot, or fails
> >> directly after booting the new kernel? ?Also, is there an oops or
> >> anything like that in dmesg?
> >
> > It fails directly after booting the new kernel. There is no oops or
> > anything like it in dmesg, because the kernel fails so early that it
> > could not log anything.
>
> Is the machine still pingable? Can you ssh in? or is it completely dead?

I don't think so. There is no disk activivy after the hang, but maybe
the kernel displays an oops, which I just can't see.

--
Markus

2010-06-30 15:16:43

by Alex Deucher

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch (bisected)

On Wed, Jun 30, 2010 at 11:14 AM, Markus Trippelsdorf
<[email protected]> wrote:
> On Wed, Jun 30, 2010 at 11:03:33AM -0400, Alex Deucher wrote:
>> On Wed, Jun 30, 2010 at 10:58 AM, Markus Trippelsdorf
>> <[email protected]> wrote:
>> > On Wed, Jun 30, 2010 at 10:49:41AM -0400, Alex Deucher wrote:
>> >> On Wed, Jun 30, 2010 at 3:31 AM, Markus Trippelsdorf
>> >> <[email protected]> wrote:
>> >> > On Wed, Jun 30, 2010 at 08:54:40AM +0200, Markus Trippelsdorf wrote:
>> >> >> On Wed, Jun 30, 2010 at 02:03:04AM +0100, Dave Airlie wrote:
>> >> >> >
>> >> >> > one fb layer fix in a flag I introduced,
>> >> >> >
>> >> >> > the rest are drm fixes:
>> >> >> > radeon fixes: the larger ones in the command stream checker for older cards,
>> >> >> > which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
>> >> >> > along with some updates to the evergreen command stream checker introduced in -rc1.
>> >> >> >
>> >> >> > agp: fix issue with warning on memory allocation + fallback to vmalloc.
>> >> >> > ttm: fix regression introduced in -rc1 in memory allocation paths.
>> >> >> >
>> >> >> > The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
>> >> >> >
>> >> >> > ? Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
>> >> >> >
>> >> >>
>> >> >> I've tested these patches and they break my setup (RS780). On reboot, the
>> >> >> monitor goes straight to powersaving mode and no framebuffer is shown.
>> >> >
>> >> > This is the result of the bisection:
>> >> >
>> >> > 07d4190327b02ab3aaad25a2d168f79d92e8f8c2 is the first bad commit
>> >> > commit 07d4190327b02ab3aaad25a2d168f79d92e8f8c2
>> >> > Author: Alex Deucher <[email protected]>
>> >> > Date: ? Sat Jun 12 11:50:13 2010 -0400
>> >> >
>> >> > ? ?drm/radeon/kms: fix bandwidth calculation when sideport is present
>> >> >
>> >> > ? ?Fixes fdo bug 27529:
>> >> > ? ?https://bugs.freedesktop.org/show_bug.cgi?id=27529
>> >> >
>> >> > ? ?Reported-by: [email protected]
>> >> > ? ?Signed-off-by: Alex Deucher <[email protected]>
>> >> > ? ?Cc: stable <[email protected]>
>> >> > ? ?Signed-off-by: Dave Airlie <[email protected]>
>> >>
>> >> Markus, can you send me a copy of your vbios? as root:
>> >> cd /sys/bus/pci/devices/<pci bus id of video card>
>> >> echo 1 > rom
>> >> cat rom ? /tmp/vbio.rom
>> >> echo 0 > rom
>> >
>> > Attached.
>> >
>> >>
>> >> Also, when you say "on reboot" do you mean the card comes up ok
>> >> initially with the new kernel and then fails after a reboot, or fails
>> >> directly after booting the new kernel? ?Also, is there an oops or
>> >> anything like that in dmesg?
>> >
>> > It fails directly after booting the new kernel. There is no oops or
>> > anything like it in dmesg, because the kernel fails so early that it
>> > could not log anything.
>>
>> Is the machine still pingable? ?Can you ssh in? or is it completely dead?
>
> I don't think so. There is no disk activivy after the hang, but maybe
> the kernel displays an oops, which I just can't see.

I found the problem. Patch on the way.

Alex

2010-06-30 15:34:56

by Alex Deucher

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch (bisected)

On Wed, Jun 30, 2010 at 11:14 AM, Markus Trippelsdorf
<[email protected]> wrote:
> On Wed, Jun 30, 2010 at 11:03:33AM -0400, Alex Deucher wrote:
>> On Wed, Jun 30, 2010 at 10:58 AM, Markus Trippelsdorf
>> <[email protected]> wrote:
>> > On Wed, Jun 30, 2010 at 10:49:41AM -0400, Alex Deucher wrote:
>> >> On Wed, Jun 30, 2010 at 3:31 AM, Markus Trippelsdorf
>> >> <[email protected]> wrote:
>> >> > On Wed, Jun 30, 2010 at 08:54:40AM +0200, Markus Trippelsdorf wrote:
>> >> >> On Wed, Jun 30, 2010 at 02:03:04AM +0100, Dave Airlie wrote:
>> >> >> >
>> >> >> > one fb layer fix in a flag I introduced,
>> >> >> >
>> >> >> > the rest are drm fixes:
>> >> >> > radeon fixes: the larger ones in the command stream checker for older cards,
>> >> >> > which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
>> >> >> > along with some updates to the evergreen command stream checker introduced in -rc1.
>> >> >> >
>> >> >> > agp: fix issue with warning on memory allocation + fallback to vmalloc.
>> >> >> > ttm: fix regression introduced in -rc1 in memory allocation paths.
>> >> >> >
>> >> >> > The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
>> >> >> >
>> >> >> > ? Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
>> >> >> >
>> >> >>
>> >> >> I've tested these patches and they break my setup (RS780). On reboot, the
>> >> >> monitor goes straight to powersaving mode and no framebuffer is shown.
>> >> >
>> >> > This is the result of the bisection:
>> >> >
>> >> > 07d4190327b02ab3aaad25a2d168f79d92e8f8c2 is the first bad commit
>> >> > commit 07d4190327b02ab3aaad25a2d168f79d92e8f8c2
>> >> > Author: Alex Deucher <[email protected]>
>> >> > Date: ? Sat Jun 12 11:50:13 2010 -0400
>> >> >
>> >> > ? ?drm/radeon/kms: fix bandwidth calculation when sideport is present
>> >> >
>> >> > ? ?Fixes fdo bug 27529:
>> >> > ? ?https://bugs.freedesktop.org/show_bug.cgi?id=27529
>> >> >
>> >> > ? ?Reported-by: [email protected]
>> >> > ? ?Signed-off-by: Alex Deucher <[email protected]>
>> >> > ? ?Cc: stable <[email protected]>
>> >> > ? ?Signed-off-by: Dave Airlie <[email protected]>
>> >>
>> >> Markus, can you send me a copy of your vbios? as root:
>> >> cd /sys/bus/pci/devices/<pci bus id of video card>
>> >> echo 1 > rom
>> >> cat rom ? /tmp/vbio.rom
>> >> echo 0 > rom
>> >
>> > Attached.
>> >
>> >>
>> >> Also, when you say "on reboot" do you mean the card comes up ok
>> >> initially with the new kernel and then fails after a reboot, or fails
>> >> directly after booting the new kernel? ?Also, is there an oops or
>> >> anything like that in dmesg?
>> >
>> > It fails directly after booting the new kernel. There is no oops or
>> > anything like it in dmesg, because the kernel fails so early that it
>> > could not log anything.
>>
>> Is the machine still pingable? ?Can you ssh in? or is it completely dead?
>
> I don't think so. There is no disk activivy after the hang, but maybe
> the kernel displays an oops, which I just can't see.

The attached patch should fix the issue.

Alex


Attachments:
0001-drm-radeon-kms-igp-fix-possible-divide-by-0-in-bandw.patch (4.04 kB)

2010-06-30 15:45:57

by Alex Deucher

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch

On Wed, Jun 30, 2010 at 6:13 AM, Rafael J. Wysocki <[email protected]> wrote:
> On Wednesday, June 30, 2010, Dave Airlie wrote:
>>
>> Hi Linus,
>>
>> one fb layer fix in a flag I introduced,
>>
>> the rest are drm fixes:
>> radeon fixes: the larger ones in the command stream checker for older cards,
>> which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
>> along with some updates to the evergreen command stream checker introduced in -rc1.
>>
>> agp: fix issue with warning on memory allocation + fallback to vmalloc.
>> ttm: fix regression introduced in -rc1 in memory allocation paths.
>>
>> The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
>>
>> ? Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
>>
>> are available in the git repository at:
>> ? ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git drm-fixes
>>
>> Adam Jackson (1):
>> ? ? ? drm/fb: Fix video= mode computation
>>
>> Alex Deucher (7):
>> ? ? ? drm/radeon/kms: fix bandwidth calculation when sideport is present
>> ? ? ? drm/radeon/kms: fix DP after DPMS cycle
>> ? ? ? drm/radeon/kms: fix typo in evergreen_gpu_init
>> ? ? ? drm/radeon/kms: disable frac fb dividers for rs6xx
>> ? ? ? drm/radeon/kms: avoid oops on mac r4xx cards
>> ? ? ? drm/radeon/kms: fix typos in evergreen command checker
>> ? ? ? drm/radeon/kms: add some missing regs to evergreen gpu init
>>
>> Cedric Godin (1):
>> ? ? ? drm/radeon/kms: fix dpms state on resume
>>
>> Dave Airlie (7):
>> ? ? ? drm/radeon: fix dual-head on rv250
>> ? ? ? radeon/kms: fix powerpc/rn50 untiled behaviour.
>> ? ? ? agp: drop vmalloc flag.
>> ? ? ? agp: add no warn since we have a fallback to vmalloc paths
>> ? ? ? drm/radeon: add fake RN50 table for powerpc
>> ? ? ? drm/radeon/kms: don't read attempt to read bios from VRAM on unposted GPU.
>> ? ? ? fb: fix colliding defines for fb flags.
>>
>> Jerome Glisse (2):
>> ? ? ? drm/ttm: non pooled page allocation should have GFP_USER set
>> ? ? ? drm/radeon/kms: Force HDP_NONSURF to maximum size
>>
>> Matt Turner (1):
>> ? ? ? drm/radeon/kms: return ret in cursor_set failure path
>>
>> Roland Scheidegger (3):
>> ? ? ? drm/radeon/kms: CS checker texture fixes for r1xx/r2xx/r3xx
>> ? ? ? drm/radeon/r200: handle more hw tex coord types
>> ? ? ? drm/radeon/r100/r200: fix calculation of compressed cube maps
>
> Hmm. ?What about:
>
> https://patchwork.kernel.org/patch/106757/ ?
>
> It fixes a regression from 2.6.34.

This patch should definitely go in as well.

Alex

2010-06-30 15:50:17

by Markus Trippelsdorf

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch (bisected)

On Wed, Jun 30, 2010 at 11:34:53AM -0400, Alex Deucher wrote:
> On Wed, Jun 30, 2010 at 11:14 AM, Markus Trippelsdorf
> <[email protected]> wrote:
> > On Wed, Jun 30, 2010 at 11:03:33AM -0400, Alex Deucher wrote:
> >> On Wed, Jun 30, 2010 at 10:58 AM, Markus Trippelsdorf
> >> <[email protected]> wrote:
> >> > On Wed, Jun 30, 2010 at 10:49:41AM -0400, Alex Deucher wrote:
> >> >> On Wed, Jun 30, 2010 at 3:31 AM, Markus Trippelsdorf
> >> >> <[email protected]> wrote:
> >> >> > On Wed, Jun 30, 2010 at 08:54:40AM +0200, Markus Trippelsdorf wrote:
> >> >> >> On Wed, Jun 30, 2010 at 02:03:04AM +0100, Dave Airlie wrote:
> >> >> >> >
> >> >> >> > one fb layer fix in a flag I introduced,
> >> >> >> >
> >> >> >> > the rest are drm fixes:
> >> >> >> > radeon fixes: the larger ones in the command stream checker for older cards,
> >> >> >> > which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
> >> >> >> > along with some updates to the evergreen command stream checker introduced in -rc1.
> >> >> >> >
> >> >> >> > agp: fix issue with warning on memory allocation + fallback to vmalloc.
> >> >> >> > ttm: fix regression introduced in -rc1 in memory allocation paths.
> >> >> >> >
> >> >> >> > The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
> >> >> >> >
> >> >> >> > ? Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
> >> >> >> >
> >> >> >>
> >> >> >> I've tested these patches and they break my setup (RS780). On reboot, the
> >> >> >> monitor goes straight to powersaving mode and no framebuffer is shown.
> >> >> >
> >> >> > This is the result of the bisection:
> >> >> >
> >> >> > 07d4190327b02ab3aaad25a2d168f79d92e8f8c2 is the first bad commit
> >> >> > commit 07d4190327b02ab3aaad25a2d168f79d92e8f8c2
> >> >> > Author: Alex Deucher <[email protected]>
> >> >> > Date: ? Sat Jun 12 11:50:13 2010 -0400
> >> >> >
> >> >> > ? ?drm/radeon/kms: fix bandwidth calculation when sideport is present
> >> >> >
> >> >> > ? ?Fixes fdo bug 27529:
> >> >> > ? ?https://bugs.freedesktop.org/show_bug.cgi?id=27529
> >> >> >
> >> >> > ? ?Reported-by: [email protected]
> >> >> > ? ?Signed-off-by: Alex Deucher <[email protected]>
> >> >> > ? ?Cc: stable <[email protected]>
> >> >> > ? ?Signed-off-by: Dave Airlie <[email protected]>
> >> >>
> >> >> Markus, can you send me a copy of your vbios? as root:
> >> >> cd /sys/bus/pci/devices/<pci bus id of video card>
> >> >> echo 1 > rom
> >> >> cat rom ? /tmp/vbio.rom
> >> >> echo 0 > rom
> >> >
> >> > Attached.
> >> >
> >> >>
> >> >> Also, when you say "on reboot" do you mean the card comes up ok
> >> >> initially with the new kernel and then fails after a reboot, or fails
> >> >> directly after booting the new kernel? ?Also, is there an oops or
> >> >> anything like that in dmesg?
> >> >
> >> > It fails directly after booting the new kernel. There is no oops or
> >> > anything like it in dmesg, because the kernel fails so early that it
> >> > could not log anything.
> >>
> >> Is the machine still pingable? ?Can you ssh in? or is it completely dead?
> >
> > I don't think so. There is no disk activivy after the hang, but maybe
> > the kernel displays an oops, which I just can't see.
>
> The attached patch should fix the issue.

Sorry, but it does not. I've still the same issue with your patch
applied.
--
Markus

2010-06-30 16:04:40

by Alex Deucher

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch (bisected)

On Wed, Jun 30, 2010 at 11:50 AM, Markus Trippelsdorf
<[email protected]> wrote:
> On Wed, Jun 30, 2010 at 11:34:53AM -0400, Alex Deucher wrote:
>> On Wed, Jun 30, 2010 at 11:14 AM, Markus Trippelsdorf
>> <[email protected]> wrote:
>> > On Wed, Jun 30, 2010 at 11:03:33AM -0400, Alex Deucher wrote:
>> >> On Wed, Jun 30, 2010 at 10:58 AM, Markus Trippelsdorf
>> >> <[email protected]> wrote:
>> >> > On Wed, Jun 30, 2010 at 10:49:41AM -0400, Alex Deucher wrote:
>> >> >> On Wed, Jun 30, 2010 at 3:31 AM, Markus Trippelsdorf
>> >> >> <[email protected]> wrote:
>> >> >> > On Wed, Jun 30, 2010 at 08:54:40AM +0200, Markus Trippelsdorf wrote:
>> >> >> >> On Wed, Jun 30, 2010 at 02:03:04AM +0100, Dave Airlie wrote:
>> >> >> >> >
>> >> >> >> > one fb layer fix in a flag I introduced,
>> >> >> >> >
>> >> >> >> > the rest are drm fixes:
>> >> >> >> > radeon fixes: the larger ones in the command stream checker for older cards,
>> >> >> >> > which was causing a lot of userspace apps to fail. Also some powerpc server fixes.
>> >> >> >> > along with some updates to the evergreen command stream checker introduced in -rc1.
>> >> >> >> >
>> >> >> >> > agp: fix issue with warning on memory allocation + fallback to vmalloc.
>> >> >> >> > ttm: fix regression introduced in -rc1 in memory allocation paths.
>> >> >> >> >
>> >> >> >> > The following changes since commit 7e27d6e778cd87b6f2415515d7127eba53fe5d02:
>> >> >> >> >
>> >> >> >> > ? Linux 2.6.35-rc3 (2010-06-11 19:14:04 -0700)
>> >> >> >> >
>> >> >> >>
>> >> >> >> I've tested these patches and they break my setup (RS780). On reboot, the
>> >> >> >> monitor goes straight to powersaving mode and no framebuffer is shown.
>> >> >> >
>> >> >> > This is the result of the bisection:
>> >> >> >
>> >> >> > 07d4190327b02ab3aaad25a2d168f79d92e8f8c2 is the first bad commit
>> >> >> > commit 07d4190327b02ab3aaad25a2d168f79d92e8f8c2
>> >> >> > Author: Alex Deucher <[email protected]>
>> >> >> > Date: ? Sat Jun 12 11:50:13 2010 -0400
>> >> >> >
>> >> >> > ? ?drm/radeon/kms: fix bandwidth calculation when sideport is present
>> >> >> >
>> >> >> > ? ?Fixes fdo bug 27529:
>> >> >> > ? ?https://bugs.freedesktop.org/show_bug.cgi?id=27529
>> >> >> >
>> >> >> > ? ?Reported-by: [email protected]
>> >> >> > ? ?Signed-off-by: Alex Deucher <[email protected]>
>> >> >> > ? ?Cc: stable <[email protected]>
>> >> >> > ? ?Signed-off-by: Dave Airlie <[email protected]>
>> >> >>
>> >> >> Markus, can you send me a copy of your vbios? as root:
>> >> >> cd /sys/bus/pci/devices/<pci bus id of video card>
>> >> >> echo 1 > rom
>> >> >> cat rom ? /tmp/vbio.rom
>> >> >> echo 0 > rom
>> >> >
>> >> > Attached.
>> >> >
>> >> >>
>> >> >> Also, when you say "on reboot" do you mean the card comes up ok
>> >> >> initially with the new kernel and then fails after a reboot, or fails
>> >> >> directly after booting the new kernel? ?Also, is there an oops or
>> >> >> anything like that in dmesg?
>> >> >
>> >> > It fails directly after booting the new kernel. There is no oops or
>> >> > anything like it in dmesg, because the kernel fails so early that it
>> >> > could not log anything.
>> >>
>> >> Is the machine still pingable? ?Can you ssh in? or is it completely dead?
>> >
>> > I don't think so. There is no disk activivy after the hang, but maybe
>> > the kernel displays an oops, which I just can't see.
>>
>> The attached patch should fix the issue.
>
> Sorry, but it does not. I've still the same issue with your patch
> applied.

New patch attached. The rs690_pm_info function wasn't getting called
at all on rs780/rs880 and it needs to be.

Alex


Attachments:
0001-drm-radeon-kms-igp-fix-possible-divide-by-0-in-bandw.patch (5.26 kB)

2010-06-30 16:11:17

by Markus Trippelsdorf

[permalink] [raw]
Subject: Re: [git pull] drm fixes + agp + one fb patch (bisected)

On Wed, Jun 30, 2010 at 12:04:35PM -0400, Alex Deucher wrote:
> On Wed, Jun 30, 2010 at 11:50 AM, Markus Trippelsdorf
> <[email protected]> wrote:
> > On Wed, Jun 30, 2010 at 11:34:53AM -0400, Alex Deucher wrote:
> >>
> >> The attached patch should fix the issue.
> >
> > Sorry, but it does not. I've still the same issue with your patch
> > applied.
>
> New patch attached. The rs690_pm_info function wasn't getting called
> at all on rs780/rs880 and it needs to be.

Looks good. Thanks Alex.

--
Markus