2020-03-13 15:06:39

by Zheng Wei

Subject: [PATCH] arm64: add blank after 'if'

add blank after 'if' for armv8_deprecated_init()
to make it comply with kernel coding style.

Signed-off-by: Zheng Wei <[email protected]>
---
arch/arm64/kernel/armv8_deprecated.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
index 7832b3216370..4cc581af2d96 100644
--- a/arch/arm64/kernel/armv8_deprecated.c
+++ b/arch/arm64/kernel/armv8_deprecated.c
@@ -630,7 +630,7 @@ static int __init armv8_deprecated_init(void)
register_insn_emulation(&cp15_barrier_ops);

if (IS_ENABLED(CONFIG_SETEND_EMULATION)) {
- if(system_supports_mixed_endian_el0())
+ if (system_supports_mixed_endian_el0())
register_insn_emulation(&setend_ops);
else
pr_info("setend instruction emulation is not supported on this system\n");
--
2.17.1

2020-03-17 22:29:21

by Will Deacon

Subject: Re: [PATCH] arm64: add blank after 'if'

On Fri, Mar 13, 2020 at 10:54:02PM +0800, Zheng Wei wrote:
> add blank after 'if' for armv8_deprecated_init()
> to make it comply with kernel coding style.
>
> Signed-off-by: Zheng Wei <[email protected]>
> ---
> arch/arm64/kernel/armv8_deprecated.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
> index 7832b3216370..4cc581af2d96 100644
> --- a/arch/arm64/kernel/armv8_deprecated.c
> +++ b/arch/arm64/kernel/armv8_deprecated.c
> @@ -630,7 +630,7 @@ static int __init armv8_deprecated_init(void)
> register_insn_emulation(&cp15_barrier_ops);
>
> if (IS_ENABLED(CONFIG_SETEND_EMULATION)) {
> - if(system_supports_mixed_endian_el0())
> + if (system_supports_mixed_endian_el0())
> register_insn_emulation(&setend_ops);
> else
> pr_info("setend instruction emulation is not supported on this system\n");

(Catalin: I'm just acking these trivial typo/style fixes to get them out
of my inbox; do whatever you like with them ;)

Acked-by: Will Deacon <[email protected]>

Will

2020-03-18 05:33:47

by 王文虎

Subject: Re:Re: [PATCH] arm64: add blank after 'if'

From: Will Deacon <[email protected]>
Date: 2020-03-18 06:28:24
To: Zheng Wei <[email protected]>
Cc: Catalin Marinas <[email protected]>,Hanjun Guo <[email protected]>,Enrico Weigelt <[email protected]>,Allison Randal <[email protected]>,Greg Kroah-Hartman <[email protected]>,Thomas Gleixner <[email protected]>,Yunfeng Ye <[email protected]>,[email protected],[email protected],[email protected],[email protected]
Subject: Re: [PATCH] arm64: add blank after 'if'>On Fri, Mar 13, 2020 at 10:54:02PM +0800, Zheng Wei wrote:
>> add blank after 'if' for armv8_deprecated_init()
>> to make it comply with kernel coding style.
>>
>> Signed-off-by: Zheng Wei <[email protected]>
>> ---
>> arch/arm64/kernel/armv8_deprecated.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
>> index 7832b3216370..4cc581af2d96 100644
>> --- a/arch/arm64/kernel/armv8_deprecated.c
>> +++ b/arch/arm64/kernel/armv8_deprecated.c
>> @@ -630,7 +630,7 @@ static int __init armv8_deprecated_init(void)
>> register_insn_emulation(&cp15_barrier_ops);
>>
>> if (IS_ENABLED(CONFIG_SETEND_EMULATION)) {
>> - if(system_supports_mixed_endian_el0())
>> + if (system_supports_mixed_endian_el0())
>> register_insn_emulation(&setend_ops);
>> else
>> pr_info("setend instruction emulation is not supported on this system\n");
>
>(Catalin: I'm just acking these trivial typo/style fixes to get them out
>of my inbox; do whatever you like with them ;)
>
>Acked-by: Will Deacon <[email protected]>
>
>Will

Shouldn't you have Cc trivial<[email protected]>?
Asked-by: Wang Wenhu <[email protected]>

Wenhu

2020-03-18 09:32:29

by Catalin Marinas

Subject: Re: Re: [PATCH] arm64: add blank after 'if'

On Wed, Mar 18, 2020 at 01:32:28PM +0800, 王文虎 wrote:
> From: Will Deacon <[email protected]>
> Date: 2020-03-18 06:28:24
> To: Zheng Wei <[email protected]>
> Cc: Catalin Marinas <[email protected]>,Hanjun Guo <[email protected]>,Enrico Weigelt <[email protected]>,Allison Randal <[email protected]>,Greg Kroah-Hartman <[email protected]>,Thomas Gleixner <[email protected]>,Yunfeng Ye <[email protected]>,[email protected],[email protected],[email protected],[email protected]
> Subject: Re: [PATCH] arm64: add blank after 'if'>On Fri, Mar 13, 2020 at 10:54:02PM +0800, Zheng Wei wrote:
> >> add blank after 'if' for armv8_deprecated_init()
> >> to make it comply with kernel coding style.
> >>
> >> Signed-off-by: Zheng Wei <[email protected]>
> >> ---
> >> arch/arm64/kernel/armv8_deprecated.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
> >> index 7832b3216370..4cc581af2d96 100644
> >> --- a/arch/arm64/kernel/armv8_deprecated.c
> >> +++ b/arch/arm64/kernel/armv8_deprecated.c
> >> @@ -630,7 +630,7 @@ static int __init armv8_deprecated_init(void)
> >> register_insn_emulation(&cp15_barrier_ops);
> >>
> >> if (IS_ENABLED(CONFIG_SETEND_EMULATION)) {
> >> - if(system_supports_mixed_endian_el0())
> >> + if (system_supports_mixed_endian_el0())
> >> register_insn_emulation(&setend_ops);
> >> else
> >> pr_info("setend instruction emulation is not supported on this system\n");
> >
> >(Catalin: I'm just acking these trivial typo/style fixes to get them out
> >of my inbox; do whatever you like with them ;)
> >
> >Acked-by: Will Deacon <[email protected]>
> >
> >Will
>
> Shouldn't you have Cc trivial<[email protected]>?
> Asked-by: Wang Wenhu <[email protected]>

I queued them already, they are in arm64 for-next/core. In the future,
it they could as well go in via [email protected] (as long as there are
no serious conflicts).

--
Catalin